From: Andreas Dilger <adilger@turbolabs.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: Andrew Morton <akpm@zip.com.au>,
ext2-devel@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [Ext2-devel] ext2/ialloc.c cleanup
Date: Thu, 8 Nov 2001 15:43:12 -0700 [thread overview]
Message-ID: <20011108154311.E9043@lynx.no> (raw)
In-Reply-To: <3BEAEEE5.5F5BA8C0@zip.com.au> <Pine.GSO.4.21.0111081707490.8052-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0111081707490.8052-100000@weyl.math.psu.edu>; from viro@math.psu.edu on Thu, Nov 08, 2001 at 05:16:17PM -0500
On Nov 08, 2001 17:16 -0500, Alexander Viro wrote:
> + get_random_bytes(&group, sizeof(group));
> + goto fallback;
Little chance that 0 <= group < ngroups. Even so, value is unused, AFAICS.
> +fallback:
> + for (i = 0; i < ngroups; i++) {
> + group = (parent_cg + i) % ngroups;
> + cg = ext2_get_group_desc (sb, group, &bh);
> + if (!cg || !cg->bg_free_inodes_count)
> + continue;
> + if (le16_to_cpu(cg->bg_free_inodes_count) >= avefreei)
> + goto found;
> + }
> +
> + return -1;
> diff -urN S14/include/linux/ext2_fs_sb.h S14-ext2/include/linux/ext2_fs_sb.h
> --- S14/include/linux/ext2_fs_sb.h Fri Feb 16 21:29:52 2001
> +++ S14-ext2/include/linux/ext2_fs_sb.h Thu Nov 8 15:28:34 2001
> @@ -56,6 +56,8 @@
> int s_desc_per_block_bits;
> int s_inode_size;
> int s_first_ino;
> + unsigned long s_dir_count;
> + u8 *debts;
> };
I had thought a couple of times it may be useful to have an in-memory list
of group descriptors, each with a pointer to the on-disk struct, like
ext2_sb points to s_es.
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
next prev parent reply other threads:[~2001-11-08 22:45 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-05 2:13 disk throughput Andrew Morton
2001-11-05 3:20 ` Mohammad A. Haque
2001-11-05 3:31 ` Andrew Morton
2001-11-05 3:32 ` [Ext2-devel] " Mike Fedyk
2001-11-05 3:45 ` Andrew Morton
2001-11-05 4:39 ` Mike Fedyk
2001-11-05 7:06 ` Jens Axboe
2001-11-05 7:14 ` Andrew Morton
2001-11-05 7:26 ` Jens Axboe
2001-11-05 7:14 ` Mike Fedyk
2001-11-05 7:18 ` Jens Axboe
2001-11-05 7:18 ` Jens Axboe
2001-11-05 9:14 ` Mike Fedyk
2001-11-05 9:20 ` Jens Axboe
2001-11-05 5:54 ` Albert D. Cahalan
2001-11-05 8:04 ` Andrew Morton
2001-11-05 12:28 ` Matthias Andree
2001-11-05 14:23 ` Alexander Viro
2001-11-05 22:22 ` Andrew Morton
2001-11-05 22:41 ` Andreas Dilger
2001-11-05 22:53 ` Andrew Morton
2001-11-08 15:28 ` Constantin Loizides
2001-11-05 23:14 ` Dan Hollis
2001-11-06 10:52 ` Daniel Phillips
2001-11-06 16:17 ` Jeremy Fitzhardinge
2001-11-08 15:24 ` Constantin Loizides
2001-11-08 16:46 ` Jeremy Fitzhardinge
2001-11-09 6:08 ` Andrew Morton
2001-11-09 8:49 ` Jeremy Fitzhardinge
2001-11-06 21:45 ` Stephen Tweedie
2001-11-05 20:16 ` Andreas Dilger
2001-11-05 20:28 ` m
2001-11-05 21:39 ` Andrew Morton
2001-11-05 22:59 ` Linus Torvalds
2001-11-05 23:36 ` Alexander Viro
2001-11-05 23:50 ` Linus Torvalds
2001-11-06 0:03 ` Linus Torvalds
2001-11-06 1:33 ` Alexander Viro
2001-11-06 2:10 ` Linus Torvalds
2001-11-06 3:02 ` Alexander Viro
2001-11-06 8:39 ` Alan Cox
2001-11-06 8:37 ` Alexander Viro
2001-11-06 8:48 ` Andrew Morton
2001-11-06 3:49 ` Alexander Viro
2001-11-06 4:01 ` Linus Torvalds
2001-11-06 4:21 ` Alexander Viro
2001-11-06 5:01 ` Linus Torvalds
2001-11-06 5:31 ` Andrew Morton
2001-11-06 5:48 ` Linus Torvalds
2001-11-06 7:34 ` Mike Castle
2001-11-06 7:10 ` Kai Henningsen
2001-11-09 22:35 ` Riley Williams
2001-11-06 1:28 ` Alexander Viro
2001-11-06 9:16 ` Wojtek Pilorz
2001-11-06 9:58 ` Alexander Viro
2001-11-08 12:51 ` Pavel Machek
2001-11-06 21:48 ` Stephen Tweedie
2001-11-06 23:17 ` ext2/ialloc.c cleanup Alexander Viro
2001-11-07 19:34 ` [Ext2-devel] " Andreas Dilger
2001-11-07 20:02 ` Alexander Viro
2001-11-08 2:06 ` Andrew Morton
2001-11-08 20:45 ` Andrew Morton
2001-11-08 22:16 ` Alexander Viro
2001-11-08 22:43 ` Andreas Dilger [this message]
2001-11-08 23:08 ` Alexander Viro
2001-11-09 6:15 ` Andrew Morton
2001-11-09 6:56 ` Andreas Dilger
2001-11-09 7:09 ` Andrew Morton
2001-11-09 7:12 ` Alexander Viro
2001-11-09 7:18 ` Andrew Morton
2001-11-05 9:45 ` [Ext2-devel] disk throughput Alex Bligh - linux-kernel
2001-11-05 9:58 ` Alex Bligh - linux-kernel
2001-11-05 8:47 ` Jan Kara
2001-11-05 8:50 ` [Ext2-devel] " Mike Fedyk
2001-11-05 9:01 ` Jan Kara
2001-11-05 12:23 ` Matthias Andree
2001-11-05 22:39 ` Andrew Morton
2001-11-05 23:41 ` Matthias Andree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011108154311.E9043@lynx.no \
--to=adilger@turbolabs.com \
--cc=akpm@zip.com.au \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).