From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, Matt Evans <matt@ozlabs.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@fb.com>,
Denis Kirjanov <kda@linux-powerpc.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Subject: Re: [PATCH] ppc: Fix BPF JIT for ABIv2
Date: Sun, 19 Jun 2016 23:19:14 +0530 [thread overview]
Message-ID: <20160619174914.GC8886@naverao1-tp.localdomain> (raw)
In-Reply-To: <20160617130042.GO3516@indiana.gru.redhat.com>
On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Jun 17, 2016 at 10:53:21PM +1000, Michael Ellerman wrote:
> > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote:
> > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c
> > > new file mode 100644
> > > index 0000000..954ff53
> > > --- /dev/null
> > > +++ b/arch/powerpc/net/bpf_jit_comp64.c
> > > @@ -0,0 +1,956 @@
> > ...
> > > +
> > > +static void bpf_jit_fill_ill_insns(void *area, unsigned int size)
> > > +{
> > > + int *p = area;
> > > +
> > > + /* Fill whole space with trap instructions */
> > > + while (p < (int *)((char *)area + size))
> > > + *p++ = BREAKPOINT_INSTRUCTION;
> > > +}
> >
> > This breaks the build for some configs, presumably you're missing a header:
> >
> > arch/powerpc/net/bpf_jit_comp64.c:30:10: error: 'BREAKPOINT_INSTRUCTION' undeclared (first use in this function)
> >
> > http://kisskb.ellerman.id.au/kisskb/buildresult/12720611/
> >
> > cheers
>
> Hi, Michael and Naveen.
>
> I noticed independently that there is a problem with BPF JIT and ABIv2, and
> worked out the patch below before I noticed Naveen's patchset and the latest
> changes in ppc tree for a better way to check for ABI versions.
>
> However, since the issue described below affect mainline and stable kernels,
> would you consider applying it before merging your two patchsets, so that we can
> more easily backport the fix?
Hi Cascardo,
Given that this has been broken on ABIv2 since forever, I didn't bother
fixing it. But, I can see why this would be a good thing to have for
-stable and existing distros. However, while your patch below may fix
the crash you're seeing on ppc64le, it is not sufficient -- you'll need
changes in bpf_jit_asm.S as well.
Regards,
Naveen
next prev parent reply other threads:[~2016-06-19 17:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 13:32 [PATCH 0/6] eBPF JIT for PPC64 Naveen N. Rao
2016-06-07 13:32 ` [PATCH 1/6] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation Naveen N. Rao
2016-06-07 13:32 ` [PATCH 2/6] ppc: bpf/jit: Optimize 64-bit Immediate loads Naveen N. Rao
2016-06-07 13:32 ` [PATCH 3/6] ppc: bpf/jit: Introduce rotate immediate instructions Naveen N. Rao
2016-06-07 13:32 ` [PATCH 4/6] ppc: bpf/jit: A few cleanups Naveen N. Rao
2016-06-07 13:32 ` [PATCH 5/6] ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header Naveen N. Rao
2016-06-07 13:32 ` [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-07 22:56 ` Alexei Starovoitov
2016-06-08 17:17 ` Naveen N. Rao
2016-06-09 3:19 ` Nilay Vaish
2016-06-09 6:07 ` Naveen N. Rao
2016-06-17 12:53 ` [6/6] " Michael Ellerman
2016-06-17 13:00 ` [PATCH] ppc: Fix BPF JIT for ABIv2 Thadeu Lima de Souza Cascardo
2016-06-19 17:49 ` Naveen N. Rao [this message]
2016-06-20 18:56 ` Thadeu Lima de Souza Cascardo
2016-06-21 8:58 ` Naveen N. Rao
2016-06-21 11:15 ` Michael Ellerman
2016-06-21 14:47 ` Thadeu Lima de Souza Cascardo
2016-06-21 15:45 ` Alexei Starovoitov
2016-06-22 4:06 ` Michael Ellerman
2016-06-22 7:12 ` Naveen N. Rao
2016-06-22 14:57 ` Naveen N. Rao
2016-06-22 5:20 ` Michael Ellerman
2016-06-22 5:18 ` Michael Ellerman
2016-06-19 17:36 ` [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Naveen N. Rao
2016-06-20 23:38 ` Michael Ellerman
2016-06-21 6:58 ` Naveen N. Rao
2016-06-21 11:04 ` Michael Ellerman
2016-06-22 7:06 ` Naveen N. Rao
2016-06-22 10:37 ` [PATCH 6/6] " Michael Ellerman
2016-06-22 12:32 ` Naveen N. Rao
2016-06-11 5:47 ` [PATCH 0/6] eBPF JIT for PPC64 David Miller
2016-06-13 5:40 ` Naveen N. Rao
2016-06-18 4:57 ` mpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160619174914.GC8886@naverao1-tp.localdomain \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=ast@fb.com \
--cc=cascardo@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).