From: Arnd Bergmann <arnd@arndb.de>
To: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Nicolas Pitre <nico@linaro.org>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Borislav Petkov <bpetkov@suse.de>,
Andy Lutomirski <luto@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 1/3] x86: dumpstack: avoid uninitlized variable
Date: Fri, 2 Feb 2018 15:56:17 +0100 [thread overview]
Message-ID: <20180202145634.200291-1-arnd@arndb.de> (raw)
In-Reply-To: <20180202145434.100626-1-arnd@arndb.de>
In some configurations, 'partial' does not get initialized,
as shown by this gcc-8 warning:
arch/x86/kernel/dumpstack.c: In function 'show_trace_log_lvl':
arch/x86/kernel/dumpstack.c:156:4: error: 'partial' may be used uninitialized in this function [-Werror=maybe-uninitialized]
show_regs_if_on_stack(&stack_info, regs, partial);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This initializes it to false, to get the previous behavior in
this case.
a9cdbe72c4e8 ("x86/dumpstack: Fix partial register dumps")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/kernel/dumpstack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index afbecff161d1..a2d8a3908670 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -109,7 +109,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
struct stack_info stack_info = {0};
unsigned long visit_mask = 0;
int graph_idx = 0;
- bool partial;
+ bool partial = false;
printk("%sCall Trace:\n", log_lvl);
--
2.9.0
next prev parent reply other threads:[~2018-02-02 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 14:54 [PATCH 0/3] x86 bugfixes for LTO Arnd Bergmann
2018-02-02 14:56 ` Arnd Bergmann [this message]
2018-02-02 14:56 ` [PATCH 2/3] x86: fix swsusp_arch_resume prototype Arnd Bergmann
2018-02-02 22:37 ` [tip:x86/urgent] x86/power: Fix " tip-bot for Arnd Bergmann
2018-02-08 10:12 ` [PATCH 2/3] x86: fix " Rafael J. Wysocki
2018-02-02 14:56 ` [PATCH 3/3] x86: error_inject: make just_return_func globally visible Arnd Bergmann
2018-02-03 13:21 ` Masami Hiramatsu
2018-02-13 15:25 ` [tip:x86/urgent] x86/error_inject: Make just_return_func() " tip-bot for Arnd Bergmann
2018-02-02 22:36 ` [tip:x86/urgent] x86/dumpstack: Avoid uninitlized variable tip-bot for Arnd Bergmann
2018-02-05 21:21 ` Arnd Bergmann
2018-02-05 21:39 ` Josh Poimboeuf
2018-02-05 21:48 ` Arnd Bergmann
2018-02-09 22:24 ` [PATCH 0/3] x86 bugfixes for LTO Chris Wilson
2018-02-09 23:00 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202145634.200291-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ak@linux.intel.com \
--cc=bpetkov@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nico@linaro.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).