From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Nicolas Pitre <nico@linaro.org>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Josef Bacik <jbacik@fb.com>, Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH 3/3] x86: error_inject: make just_return_func globally visible
Date: Sat, 3 Feb 2018 22:21:28 +0900 [thread overview]
Message-ID: <20180203222128.c551eb3e12bd38d3341ce3de@kernel.org> (raw)
In-Reply-To: <20180202145634.200291-3-arnd@arndb.de>
On Fri, 2 Feb 2018 15:56:19 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> With link time optimizations enabled, I get a link failure:
>
> ./ccLbOEHX.ltrans19.ltrans.o: In function `override_function_with_return':
> <artificial>:(.text+0x7f3): undefined reference to `just_return_func'
>
> Marking the symbol .globl makes it work as expected.
Good catch!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> Fixes: 540adea3809f ("error-injection: Separate error-injection from kprobe")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/x86/lib/error-inject.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/lib/error-inject.c b/arch/x86/lib/error-inject.c
> index 7b881d03d0dd..3cdf06128d13 100644
> --- a/arch/x86/lib/error-inject.c
> +++ b/arch/x86/lib/error-inject.c
> @@ -7,6 +7,7 @@ asmlinkage void just_return_func(void);
>
> asm(
> ".type just_return_func, @function\n"
> + ".globl just_return_func\n"
> "just_return_func:\n"
> " ret\n"
> ".size just_return_func, .-just_return_func\n"
> --
> 2.9.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-02-03 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 14:54 [PATCH 0/3] x86 bugfixes for LTO Arnd Bergmann
2018-02-02 14:56 ` [PATCH 1/3] x86: dumpstack: avoid uninitlized variable Arnd Bergmann
2018-02-02 14:56 ` [PATCH 2/3] x86: fix swsusp_arch_resume prototype Arnd Bergmann
2018-02-02 22:37 ` [tip:x86/urgent] x86/power: Fix " tip-bot for Arnd Bergmann
2018-02-08 10:12 ` [PATCH 2/3] x86: fix " Rafael J. Wysocki
2018-02-02 14:56 ` [PATCH 3/3] x86: error_inject: make just_return_func globally visible Arnd Bergmann
2018-02-03 13:21 ` Masami Hiramatsu [this message]
2018-02-13 15:25 ` [tip:x86/urgent] x86/error_inject: Make just_return_func() " tip-bot for Arnd Bergmann
2018-02-02 22:36 ` [tip:x86/urgent] x86/dumpstack: Avoid uninitlized variable tip-bot for Arnd Bergmann
2018-02-05 21:21 ` Arnd Bergmann
2018-02-05 21:39 ` Josh Poimboeuf
2018-02-05 21:48 ` Arnd Bergmann
2018-02-09 22:24 ` [PATCH 0/3] x86 bugfixes for LTO Chris Wilson
2018-02-09 23:00 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180203222128.c551eb3e12bd38d3341ce3de@kernel.org \
--to=mhiramat@kernel.org \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=hpa@zytor.com \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nico@linaro.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).