From: Arnd Bergmann <arnd@arndb.de>
To: Ingo Molnar <mingo@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Nicolas Pitre <nico@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Vlastimil Babka <vbabka@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
bpetkov@suse.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/dumpstack: Avoid uninitlized variable
Date: Mon, 5 Feb 2018 22:21:06 +0100 [thread overview]
Message-ID: <CAK8P3a3MMwRQ00YxuPhEmNzqiMn4+VX48b82831i+kCqruCMfQ@mail.gmail.com> (raw)
In-Reply-To: <tip-ebfc15019cfa72496c674ffcb0b8ef10790dcddc@git.kernel.org>
On Fri, Feb 2, 2018 at 11:36 PM, tip-bot for Arnd Bergmann
<tipbot@zytor.com> wrote:
> Commit-ID: ebfc15019cfa72496c674ffcb0b8ef10790dcddc
> Gitweb: https://git.kernel.org/tip/ebfc15019cfa72496c674ffcb0b8ef10790dcddc
> Author: Arnd Bergmann <arnd@arndb.de>
> AuthorDate: Fri, 2 Feb 2018 15:56:17 +0100
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Fri, 2 Feb 2018 23:33:50 +0100
>
> x86/dumpstack: Avoid uninitlized variable
>
> In some configurations, 'partial' does not get initialized, as shown by
> this gcc-8 warning:
>
> arch/x86/kernel/dumpstack.c: In function 'show_trace_log_lvl':
> arch/x86/kernel/dumpstack.c:156:4: error: 'partial' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> show_regs_if_on_stack(&stack_info, regs, partial);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This initializes it to false, to get the previous behavior in this case.
>
> Fixes: a9cdbe72c4e8 ("x86/dumpstack: Fix partial register dumps")
I just noticed my annotation got lost when I sent the patch. I originally
meant to ask Josh to double-check whether it should be 'false' or 'true'
here, or if we maybe need a larger change.
Josh, could you take a look? Unfortunately I did not really understand
your original commit, so I don't know what the safe choice is here
in those cases in which 'partial' is uninitialized.
Arnd
next prev parent reply other threads:[~2018-02-05 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 14:54 [PATCH 0/3] x86 bugfixes for LTO Arnd Bergmann
2018-02-02 14:56 ` [PATCH 1/3] x86: dumpstack: avoid uninitlized variable Arnd Bergmann
2018-02-02 14:56 ` [PATCH 2/3] x86: fix swsusp_arch_resume prototype Arnd Bergmann
2018-02-02 22:37 ` [tip:x86/urgent] x86/power: Fix " tip-bot for Arnd Bergmann
2018-02-08 10:12 ` [PATCH 2/3] x86: fix " Rafael J. Wysocki
2018-02-02 14:56 ` [PATCH 3/3] x86: error_inject: make just_return_func globally visible Arnd Bergmann
2018-02-03 13:21 ` Masami Hiramatsu
2018-02-13 15:25 ` [tip:x86/urgent] x86/error_inject: Make just_return_func() " tip-bot for Arnd Bergmann
2018-02-02 22:36 ` [tip:x86/urgent] x86/dumpstack: Avoid uninitlized variable tip-bot for Arnd Bergmann
2018-02-05 21:21 ` Arnd Bergmann [this message]
2018-02-05 21:39 ` Josh Poimboeuf
2018-02-05 21:48 ` Arnd Bergmann
2018-02-09 22:24 ` [PATCH 0/3] x86 bugfixes for LTO Chris Wilson
2018-02-09 23:00 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3MMwRQ00YxuPhEmNzqiMn4+VX48b82831i+kCqruCMfQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=ak@linux.intel.com \
--cc=bpetkov@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nico@linaro.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).