From: Guo Ren <ren_guo@c-sky.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH V9 01/21] csky: Build infrastructure
Date: Fri, 26 Oct 2018 01:04:08 +0800 [thread overview]
Message-ID: <20181025170407.GA9747@guoren-Inspiron-7460> (raw)
In-Reply-To: <CAK8P3a2coXVaaiZUcxsp8DmWcVdBrDMomYAN--M42TuSnHxKNA@mail.gmail.com>
On Wed, Oct 24, 2018 at 11:53:05PM +0100, Arnd Bergmann wrote:
> On Tue, Oct 23, 2018 at 1:08 AM Guo Ren <ren_guo@c-sky.com> wrote:
> >
> > Hi Arnd,
> >
> > Could you help me review the patch, seems the patch is skipped.
> > ref: https://lkml.org/lkml/2018/10/16/224
>
> Ah right, I missed that. I think I originally had some thoughts on it but
> didn't immediately comment and then forgot about it. It's basically
> ok, so
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thx.
>
> but please have a look below for a follow-up patch:
>
> > > diff --git a/arch/csky/include/asm/Kbuild b/arch/csky/include/asm/Kbuild
> > > new file mode 100644
> > > index 0000000..014eb57
> > > --- /dev/null
> > > +++ b/arch/csky/include/asm/Kbuild
> > > @@ -0,0 +1,72 @@
> > > +generic-y += asm-offsets.h
> > > +generic-y += bitsperlong.h
> > > +generic-y += bugs.h
> > > +generic-y += clkdev.h
> > > +generic-y += compat.h
> > > +generic-y += current.h
> > > +generic-y += delay.h
> > > +generic-y += device.h
> > > +generic-y += div64.h
> ...
> > > +generic-y += errno.h
> ...
> > > +generic-y += ioctl.h
> > > +generic-y += ioctls.h
>
> A number of the header files that are marked as generic-y in
> asm/Kbuild are also marked the same way in uapi/asm/Kbuild.
> I think this is a mistake, since we only need one of the two
> for each header.
>
> When both exist, we just take the one from asm/, but then we install
> the uapi/asm/ version in the 'make headers_install' stage, and they
> both have the same contents, so I think you only need the uapi/asm/
> version here.
Ok, I've cleaned them up.
>
> > > diff --git a/arch/csky/include/uapi/asm/Kbuild b/arch/csky/include/uapi/asm/Kbuild
> > > new file mode 100644
> > > index 0000000..b65252b
> > > --- /dev/null
> > > +++ b/arch/csky/include/uapi/asm/Kbuild
> > > @@ -0,0 +1,33 @@
> > > +include include/uapi/asm-generic/Kbuild.asm
> > > +
> > > +header-y += cachectl.h
> > > +header-y += stat.h
>
> It also seems that the second statement here (for stat.h) is from
> an older version, since that header no longer exists, at least if
> I'm reading your patches correctly.
Yes, no "header-y += stat.h" and I've removed it.
Thx for the reviewed.
Best Regards
Guo Ren
next prev parent reply other threads:[~2018-10-25 17:04 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 2:58 [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port Guo Ren
2018-10-16 2:58 ` [PATCH V9 01/21] csky: Build infrastructure Guo Ren
2018-10-23 0:08 ` Guo Ren
2018-10-24 22:53 ` Arnd Bergmann
2018-10-25 17:04 ` Guo Ren [this message]
2018-10-16 2:58 ` [PATCH V9 02/21] csky: defconfig Guo Ren
2018-10-17 14:56 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 03/21] csky: Kernel booting Guo Ren
2018-10-17 14:58 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 04/21] csky: Exception handling and mm-fault Guo Ren
2018-10-17 14:59 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 05/21] csky: System Call Guo Ren
2018-10-17 15:02 ` Arnd Bergmann
2018-10-18 2:02 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 06/21] csky: Cache and TLB routines Guo Ren
2018-10-17 15:08 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 07/21] csky: MMU and page table management Guo Ren
2018-10-17 15:06 ` Arnd Bergmann
2018-10-18 2:05 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 08/21] csky: Process management and Signal Guo Ren
2018-10-17 15:11 ` Arnd Bergmann
2018-10-18 2:37 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 09/21] csky: VDSO and rt_sigreturn Guo Ren
2018-10-17 15:13 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 10/21] csky: IRQ handling Guo Ren
2018-10-17 15:14 ` Arnd Bergmann
2018-10-18 2:39 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 11/21] csky: Atomic operations Guo Ren
2018-10-17 15:17 ` Arnd Bergmann
2018-10-18 2:40 ` Guo Ren
2018-10-21 20:55 ` Peter Zijlstra
2018-10-22 1:52 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 12/21] csky: ELF and module probe Guo Ren
2018-10-17 15:18 ` Arnd Bergmann
2018-10-18 2:49 ` Guo Ren
2018-10-18 8:31 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 13/21] csky: Library functions Guo Ren
2018-10-17 15:24 ` Arnd Bergmann
2018-10-18 3:10 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 14/21] csky: User access Guo Ren
2018-10-17 15:37 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 15/21] csky: Debug and Ptrace GDB Guo Ren
2018-10-17 15:46 ` Arnd Bergmann
2018-10-18 3:17 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 16/21] csky: SMP support Guo Ren
2018-10-17 15:47 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 17/21] csky: Misc headers Guo Ren
2018-10-17 15:49 ` Arnd Bergmann
2018-10-16 2:58 ` [PATCH V9 18/21] dt-bindings: csky CPU Bindings Guo Ren
2018-10-17 15:50 ` Arnd Bergmann
2018-10-18 3:21 ` Guo Ren
2018-10-18 3:45 ` Guo Ren
2018-10-18 14:31 ` Rob Herring
2018-10-19 2:19 ` Guo Ren
2018-10-16 2:58 ` [PATCH V9 19/21] dt-bindings: Add vendor prefix for csky Guo Ren
2018-10-16 2:58 ` [PATCH V9 20/21] MAINTAINERS: Add csky Guo Ren
2018-10-17 15:51 ` Arnd Bergmann
2018-10-16 5:48 ` [PATCH V9 21/21] csky: support dword access for get_user_size() Guo Ren
2018-10-17 15:44 ` Arnd Bergmann
2018-10-18 3:41 ` Guo Ren
2018-10-18 8:34 ` Arnd Bergmann
2018-10-18 8:57 ` Guo Ren
2018-10-24 7:17 ` Arnd Bergmann
2018-10-25 17:08 ` Guo Ren
2018-10-17 15:58 ` [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port Arnd Bergmann
2018-10-18 4:10 ` Guo Ren
2018-10-18 8:36 ` Arnd Bergmann
2018-10-18 9:03 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025170407.GA9747@guoren-Inspiron-7460 \
--to=ren_guo@c-sky.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).