From: Mark Rutland <mark.rutland@arm.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: robh+dt@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
andy@infradead.org, dvhart@infradead.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, hutao@cn.fujitsu.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH V5 4/8] misc/pvpanic :convert to SPDX license tags
Date: Thu, 1 Nov 2018 11:39:00 +0000 [thread overview]
Message-ID: <20181101113859.lxygduzen3cjsdt6@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1541085002-42993-4-git-send-email-peng.hao2@zte.com.cn>
Hi,
Please fix the spacing for the colon in the commit title. It should be
formatted as:
misc/pvpanic: convert to SPDX license tags
On Thu, Nov 01, 2018 at 11:09:58PM +0800, Peng Hao wrote:
> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Other than the commit title, this looks fine to me:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> drivers/misc/pvpanic.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 66534d4..0bcf1cd 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -1,21 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0+
> /*
> - * pvpanic.c - pvpanic Device Support
> + * Pvpanic Device Support
> *
> * Copyright (C) 2013 Fujitsu.
> *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2018-11-01 11:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 15:09 [PATCH V5 1/8] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-11-01 13:10 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 2/8] misc/pvpanic: Remove one extra semicolon Peng Hao
2018-11-01 11:33 ` Mark Rutland
2018-11-01 13:38 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file Peng Hao
2018-11-01 11:34 ` Mark Rutland
2018-11-01 11:35 ` Mark Rutland
2018-11-01 13:41 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 4/8] misc/pvpanic :convert to SPDX license tags Peng Hao
2018-11-01 11:39 ` Mark Rutland [this message]
2018-11-01 13:42 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 5/8] misc/pvpanic: simplify the code using acpi_dev_resource_io Peng Hao
2018-11-01 13:44 ` Andy Shevchenko
2018-11-01 15:10 ` [PATCH V5 6/8] misc/pvpanic: add MMIO support Peng Hao
2018-11-01 11:42 ` Mark Rutland
2018-11-01 17:04 ` Andy Shevchenko
2018-11-01 15:10 ` [PATCH V5 7/8] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-11-01 11:47 ` Mark Rutland
2018-11-01 15:10 ` [PATCH V5 8/8] dt-bindings/misc/pvpanic :add document for pvpanic-mmio Peng Hao
2018-11-01 11:46 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101113859.lxygduzen3cjsdt6@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.hao2@zte.com.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).