From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: peng.hao2@zte.com.cn, Rob Herring <robh+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
hutao@cn.fujitsu.com,
Linux Documentation List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH V5 2/8] misc/pvpanic: Remove one extra semicolon
Date: Thu, 1 Nov 2018 15:38:24 +0200 [thread overview]
Message-ID: <CAHp75VdTzFJ9ggQ+eMn-bAfbtXC4w69R+7UjYvWom6ALV9NfPA@mail.gmail.com> (raw)
In-Reply-To: <20181101113355.z6l3l33buhcpukl4@lakrids.cambridge.arm.com>
On Thu, Nov 1, 2018 at 1:34 PM Mark Rutland <mark.rutland@arm.com> wrote:
>
> On Thu, Nov 01, 2018 at 11:09:56PM +0800, Peng Hao wrote:
> > There is an extra semicolon in pvpanic_device_ids, remove it.
>
> This is a comma, not a semicolon.
>
> How about:
>
> Since there should be nothing after the sentinel entry in an
> acpi_device_id list, it doesn't make sense for it to have a trailing
> comma.
>
> This patch removes the redundant comma.
>
> ... with that commit message (and the title fixed to say 'comma' rather
> than 'semicolon':
Agree on this, but...
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Either that, or simply drop this patch entirely.
...point was to gather style changes here, like moving linux/acpi.h.
And definitely the style changes should go last in the series.
If you decide to leave this patch, it would be 8/8.
>
> Thanks,
> Mark.
>
> >
> > Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> > ---
> > drivers/misc/pvpanic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> > index fd86dab..059005c 100644
> > --- a/drivers/misc/pvpanic.c
> > +++ b/drivers/misc/pvpanic.c
> > @@ -35,7 +35,7 @@
> >
> > static const struct acpi_device_id pvpanic_device_ids[] = {
> > { "QEMU0001", 0 },
> > - { "", 0 },
> > + { "", 0 }
> > };
> > MODULE_DEVICE_TABLE(acpi, pvpanic_device_ids);
> >
> > --
> > 1.8.3.1
> >
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-01 13:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 15:09 [PATCH V5 1/8] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-11-01 13:10 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 2/8] misc/pvpanic: Remove one extra semicolon Peng Hao
2018-11-01 11:33 ` Mark Rutland
2018-11-01 13:38 ` Andy Shevchenko [this message]
2018-11-01 15:09 ` [PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file Peng Hao
2018-11-01 11:34 ` Mark Rutland
2018-11-01 11:35 ` Mark Rutland
2018-11-01 13:41 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 4/8] misc/pvpanic :convert to SPDX license tags Peng Hao
2018-11-01 11:39 ` Mark Rutland
2018-11-01 13:42 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 5/8] misc/pvpanic: simplify the code using acpi_dev_resource_io Peng Hao
2018-11-01 13:44 ` Andy Shevchenko
2018-11-01 15:10 ` [PATCH V5 6/8] misc/pvpanic: add MMIO support Peng Hao
2018-11-01 11:42 ` Mark Rutland
2018-11-01 17:04 ` Andy Shevchenko
2018-11-01 15:10 ` [PATCH V5 7/8] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-11-01 11:47 ` Mark Rutland
2018-11-01 15:10 ` [PATCH V5 8/8] dt-bindings/misc/pvpanic :add document for pvpanic-mmio Peng Hao
2018-11-01 11:46 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdTzFJ9ggQ+eMn-bAfbtXC4w69R+7UjYvWom6ALV9NfPA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.hao2@zte.com.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).