From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: peng.hao2@zte.com.cn
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
hutao@cn.fujitsu.com,
Linux Documentation List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH V5 6/8] misc/pvpanic: add MMIO support
Date: Thu, 1 Nov 2018 19:04:00 +0200 [thread overview]
Message-ID: <CAHp75VfNDKgenuc0ApMODfCw6h9azwBDskPuV2S4E8nLFsuTxw@mail.gmail.com> (raw)
In-Reply-To: <1541085002-42993-6-git-send-email-peng.hao2@zte.com.cn>
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao <peng.hao2@zte.com.cn> wrote:
>
> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> this can be used standalone. Add MMIO support to the pvpanic driver.
> - if (acpi_dev_resource_io(res, &r) {
> - port = r.start;
> + if (acpi_dev_resource_io(res, &r) ||
> + acpi_dev_resource_memory(res, &r)) {
> + if (r.flags & IORESOURCE_IO)
You need spend some time to understand better how acpi_dev_resource_*() works.
Hint: this condition is redundant.
> + base = (void __iomem *) ioport_map(r.start,
> + r.end - r.start + 1);
> + else
> + base = ioremap(r.start, r.end - r.start + 1);
> +
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-01 17:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 15:09 [PATCH V5 1/8] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-11-01 13:10 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 2/8] misc/pvpanic: Remove one extra semicolon Peng Hao
2018-11-01 11:33 ` Mark Rutland
2018-11-01 13:38 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file Peng Hao
2018-11-01 11:34 ` Mark Rutland
2018-11-01 11:35 ` Mark Rutland
2018-11-01 13:41 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 4/8] misc/pvpanic :convert to SPDX license tags Peng Hao
2018-11-01 11:39 ` Mark Rutland
2018-11-01 13:42 ` Andy Shevchenko
2018-11-01 15:09 ` [PATCH V5 5/8] misc/pvpanic: simplify the code using acpi_dev_resource_io Peng Hao
2018-11-01 13:44 ` Andy Shevchenko
2018-11-01 15:10 ` [PATCH V5 6/8] misc/pvpanic: add MMIO support Peng Hao
2018-11-01 11:42 ` Mark Rutland
2018-11-01 17:04 ` Andy Shevchenko [this message]
2018-11-01 15:10 ` [PATCH V5 7/8] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-11-01 11:47 ` Mark Rutland
2018-11-01 15:10 ` [PATCH V5 8/8] dt-bindings/misc/pvpanic :add document for pvpanic-mmio Peng Hao
2018-11-01 11:46 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfNDKgenuc0ApMODfCw6h9azwBDskPuV2S4E8nLFsuTxw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.hao2@zte.com.cn \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).