From: John Ogness <john.ogness@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrea Parri <andrea.parri@amarulasolutions.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>
Subject: [RFC PATCH v4 7/9] printk-rb: increase size of seq and size variables
Date: Thu, 8 Aug 2019 00:32:32 +0206 [thread overview]
Message-ID: <20190807222634.1723-8-john.ogness@linutronix.de> (raw)
In-Reply-To: <20190807222634.1723-1-john.ogness@linutronix.de>
The printk implementation will rely on sequence numbers never
wrapping. For 32-bit systems, an unsigned long for sequence
numbers is not acceptable. Change the sequence number to u64.
Size variables are currently unsigned int, which may not be
acceptable for 64-bit systems. Change size variables to
unsigned long. (32-bit sizes on 32-bit systems should be fine.)
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
kernel/printk/dataring.c | 8 ++++----
kernel/printk/dataring.h | 4 ++--
kernel/printk/numlist.c | 6 +++---
kernel/printk/numlist.h | 6 +++---
kernel/printk/ringbuffer.c | 6 +++---
kernel/printk/ringbuffer.h | 10 +++++-----
kernel/printk/test_prb.c | 14 +++++++-------
7 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/kernel/printk/dataring.c b/kernel/printk/dataring.c
index 345c46dba5bb..712842f2dc04 100644
--- a/kernel/printk/dataring.c
+++ b/kernel/printk/dataring.c
@@ -152,7 +152,7 @@ static struct dr_datablock *to_datablock(struct dataring *dr,
* than or equal to the size of @dr_datablock.id. This ensures that there is
* always space in the data array for the @id of a "wrapping" data block.
*/
-static void to_db_size(unsigned int *size)
+static void to_db_size(unsigned long *size)
{
*size += sizeof(struct dr_datablock);
/* Alignment padding must be >= sizeof(dr_datablock.id). */
@@ -238,7 +238,7 @@ bool dataring_datablock_isvalid(struct dataring *dr, struct dr_desc *desc)
*
* Return: true if the size is legal for the data ringbuffer, otherwise false.
*/
-bool dataring_checksize(struct dataring *dr, unsigned int size)
+bool dataring_checksize(struct dataring *dr, unsigned long size)
{
if (size == 0)
return false;
@@ -445,7 +445,7 @@ static unsigned long _dataring_pop(struct dataring *dr,
* This will only fail if it was not possible to invalidate the tail data
* block (i.e. the @id of the tail data block was not yet set by its writer).
*/
-static bool get_new_lpos(struct dataring *dr, unsigned int size,
+static bool get_new_lpos(struct dataring *dr, unsigned long size,
unsigned long *begin_lpos_out,
unsigned long *next_lpos_out)
{
@@ -537,7 +537,7 @@ void dataring_desc_init(struct dr_desc *desc)
* This will only fail if it was not possible to invalidate the tail data
* block.
*/
-char *dataring_push(struct dataring *dr, unsigned int size,
+char *dataring_push(struct dataring *dr, unsigned long size,
struct dr_desc *desc, unsigned long id)
{
unsigned long begin_lpos;
diff --git a/kernel/printk/dataring.h b/kernel/printk/dataring.h
index 413ee95f4dd6..c566ce228abe 100644
--- a/kernel/printk/dataring.h
+++ b/kernel/printk/dataring.h
@@ -90,10 +90,10 @@ struct dataring {
void *getdesc_arg;
};
-bool dataring_checksize(struct dataring *dr, unsigned int size);
+bool dataring_checksize(struct dataring *dr, unsigned long size);
bool dataring_pop(struct dataring *dr);
-char *dataring_push(struct dataring *dr, unsigned int size,
+char *dataring_push(struct dataring *dr, unsigned long size,
struct dr_desc *desc, unsigned long id);
void dataring_datablock_setid(struct dataring *dr, struct dr_desc *desc,
diff --git a/kernel/printk/numlist.c b/kernel/printk/numlist.c
index d5e224dafc0c..16c6ffa74b01 100644
--- a/kernel/printk/numlist.c
+++ b/kernel/printk/numlist.c
@@ -108,7 +108,7 @@
*
* This function will fail if @id is not valid anytime during this function.
*/
-bool numlist_read(struct numlist *nl, unsigned long id, unsigned long *seq,
+bool numlist_read(struct numlist *nl, unsigned long id, u64 *seq,
unsigned long *next_id)
{
struct nl_node *n;
@@ -165,7 +165,7 @@ bool numlist_read(struct numlist *nl, unsigned long id, unsigned long *seq,
*
* Return: The ID of the tail node.
*/
-unsigned long numlist_read_tail(struct numlist *nl, unsigned long *seq,
+unsigned long numlist_read_tail(struct numlist *nl, u64 *seq,
unsigned long *next_id)
{
unsigned long tail_id;
@@ -201,8 +201,8 @@ unsigned long numlist_read_tail(struct numlist *nl, unsigned long *seq,
void numlist_push(struct numlist *nl, struct nl_node *n, unsigned long id)
{
unsigned long head_id;
- unsigned long seq;
unsigned long r;
+ u64 seq;
/*
* bA:
diff --git a/kernel/printk/numlist.h b/kernel/printk/numlist.h
index cdc3b21e6597..d4595fb9a3e9 100644
--- a/kernel/printk/numlist.h
+++ b/kernel/printk/numlist.h
@@ -20,7 +20,7 @@
*/
struct nl_node {
/* private */
- unsigned long seq;
+ u64 seq;
unsigned long next_id;
};
@@ -64,9 +64,9 @@ struct numlist {
void numlist_push(struct numlist *nl, struct nl_node *n, unsigned long id);
struct nl_node *numlist_pop(struct numlist *nl);
-unsigned long numlist_read_tail(struct numlist *nl, unsigned long *seq,
+unsigned long numlist_read_tail(struct numlist *nl, u64 *seq,
unsigned long *next_id);
-bool numlist_read(struct numlist *nl, unsigned long id, unsigned long *seq,
+bool numlist_read(struct numlist *nl, unsigned long id, u64 *seq,
unsigned long *next_id);
#endif /* _KERNEL_PRINTK_NUMLIST_H */
diff --git a/kernel/printk/ringbuffer.c b/kernel/printk/ringbuffer.c
index 9be841761ea2..053622151447 100644
--- a/kernel/printk/ringbuffer.c
+++ b/kernel/printk/ringbuffer.c
@@ -416,7 +416,7 @@ static bool assign_desc(struct prb_reserved_entry *e)
* * -ENOMEM: failed to reserve data (invalid descriptor committed)
*/
char *prb_reserve(struct prb_reserved_entry *e, struct printk_ringbuffer *rb,
- unsigned int size)
+ unsigned long size)
{
struct prb_desc *d;
unsigned long id;
@@ -567,7 +567,7 @@ EXPORT_SYMBOL(prb_iter_init);
*/
static void reset_iter(struct prb_iterator *iter)
{
- unsigned long last_seq;
+ u64 last_seq;
iter->next_id = numlist_read_tail(&iter->rb->nl, &last_seq, NULL);
@@ -650,9 +650,9 @@ int prb_iter_next_valid_entry(struct prb_iterator *iter)
struct dr_desc desc;
struct prb_desc *d;
struct nl_node *n;
- unsigned long seq;
unsigned long id;
int size;
+ u64 seq;
if (!setup_next(nl, iter))
return 0;
diff --git a/kernel/printk/ringbuffer.h b/kernel/printk/ringbuffer.h
index 698d2328ea9e..ec7bb21abac2 100644
--- a/kernel/printk/ringbuffer.h
+++ b/kernel/printk/ringbuffer.h
@@ -97,9 +97,9 @@ struct prb_reserved_entry {
*/
struct prb_entry {
/* public */
- unsigned long seq;
- char *buffer;
- int buffer_size;
+ u64 seq;
+ char *buffer;
+ int buffer_size;
};
/**
@@ -125,13 +125,13 @@ struct prb_iterator {
struct prb_entry *e;
unsigned long last_id;
- unsigned long last_seq;
+ u64 last_seq;
unsigned long next_id;
};
/* writer interface */
char *prb_reserve(struct prb_reserved_entry *e, struct printk_ringbuffer *rb,
- unsigned int size);
+ unsigned long size);
void prb_commit(struct prb_reserved_entry *e);
/* reader interface */
diff --git a/kernel/printk/test_prb.c b/kernel/printk/test_prb.c
index 77d298b6990a..0157bbdf051f 100644
--- a/kernel/printk/test_prb.c
+++ b/kernel/printk/test_prb.c
@@ -38,8 +38,8 @@ static void dump_rb(struct printk_ringbuffer *rb)
{
DECLARE_PRINTKRB_ENTRY(entry, 160);
DECLARE_PRINTKRB_ITER(iter, rb, &entry);
- unsigned long last_seq = 0;
struct rbdata *dat;
+ u64 last_seq = 0;
char buf[160];
int len;
@@ -47,7 +47,7 @@ static void dump_rb(struct printk_ringbuffer *rb)
prb_for_each_entry_continue(&iter, len) {
if (entry.seq - last_seq != 1) {
- trace_printk("LOST %lu\n",
+ trace_printk("LOST %llu\n",
entry.seq - (last_seq + 1));
}
last_seq = entry.seq;
@@ -56,7 +56,7 @@ static void dump_rb(struct printk_ringbuffer *rb)
snprintf(buf, sizeof(buf), "%s", dat->text);
buf[sizeof(buf) - 1] = 0;
- trace_printk("seq=%lu len=%d textlen=%d dataval=%s\n",
+ trace_printk("seq=%llu len=%d textlen=%d dataval=%s\n",
entry.seq, len, dat->len, buf);
}
@@ -112,11 +112,11 @@ static int prbtest_reader(void *data)
DECLARE_PRINTKRB_ENTRY(entry, 160);
DECLARE_PRINTKRB_ITER(iter, &test_rb, &entry);
unsigned long total_lost = 0;
- unsigned long last_seq = 0;
unsigned long max_lost = 0;
unsigned long count = 0;
struct rbdata *dat;
int did_sched = 1;
+ u64 last_seq = 0;
int len;
pr_err("prbtest: start thread %lu (reader)\n", num);
@@ -126,7 +126,7 @@ static int prbtest_reader(void *data)
if (entry.seq < last_seq) {
WRITE_ONCE(halt_test, 1);
trace_printk(
- "reader%lu invalid seq %lu -> %lu\n",
+ "reader%lu invalid seq %llu -> %llu\n",
num, last_seq, entry.seq);
goto out;
}
@@ -145,7 +145,7 @@ static int prbtest_reader(void *data)
if (len != dat->len || len >= 160) {
WRITE_ONCE(halt_test, 1);
trace_printk(
- "reader%lu invalid len for %lu (%d<->%d)\n",
+ "reader%lu invalid len for %llu (%d<->%d)\n",
num, entry.seq, len, dat->len);
goto out;
}
@@ -172,7 +172,7 @@ static int prbtest_reader(void *data)
}
out:
pr_err(
- "reader%lu: total_lost=%lu max_lost=%lu total_read=%lu seq=%lu\n",
+ "reader%lu: total_lost=%lu max_lost=%lu total_read=%lu seq=%llu\n",
num, total_lost, max_lost, count, entry.seq);
pr_err("prbtest: end thread %lu (reader)\n", num);
--
2.20.1
next prev parent reply other threads:[~2019-08-07 22:27 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 22:26 [RFC PATCH v4 0/9] printk: new ringbuffer implementation John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 1/9] printk-rb: add a new printk " John Ogness
2019-08-20 8:15 ` numlist_pop(): " Petr Mladek
2019-08-21 5:41 ` John Ogness
2019-09-04 12:19 ` Peter Zijlstra
2019-08-20 8:22 ` assign_desc() barriers: " Petr Mladek
2019-08-20 14:14 ` Petr Mladek
2019-08-21 5:52 ` John Ogness
2019-08-22 11:53 ` Petr Mladek
2019-08-25 2:06 ` John Ogness
2019-08-26 8:21 ` John Ogness
2019-08-20 8:55 ` comments style: " Petr Mladek
2019-08-20 9:27 ` Sergey Senozhatsky
2019-08-21 5:46 ` John Ogness
2019-08-22 13:50 ` Petr Mladek
2019-08-22 17:38 ` Andrea Parri
2019-08-23 10:47 ` Petr Mladek
2019-08-23 14:27 ` Andrea Parri
2019-08-23 9:49 ` Sergey Senozhatsky
2019-08-23 5:54 ` Sergey Senozhatsky
2019-08-23 10:29 ` Petr Mladek
2019-08-21 5:42 ` John Ogness
2019-08-22 12:44 ` Petr Mladek
2019-08-20 13:50 ` dataring_push() barriers " Petr Mladek
2019-08-25 2:42 ` John Ogness
2019-08-27 14:36 ` Petr Mladek
2019-08-28 13:43 ` John Ogness
2019-08-20 15:12 ` datablock reuse races " Petr Mladek
2019-08-23 9:21 ` numlist_push() barriers " Petr Mladek
2019-08-26 8:34 ` Andrea Parri
2019-08-26 8:43 ` Andrea Parri
2019-08-26 14:10 ` Petr Mladek
2019-08-26 16:01 ` Andrea Parri
2019-08-26 22:36 ` John Ogness
2019-08-27 7:40 ` Petr Mladek
2019-08-27 14:28 ` John Ogness
2019-08-27 15:07 ` Petr Mladek
2019-08-28 10:24 ` John Ogness
2019-08-23 17:18 ` numlist API " Petr Mladek
2019-08-26 23:57 ` John Ogness
2019-08-27 13:03 ` Petr Mladek
2019-08-28 7:13 ` John Ogness
2019-08-28 8:58 ` Petr Mladek
2019-08-28 14:03 ` John Ogness
2019-08-29 11:28 ` Petr Mladek
2019-09-03 7:58 ` Sergey Senozhatsky
2019-08-30 14:48 ` dataring " Petr Mladek
2019-08-07 22:26 ` [RFC PATCH v4 2/9] printk-rb: add test module John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 3/9] printk-rb: fix missing includes/exports John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 4/9] printk-rb: initialize new descriptors as invalid John Ogness
2019-08-20 9:23 ` Petr Mladek
2019-08-20 10:16 ` Sergey Senozhatsky
2019-08-21 5:56 ` John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 5/9] printk-rb: remove extra data buffer size allocation John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 6/9] printk-rb: adjust test module ringbuffer sizes John Ogness
2019-08-19 21:29 ` [PATCH] printk-rb: fix test module macro usage John Ogness
2019-08-07 22:26 ` John Ogness [this message]
2019-08-07 22:26 ` [RFC PATCH v4 8/9] printk-rb: new functionality to support printk John Ogness
2019-08-20 9:59 ` Sergey Senozhatsky
2019-08-21 5:47 ` John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 9/9] printk: use a new ringbuffer implementation John Ogness
2019-08-08 19:07 ` Linus Torvalds
2019-08-08 22:55 ` John Ogness
2019-08-08 23:33 ` Linus Torvalds
2019-08-08 23:45 ` Steven Rostedt
2019-08-09 0:21 ` Linus Torvalds
2019-08-09 0:48 ` Steven Rostedt
2019-08-09 1:15 ` Linus Torvalds
2019-08-09 11:15 ` Thomas Gleixner
2019-08-09 16:00 ` Linus Torvalds
2019-08-09 20:07 ` Thomas Gleixner
2019-08-09 20:20 ` Linus Torvalds
2019-08-09 6:14 ` Peter Zijlstra
2019-08-09 7:08 ` John Ogness
2019-08-09 15:57 ` Linus Torvalds
2019-08-10 5:53 ` Thomas Gleixner
2019-09-10 3:19 ` Sergey Senozhatsky
2019-08-12 9:54 ` Geert Uytterhoeven
2019-08-16 5:46 ` Dave Young
2019-08-16 5:54 ` Dave Young
2019-08-16 9:40 ` John Ogness
2019-09-04 12:35 ` [RFC PATCH v4 0/9] printk: " Peter Zijlstra
2019-09-05 13:05 ` Petr Mladek
2019-09-05 14:31 ` Peter Zijlstra
2019-09-05 15:38 ` Thomas Gleixner
2019-09-05 16:11 ` Steven Rostedt
2019-09-05 21:10 ` John Ogness
2019-09-06 9:39 ` Petr Mladek
2019-09-09 14:11 ` printk meeting at LPC Thomas Gleixner
2019-09-13 13:26 ` John Ogness
2019-09-13 14:48 ` Daniel Vetter
2019-09-15 13:47 ` John Ogness
2019-09-16 8:44 ` Daniel Vetter
2019-09-16 4:30 ` Tetsuo Handa
2019-09-16 10:46 ` Petr Mladek
2019-09-16 13:43 ` Steven Rostedt
2019-09-16 14:28 ` John Ogness
2019-09-17 8:11 ` Petr Mladek
2019-09-17 7:52 ` Petr Mladek
2019-09-17 13:02 ` Steven Rostedt
2019-09-17 13:12 ` Greg Kroah-Hartman
2019-09-17 13:37 ` Steven Rostedt
2019-09-17 14:08 ` Tetsuo Handa
2019-09-17 7:51 ` Sergey Senozhatsky
2019-09-18 1:25 ` Sergey Senozhatsky
2019-09-18 2:08 ` Steven Rostedt
2019-09-18 2:36 ` Sergey Senozhatsky
2019-09-18 5:19 ` Sergey Senozhatsky
2019-09-18 7:42 ` John Ogness
2019-09-18 8:10 ` Sergey Senozhatsky
2019-09-18 9:05 ` John Ogness
2019-09-18 9:11 ` Sergey Senozhatsky
2019-09-18 16:41 ` Petr Mladek
2019-09-18 16:48 ` Steven Rostedt
2019-09-24 14:24 ` Petr Mladek
2019-09-19 8:06 ` Daniel Vetter
2019-09-18 7:33 ` John Ogness
2019-09-18 8:08 ` Sergey Senozhatsky
2019-10-04 14:48 ` Tony Asleson
2019-10-07 12:01 ` Petr Mladek
2019-09-06 9:06 ` [RFC PATCH v4 0/9] printk: new ringbuffer implementation Peter Zijlstra
2019-09-06 10:09 ` Sergey Senozhatsky
2019-09-06 10:49 ` Peter Zijlstra
2019-09-06 13:44 ` Sergey Senozhatsky
2019-09-06 12:42 ` Petr Mladek
2019-09-06 14:01 ` Peter Zijlstra
2019-09-06 14:22 ` Peter Zijlstra
2019-09-06 19:53 ` Sergey Senozhatsky
2019-09-06 22:47 ` John Ogness
2019-09-08 22:18 ` Peter Zijlstra
2019-09-10 3:22 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807222634.1723-8-john.ogness@linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andrea.parri@amarulasolutions.com \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).