From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: John Ogness <john.ogness@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
Andrea Parri <parri.andrea@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>, Paul Turner <pjt@google.com>,
Prarit Bhargava <prarit@redhat.com>
Subject: Re: printk meeting at LPC
Date: Mon, 16 Sep 2019 10:44:07 +0200 [thread overview]
Message-ID: <CAKMK7uH-3PqezSBTX3Xh40xyZ0o9NQFBA5gnPq70HHBGLGp8-A@mail.gmail.com> (raw)
In-Reply-To: <87d0g18ydt.fsf@linutronix.de>
On Sun, Sep 15, 2019 at 3:48 PM John Ogness <john.ogness@linutronix.de> wrote:
>
> On 2019-09-13, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >> 2. A kernel thread will be created for each registered console, each
> >> responsible for being the sole printers to their respective
> >> consoles. With this, console printing is _fully_ decoupled from
> >> printk() callers.
> >
> > Is the plan to split the console_lock up into a per-console thing? Or
> > postponed for later on?
>
> AFAICT, the only purpose for a console_lock would be to synchronize
> between the console printing kthread and some other component that wants
> to write to that same device. So a per-console console_lock should be
> the proper solution. However, I will look into the details. My main
> concerns about this are the suspend/resume logic and the code sitting
> behind /dev/console. I will share details once I've sorted it all out.
>
> >> 6. A new may-sleep function pr_flush() will be made available to wait
> >> for all previously printk'd messages to be output on all consoles
> >> before proceeding. For example:
> >>
> >> pr_cont("Running test ABC... ");
> >> pr_flush();
> >>
> >> do_test();
> >>
> >> pr_cont("PASSED\n");
> >> pr_flush();
> >
> > Just crossed my mind: Could/should we lockdep-annotate pr_flush (take
> > a lockdep map in there that we also take around the calls down into
> > console drivers in each of the console printing kthreads or something
> > like that)? Just to avoid too many surprises when people call pr_flush
> > from within gpu drivers and wonder why it doesn't work so well.
>
> Why would it not work so well? Basically the task calling pr_flush()
> will monitor the lockless iterators of the various consoles until _all_
> have hit/passed the latest sequence number from the time of the call.
Classic deadlock like the below: Some thread:
mutex_lock(A);
pr_flush();
mutex_unlock(A);
And in the normal console write code also needs do to mutex_lock(A);
mutex_unlock(A); somewhere.
> > Although with this nice plan we'll take the modeset paths fully out of
> > the printk paths (even for normal outputs) I hope, so should be a lot
> > more reasonable.
>
> You will be running in your own preemptible kthread, so any paths you
> take should be safe.
>
> > From gpu perspective this all sounds extremely good and first
> > realistic plan that might lead us to an actually working bsod on
> > linux.
>
> Are you planning on basing the bsod stuff on write_atomic() (which is
> used after entering an emergency state) or on the kmsg_dump facility? I
> would expect kmsg_dump might be more appropriate, unless there are
> concerns that the machine will die before getting that far (i.e. there
> is a lot that happens between when an OOPS begins and when kmsg_dumpers
> are invoked).
Yeah I think kms_dump is what the current patches use. From the fbcon
pov the important bit here is the clearly split out write_atomic, so
that we can make sure we never try to do anything stupid from special
contexts. Aside from the printing itself we also have all kinds of fun
stuff like unblank_screen() and console_unblank() currently in the
panic path still.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2019-09-16 8:44 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 22:26 [RFC PATCH v4 0/9] printk: new ringbuffer implementation John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 1/9] printk-rb: add a new printk " John Ogness
2019-08-20 8:15 ` numlist_pop(): " Petr Mladek
2019-08-21 5:41 ` John Ogness
2019-09-04 12:19 ` Peter Zijlstra
2019-08-20 8:22 ` assign_desc() barriers: " Petr Mladek
2019-08-20 14:14 ` Petr Mladek
2019-08-21 5:52 ` John Ogness
2019-08-22 11:53 ` Petr Mladek
2019-08-25 2:06 ` John Ogness
2019-08-26 8:21 ` John Ogness
2019-08-20 8:55 ` comments style: " Petr Mladek
2019-08-20 9:27 ` Sergey Senozhatsky
2019-08-21 5:46 ` John Ogness
2019-08-22 13:50 ` Petr Mladek
2019-08-22 17:38 ` Andrea Parri
2019-08-23 10:47 ` Petr Mladek
2019-08-23 14:27 ` Andrea Parri
2019-08-23 9:49 ` Sergey Senozhatsky
2019-08-23 5:54 ` Sergey Senozhatsky
2019-08-23 10:29 ` Petr Mladek
2019-08-21 5:42 ` John Ogness
2019-08-22 12:44 ` Petr Mladek
2019-08-20 13:50 ` dataring_push() barriers " Petr Mladek
2019-08-25 2:42 ` John Ogness
2019-08-27 14:36 ` Petr Mladek
2019-08-28 13:43 ` John Ogness
2019-08-20 15:12 ` datablock reuse races " Petr Mladek
2019-08-23 9:21 ` numlist_push() barriers " Petr Mladek
2019-08-26 8:34 ` Andrea Parri
2019-08-26 8:43 ` Andrea Parri
2019-08-26 14:10 ` Petr Mladek
2019-08-26 16:01 ` Andrea Parri
2019-08-26 22:36 ` John Ogness
2019-08-27 7:40 ` Petr Mladek
2019-08-27 14:28 ` John Ogness
2019-08-27 15:07 ` Petr Mladek
2019-08-28 10:24 ` John Ogness
2019-08-23 17:18 ` numlist API " Petr Mladek
2019-08-26 23:57 ` John Ogness
2019-08-27 13:03 ` Petr Mladek
2019-08-28 7:13 ` John Ogness
2019-08-28 8:58 ` Petr Mladek
2019-08-28 14:03 ` John Ogness
2019-08-29 11:28 ` Petr Mladek
2019-09-03 7:58 ` Sergey Senozhatsky
2019-08-30 14:48 ` dataring " Petr Mladek
2019-08-07 22:26 ` [RFC PATCH v4 2/9] printk-rb: add test module John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 3/9] printk-rb: fix missing includes/exports John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 4/9] printk-rb: initialize new descriptors as invalid John Ogness
2019-08-20 9:23 ` Petr Mladek
2019-08-20 10:16 ` Sergey Senozhatsky
2019-08-21 5:56 ` John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 5/9] printk-rb: remove extra data buffer size allocation John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 6/9] printk-rb: adjust test module ringbuffer sizes John Ogness
2019-08-19 21:29 ` [PATCH] printk-rb: fix test module macro usage John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 7/9] printk-rb: increase size of seq and size variables John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 8/9] printk-rb: new functionality to support printk John Ogness
2019-08-20 9:59 ` Sergey Senozhatsky
2019-08-21 5:47 ` John Ogness
2019-08-07 22:26 ` [RFC PATCH v4 9/9] printk: use a new ringbuffer implementation John Ogness
2019-08-08 19:07 ` Linus Torvalds
2019-08-08 22:55 ` John Ogness
2019-08-08 23:33 ` Linus Torvalds
2019-08-08 23:45 ` Steven Rostedt
2019-08-09 0:21 ` Linus Torvalds
2019-08-09 0:48 ` Steven Rostedt
2019-08-09 1:15 ` Linus Torvalds
2019-08-09 11:15 ` Thomas Gleixner
2019-08-09 16:00 ` Linus Torvalds
2019-08-09 20:07 ` Thomas Gleixner
2019-08-09 20:20 ` Linus Torvalds
2019-08-09 6:14 ` Peter Zijlstra
2019-08-09 7:08 ` John Ogness
2019-08-09 15:57 ` Linus Torvalds
2019-08-10 5:53 ` Thomas Gleixner
2019-09-10 3:19 ` Sergey Senozhatsky
2019-08-12 9:54 ` Geert Uytterhoeven
2019-08-16 5:46 ` Dave Young
2019-08-16 5:54 ` Dave Young
2019-08-16 9:40 ` John Ogness
2019-09-04 12:35 ` [RFC PATCH v4 0/9] printk: " Peter Zijlstra
2019-09-05 13:05 ` Petr Mladek
2019-09-05 14:31 ` Peter Zijlstra
2019-09-05 15:38 ` Thomas Gleixner
2019-09-05 16:11 ` Steven Rostedt
2019-09-05 21:10 ` John Ogness
2019-09-06 9:39 ` Petr Mladek
2019-09-09 14:11 ` printk meeting at LPC Thomas Gleixner
2019-09-13 13:26 ` John Ogness
2019-09-13 14:48 ` Daniel Vetter
2019-09-15 13:47 ` John Ogness
2019-09-16 8:44 ` Daniel Vetter [this message]
2019-09-16 4:30 ` Tetsuo Handa
2019-09-16 10:46 ` Petr Mladek
2019-09-16 13:43 ` Steven Rostedt
2019-09-16 14:28 ` John Ogness
2019-09-17 8:11 ` Petr Mladek
2019-09-17 7:52 ` Petr Mladek
2019-09-17 13:02 ` Steven Rostedt
2019-09-17 13:12 ` Greg Kroah-Hartman
2019-09-17 13:37 ` Steven Rostedt
2019-09-17 14:08 ` Tetsuo Handa
2019-09-17 7:51 ` Sergey Senozhatsky
2019-09-18 1:25 ` Sergey Senozhatsky
2019-09-18 2:08 ` Steven Rostedt
2019-09-18 2:36 ` Sergey Senozhatsky
2019-09-18 5:19 ` Sergey Senozhatsky
2019-09-18 7:42 ` John Ogness
2019-09-18 8:10 ` Sergey Senozhatsky
2019-09-18 9:05 ` John Ogness
2019-09-18 9:11 ` Sergey Senozhatsky
2019-09-18 16:41 ` Petr Mladek
2019-09-18 16:48 ` Steven Rostedt
2019-09-24 14:24 ` Petr Mladek
2019-09-19 8:06 ` Daniel Vetter
2019-09-18 7:33 ` John Ogness
2019-09-18 8:08 ` Sergey Senozhatsky
2019-10-04 14:48 ` Tony Asleson
2019-10-07 12:01 ` Petr Mladek
2019-09-06 9:06 ` [RFC PATCH v4 0/9] printk: new ringbuffer implementation Peter Zijlstra
2019-09-06 10:09 ` Sergey Senozhatsky
2019-09-06 10:49 ` Peter Zijlstra
2019-09-06 13:44 ` Sergey Senozhatsky
2019-09-06 12:42 ` Petr Mladek
2019-09-06 14:01 ` Peter Zijlstra
2019-09-06 14:22 ` Peter Zijlstra
2019-09-06 19:53 ` Sergey Senozhatsky
2019-09-06 22:47 ` John Ogness
2019-09-08 22:18 ` Peter Zijlstra
2019-09-10 3:22 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uH-3PqezSBTX3Xh40xyZ0o9NQFBA5gnPq70HHBGLGp8-A@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).