From: Steven Rostedt <rostedt@goodmis.org>
To: zzyiwei@google.com
Cc: mingo@redhat.com, gregkh@linuxfoundation.org, elder@kernel.org,
federico.vaga@cern.ch, tony.luck@intel.com,
vilhelm.gray@gmail.com, linus.walleij@linaro.org,
tglx@linutronix.de, yamada.masahiro@socionext.com,
paul.walmsley@sifive.com, linux-kernel@vger.kernel.org,
prahladk@google.com, joelaf@google.com,
android-kernel@google.com
Subject: Re: [PATCH v2] Add gpu memory tracepoints
Date: Wed, 12 Feb 2020 20:48:48 -0500 [thread overview]
Message-ID: <20200212204848.6fe34240@oasis.local.home> (raw)
In-Reply-To: <20200213003259.128938-1-zzyiwei@google.com>
On Wed, 12 Feb 2020 16:32:59 -0800
zzyiwei@google.com wrote:
> +#undef TRACE_SYSTEM
> +#define TRACE_SYSTEM gpu_mem
> +
> +#if !defined(_TRACE_GPU_MEM_H) || defined(TRACE_HEADER_MULTI_READ)
> +#define _TRACE_GPU_MEM_H
> +
> +#include <linux/tracepoint.h>
> +
> +/*
> + * The gpu_memory_total event indicates that there's an update to either the
> + * global or process total gpu memory counters.
> + *
> + * This event should be emitted whenever the kernel device driver allocates,
> + * frees, imports, unimports memory in the GPU addressable space.
> + *
> + * @gpu_id: This is the gpu id.
> + *
> + * @pid: Put 0 for global total, while positive pid for process total.
> + *
> + * @size: Virtual size of the allocation in bytes.
> + *
> + */
> +TRACE_EVENT(gpu_mem_total,
> + TP_PROTO(
> + uint32_t gpu_id,
> + uint32_t pid,
> + uint64_t size
> + ),
> + TP_ARGS(
> + gpu_id,
> + pid,
> + size
> + ),
This is unique whitespace parsing. Usually, this would be:
TP_PROTO(uint32_t gpu_id, unint32_t pid, uint64_t size),
TP_ARGS(gpu_id, pid, size),
> + TP_STRUCT__entry(
> + __field(uint32_t, gpu_id)
> + __field(uint32_t, pid)
> + __field(uint64_t, size)
> + ),
> + TP_fast_assign(
> + __entry->gpu_id = gpu_id;
> + __entry->pid = pid;
> + __entry->size = size;
> + ),
> + TP_printk(
> + "gpu_id=%u "
> + "pid=%u "
> + "size=%llu",
Breaking up a string is frowned upon.
TP_print("gpu_id=%u pid=$u size=%llu",
__entry->gpu_id,
__entry->pid,
__entry->size)
-- Steve
> + __entry->gpu_id,
> + __entry->pid,
> + __entry->size
> + )
> +);
> +
> +#endif /* _TRACE_GPU_MEM_H */
> +
> +/* This part must be outside protection */
> +#include <trace/define_trace.h>
next prev parent reply other threads:[~2020-02-13 1:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 0:32 [PATCH v2] Add gpu memory tracepoints zzyiwei
2020-02-13 0:39 ` Yiwei Zhang
2020-02-13 0:40 ` Greg KH
2020-02-13 1:23 ` Yiwei Zhang
2020-02-13 1:48 ` Steven Rostedt [this message]
2020-02-13 2:20 ` zzyiwei
2020-02-13 2:24 ` Yiwei Zhang
2020-02-13 3:29 ` Steven Rostedt
2020-02-13 4:23 ` [PATCH v3] gpu/trace: add " zzyiwei
2020-02-13 4:27 ` Yiwei Zhang
2020-02-13 14:03 ` Steven Rostedt
2020-02-13 17:49 ` Yiwei Zhang
2020-02-24 6:31 ` Yiwei Zhang
2020-02-24 16:38 ` Steven Rostedt
2020-03-01 0:53 ` Yiwei Zhang
2020-03-02 23:48 ` [PATCH] [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint zzyiwei
2020-03-02 23:56 ` Yiwei Zhang
2020-03-02 23:50 ` zzyiwei
2020-03-03 14:07 ` Steven Rostedt
2020-03-03 14:15 ` Greg KH
2020-03-03 14:31 ` Steven Rostedt
2020-03-03 15:15 ` Yiwei Zhang
2020-03-03 15:48 ` Steven Rostedt
2020-03-03 15:56 ` Greg KH
2020-03-13 22:59 ` Yiwei Zhang
2020-03-16 18:05 ` Steven Rostedt
2020-03-16 19:28 ` Yiwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212204848.6fe34240@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=android-kernel@google.com \
--cc=elder@kernel.org \
--cc=federico.vaga@cern.ch \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.walmsley@sifive.com \
--cc=prahladk@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
--cc=zzyiwei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).