linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yiwei Zhang <zzyiwei@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	mingo@redhat.com, elder@kernel.org, federico.vaga@cern.ch,
	tony.luck@intel.com, vilhelm.gray@gmail.com,
	linus.walleij@linaro.org, tglx@linutronix.de,
	yamada.masahiro@socionext.com, paul.walmsley@sifive.com,
	linux-kernel@vger.kernel.org,
	Prahlad Kilambi <prahladk@google.com>,
	Joel Fernandes <joelaf@google.com>,
	android-kernel <android-kernel@google.com>
Subject: Re: [PATCH v2] Add gpu memory tracepoints
Date: Wed, 12 Feb 2020 17:23:27 -0800	[thread overview]
Message-ID: <CAKT=dDmo8Ui6cVdi2Rsk6PUtCeUku_07ngZ7d2xyDU1dBdHhag@mail.gmail.com> (raw)
In-Reply-To: <20200213004029.GA2500609@kroah.com>

Hi Greg,

Thanks for your prompt response!

For upstream drm gem based gfx drivers, the lower level device driver
layer is able to implement such per-process gpu memory total counters
but the common drm gem layer is probably not. At least the global
total gpu memory counter is fairly easy to implement, and then this
tracepoint can still be useful right away.

For Android, the debugfs has already been forced to be deprecated in
the coming Android 11 release. We have asked Android GPU vendors to
implement such global and per-process total memory counters. So they
can easily use this tracepoint inside the driver. This is mainly to
serve the profiling needs as well as the runtime query needs(by
attaching a eBPF program from userspace), and this patch helps
standardize the tracepoint in the kernel.

Many thanks!
Yiwei


On Wed, Feb 12, 2020 at 4:40 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Feb 12, 2020 at 04:32:59PM -0800, zzyiwei@google.com wrote:
> > From: Yiwei Zhang <zzyiwei@google.com>
> >
> > This change adds the below gpu memory tracepoint:
> > gpu_mem/gpu_mem_total: track global or process gpu memory total counters
> >
> > Signed-off-by: Yiwei Zhang <zzyiwei@google.com>
>
> If this helps gpu drivers wean themselves off of debugfs, I am all for
> it:
>         Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks for doing this.
>
> greg k-h

  reply	other threads:[~2020-02-13  1:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  0:32 [PATCH v2] Add gpu memory tracepoints zzyiwei
2020-02-13  0:39 ` Yiwei Zhang
2020-02-13  0:40 ` Greg KH
2020-02-13  1:23   ` Yiwei Zhang [this message]
2020-02-13  1:48 ` Steven Rostedt
2020-02-13  2:20 ` zzyiwei
2020-02-13  2:24   ` Yiwei Zhang
2020-02-13  3:29     ` Steven Rostedt
2020-02-13  4:23       ` [PATCH v3] gpu/trace: add " zzyiwei
2020-02-13  4:27         ` Yiwei Zhang
2020-02-13 14:03         ` Steven Rostedt
2020-02-13 17:49           ` Yiwei Zhang
2020-02-24  6:31             ` Yiwei Zhang
2020-02-24 16:38               ` Steven Rostedt
2020-03-01  0:53                 ` Yiwei Zhang
2020-03-02 23:48                   ` [PATCH] [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint zzyiwei
2020-03-02 23:56                     ` Yiwei Zhang
2020-03-02 23:50                   ` zzyiwei
2020-03-03 14:07                     ` Steven Rostedt
2020-03-03 14:15                       ` Greg KH
2020-03-03 14:31                         ` Steven Rostedt
2020-03-03 15:15                           ` Yiwei Zhang
2020-03-03 15:48                             ` Steven Rostedt
2020-03-03 15:56                           ` Greg KH
2020-03-13 22:59                             ` Yiwei Zhang
2020-03-16 18:05                               ` Steven Rostedt
2020-03-16 19:28                                 ` Yiwei Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKT=dDmo8Ui6cVdi2Rsk6PUtCeUku_07ngZ7d2xyDU1dBdHhag@mail.gmail.com' \
    --to=zzyiwei@google.com \
    --cc=android-kernel@google.com \
    --cc=elder@kernel.org \
    --cc=federico.vaga@cern.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=joelaf@google.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.walmsley@sifive.com \
    --cc=prahladk@google.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vilhelm.gray@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).