From: Yiwei Zhang <zzyiwei@google.com>
To: Steven Rostedt <rostedt@goodmis.org>,
mingo@redhat.com, Greg KH <gregkh@linuxfoundation.org>,
elder@kernel.org, federico.vaga@cern.ch, tony.luck@intel.com,
vilhelm.gray@gmail.com, Linus Walleij <linus.walleij@linaro.org>,
tglx@linutronix.de, yamada.masahiro@socionext.com,
paul.walmsley@sifive.com
Cc: linux-kernel@vger.kernel.org,
Prahlad Kilambi <prahladk@google.com>,
Joel Fernandes <joelaf@google.com>,
android-kernel <android-kernel@google.com>
Subject: Re: [PATCH v3] gpu/trace: add gpu memory tracepoints
Date: Thu, 13 Feb 2020 09:49:58 -0800 [thread overview]
Message-ID: <CAKT=dDmB=TX++VeL=-NihDv5L4iBn_48=i7Lsnrkd+4e13QQsQ@mail.gmail.com> (raw)
In-Reply-To: <20200213090308.223f3f20@gandalf.local.home>
Hi folks,
This [PATCH v3] just re-format the tracepoint definition and update
the subject line. Please take another look. Many thanks!
Best,
Yiwei
On Thu, Feb 13, 2020 at 6:03 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> Hi Yiwei,
>
> You left off a lot of people that you Cc'd for the previous versions.
> You'll need at least Greg's acked-by on this, and perhaps even others
> that own the gpu directory.
>
> -- Steve
>
>
> On Wed, 12 Feb 2020 20:23:31 -0800
> zzyiwei@google.com wrote:
>
> > From: Yiwei Zhang <zzyiwei@google.com>
> >
> > This change adds the below gpu memory tracepoint:
> > gpu_mem/gpu_mem_total: track global or process gpu memory total counters
> >
> > Signed-off-by: Yiwei Zhang <zzyiwei@google.com>
> > ---
> > drivers/Kconfig | 2 ++
> > drivers/gpu/Makefile | 1 +
> > drivers/gpu/trace/Kconfig | 4 +++
> > drivers/gpu/trace/Makefile | 3 ++
> > drivers/gpu/trace/trace_gpu_mem.c | 13 +++++++
> > include/trace/events/gpu_mem.h | 57 +++++++++++++++++++++++++++++++
> > 6 files changed, 80 insertions(+)
> > create mode 100644 drivers/gpu/trace/Kconfig
> > create mode 100644 drivers/gpu/trace/Makefile
> > create mode 100644 drivers/gpu/trace/trace_gpu_mem.c
> > create mode 100644 include/trace/events/gpu_mem.h
> >
> > diff --git a/drivers/Kconfig b/drivers/Kconfig
> > index 8befa53f43be..e0eda1a5c3f9 100644
> > --- a/drivers/Kconfig
> > +++ b/drivers/Kconfig
> > @@ -200,6 +200,8 @@ source "drivers/thunderbolt/Kconfig"
> >
> > source "drivers/android/Kconfig"
> >
> > +source "drivers/gpu/trace/Kconfig"
> > +
> > source "drivers/nvdimm/Kconfig"
> >
> > source "drivers/dax/Kconfig"
> > diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile
> > index f17d01f076c7..835c88318cec 100644
> > --- a/drivers/gpu/Makefile
> > +++ b/drivers/gpu/Makefile
> > @@ -5,3 +5,4 @@
> > obj-$(CONFIG_TEGRA_HOST1X) += host1x/
> > obj-y += drm/ vga/
> > obj-$(CONFIG_IMX_IPUV3_CORE) += ipu-v3/
> > +obj-$(CONFIG_TRACE_GPU_MEM) += trace/
> > diff --git a/drivers/gpu/trace/Kconfig b/drivers/gpu/trace/Kconfig
> > new file mode 100644
> > index 000000000000..c24e9edd022e
> > --- /dev/null
> > +++ b/drivers/gpu/trace/Kconfig
> > @@ -0,0 +1,4 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +config TRACE_GPU_MEM
> > + bool
> > diff --git a/drivers/gpu/trace/Makefile b/drivers/gpu/trace/Makefile
> > new file mode 100644
> > index 000000000000..b70fbdc5847f
> > --- /dev/null
> > +++ b/drivers/gpu/trace/Makefile
> > @@ -0,0 +1,3 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +obj-$(CONFIG_TRACE_GPU_MEM) += trace_gpu_mem.o
> > diff --git a/drivers/gpu/trace/trace_gpu_mem.c b/drivers/gpu/trace/trace_gpu_mem.c
> > new file mode 100644
> > index 000000000000..01e855897b6d
> > --- /dev/null
> > +++ b/drivers/gpu/trace/trace_gpu_mem.c
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * GPU memory trace points
> > + *
> > + * Copyright (C) 2020 Google, Inc.
> > + */
> > +
> > +#include <linux/module.h>
> > +
> > +#define CREATE_TRACE_POINTS
> > +#include <trace/events/gpu_mem.h>
> > +
> > +EXPORT_TRACEPOINT_SYMBOL(gpu_mem_total);
> > diff --git a/include/trace/events/gpu_mem.h b/include/trace/events/gpu_mem.h
> > new file mode 100644
> > index 000000000000..1897822a9150
> > --- /dev/null
> > +++ b/include/trace/events/gpu_mem.h
> > @@ -0,0 +1,57 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * GPU memory trace points
> > + *
> > + * Copyright (C) 2020 Google, Inc.
> > + */
> > +
> > +#undef TRACE_SYSTEM
> > +#define TRACE_SYSTEM gpu_mem
> > +
> > +#if !defined(_TRACE_GPU_MEM_H) || defined(TRACE_HEADER_MULTI_READ)
> > +#define _TRACE_GPU_MEM_H
> > +
> > +#include <linux/tracepoint.h>
> > +
> > +/*
> > + * The gpu_memory_total event indicates that there's an update to either the
> > + * global or process total gpu memory counters.
> > + *
> > + * This event should be emitted whenever the kernel device driver allocates,
> > + * frees, imports, unimports memory in the GPU addressable space.
> > + *
> > + * @gpu_id: This is the gpu id.
> > + *
> > + * @pid: Put 0 for global total, while positive pid for process total.
> > + *
> > + * @size: Virtual size of the allocation in bytes.
> > + *
> > + */
> > +TRACE_EVENT(gpu_mem_total,
> > +
> > + TP_PROTO(uint32_t gpu_id, uint32_t pid, uint64_t size),
> > +
> > + TP_ARGS(gpu_id, pid, size),
> > +
> > + TP_STRUCT__entry(
> > + __field(uint32_t, gpu_id)
> > + __field(uint32_t, pid)
> > + __field(uint64_t, size)
> > + ),
> > +
> > + TP_fast_assign(
> > + __entry->gpu_id = gpu_id;
> > + __entry->pid = pid;
> > + __entry->size = size;
> > + ),
> > +
> > + TP_printk("gpu_id=%u pid=%u size=%llu",
> > + __entry->gpu_id,
> > + __entry->pid,
> > + __entry->size)
> > +);
> > +
> > +#endif /* _TRACE_GPU_MEM_H */
> > +
> > +/* This part must be outside protection */
> > +#include <trace/define_trace.h>
>
next prev parent reply other threads:[~2020-02-13 17:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 0:32 [PATCH v2] Add gpu memory tracepoints zzyiwei
2020-02-13 0:39 ` Yiwei Zhang
2020-02-13 0:40 ` Greg KH
2020-02-13 1:23 ` Yiwei Zhang
2020-02-13 1:48 ` Steven Rostedt
2020-02-13 2:20 ` zzyiwei
2020-02-13 2:24 ` Yiwei Zhang
2020-02-13 3:29 ` Steven Rostedt
2020-02-13 4:23 ` [PATCH v3] gpu/trace: add " zzyiwei
2020-02-13 4:27 ` Yiwei Zhang
2020-02-13 14:03 ` Steven Rostedt
2020-02-13 17:49 ` Yiwei Zhang [this message]
2020-02-24 6:31 ` Yiwei Zhang
2020-02-24 16:38 ` Steven Rostedt
2020-03-01 0:53 ` Yiwei Zhang
2020-03-02 23:48 ` [PATCH] [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint zzyiwei
2020-03-02 23:56 ` Yiwei Zhang
2020-03-02 23:50 ` zzyiwei
2020-03-03 14:07 ` Steven Rostedt
2020-03-03 14:15 ` Greg KH
2020-03-03 14:31 ` Steven Rostedt
2020-03-03 15:15 ` Yiwei Zhang
2020-03-03 15:48 ` Steven Rostedt
2020-03-03 15:56 ` Greg KH
2020-03-13 22:59 ` Yiwei Zhang
2020-03-16 18:05 ` Steven Rostedt
2020-03-16 19:28 ` Yiwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKT=dDmB=TX++VeL=-NihDv5L4iBn_48=i7Lsnrkd+4e13QQsQ@mail.gmail.com' \
--to=zzyiwei@google.com \
--cc=android-kernel@google.com \
--cc=elder@kernel.org \
--cc=federico.vaga@cern.ch \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.walmsley@sifive.com \
--cc=prahladk@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).