From: Rob Herring <robh@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>,
Robert Richter <rric@kernel.org>,
soc@kernel.org, Jon Loeliger <jdl@jdl.com>,
Mark Langsdorf <mlangsdo@redhat.com>,
Eric Auger <eric.auger@redhat.com>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v2 01/13] arm: dts: calxeda: Basic DT file fixes
Date: Thu, 27 Feb 2020 15:42:18 -0600 [thread overview]
Message-ID: <20200227214218.GA26010@bogus> (raw)
In-Reply-To: <20200227182210.89512-2-andre.przywara@arm.com>
On Thu, Feb 27, 2020 at 06:21:58PM +0000, Andre Przywara wrote:
> The .dts files for the Calxeda machines are quite old, so carry some
> sloppy mistakes that the DT schema checker will complain about.
>
> Fix those issues, they should not have any effect on functionality.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> arch/arm/boot/dts/ecx-2000.dts | 3 ---
> arch/arm/boot/dts/highbank.dts | 7 ++-----
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ecx-2000.dts b/arch/arm/boot/dts/ecx-2000.dts
> index 5651ae6dc969..81eb382b4c23 100644
> --- a/arch/arm/boot/dts/ecx-2000.dts
> +++ b/arch/arm/boot/dts/ecx-2000.dts
> @@ -13,7 +13,6 @@
> compatible = "calxeda,ecx-2000";
> #address-cells = <2>;
> #size-cells = <2>;
> - clock-ranges;
>
> cpus {
> #address-cells = <1>;
> @@ -83,8 +82,6 @@
> intc: interrupt-controller@fff11000 {
> compatible = "arm,cortex-a15-gic";
> #interrupt-cells = <3>;
> - #size-cells = <0>;
> - #address-cells = <1>;
This is needed if there's an interrupt-map pointing to the gic node.
However, it should be 0 in that case.
I thought we had to fix this at some point, but I can't find any record
of it. So I guess fine to remove.
Reviewed-by: Rob Herring <robh@kernel.org>
> interrupt-controller;
> interrupts = <1 9 0xf04>;
> reg = <0xfff11000 0x1000>,
> diff --git a/arch/arm/boot/dts/highbank.dts b/arch/arm/boot/dts/highbank.dts
> index f4e4dca6f7e7..9e34d1bd7994 100644
> --- a/arch/arm/boot/dts/highbank.dts
> +++ b/arch/arm/boot/dts/highbank.dts
> @@ -13,7 +13,6 @@
> compatible = "calxeda,highbank";
> #address-cells = <1>;
> #size-cells = <1>;
> - clock-ranges;
>
> cpus {
> #address-cells = <1>;
> @@ -96,7 +95,7 @@
> };
> };
>
> - memory {
> + memory@0 {
> name = "memory";
> device_type = "memory";
> reg = <0x00000000 0xff900000>;
> @@ -128,14 +127,12 @@
> intc: interrupt-controller@fff11000 {
> compatible = "arm,cortex-a9-gic";
> #interrupt-cells = <3>;
> - #size-cells = <0>;
> - #address-cells = <1>;
> interrupt-controller;
> reg = <0xfff11000 0x1000>,
> <0xfff10100 0x100>;
> };
>
> - L2: l2-cache {
> + L2: cache-controller {
> compatible = "arm,pl310-cache";
> reg = <0xfff12000 0x1000>;
> interrupts = <0 70 4>;
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-02-27 21:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:21 [PATCH v2 00/13] arm: calxeda: update DTS, bindings and MAINTAINERS Andre Przywara
2020-02-27 18:21 ` [PATCH v2 01/13] arm: dts: calxeda: Basic DT file fixes Andre Przywara
2020-02-27 21:42 ` Rob Herring [this message]
2020-02-27 18:21 ` [PATCH v2 02/13] arm: dts: calxeda: Provide UART clock Andre Przywara
2020-02-27 21:43 ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 03/13] arm: dts: calxeda: Fix interrupt grouping Andre Przywara
2020-02-27 21:45 ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 04/13] arm: dts: calxeda: Group port-phys and sgpio-gpio items Andre Przywara
2020-02-27 21:45 ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 05/13] dt-bindings: clock: Convert Calxeda clock bindings to json-schema Andre Przywara
2020-02-27 18:22 ` [PATCH v2 06/13] dt-bindings: sata: Convert Calxeda SATA controller " Andre Przywara
2020-02-27 22:05 ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 07/13] dt-bindings: net: Convert Calxeda Ethernet binding " Andre Przywara
2020-02-27 18:22 ` [PATCH v2 08/13] dt-bindings: phy: Convert Calxeda ComboPHY " Andre Przywara
2020-02-27 18:22 ` [PATCH v2 09/13] dt-bindings: arm: Convert Calxeda L2 cache controller " Andre Przywara
2020-02-27 18:22 ` [PATCH v2 10/13] dt-bindings: memory-controllers: Convert Calxeda DDR " Andre Przywara
2020-02-27 18:22 ` [PATCH v2 11/13] dt-bindings: ipmi: Convert IPMI-SMIC bindings " Andre Przywara
2020-02-27 22:21 ` Rob Herring
2020-02-28 0:21 ` André Przywara
2020-02-27 18:22 ` [PATCH v2 12/13] dt-bindings: arm: Add Calxeda system registers json-schema binding Andre Przywara
2020-02-27 22:22 ` Rob Herring
2020-02-27 18:22 ` [PATCH v2 13/13] MAINTAINERS: Update Calxeda Highbank maintainership Andre Przywara
2020-02-27 22:35 ` Rob Herring
2020-02-28 0:39 ` Olof Johansson
2020-02-28 11:53 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227214218.GA26010@bogus \
--to=robh@kernel.org \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=jdl@jdl.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=mripard@kernel.org \
--cc=rric@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).