linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Alban Bedel <alban.bedel@aerq.com>,
	linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support
Date: Fri, 18 Sep 2020 11:03:30 +0100	[thread overview]
Message-ID: <20200918100330.GA5703@sirena.org.uk> (raw)
In-Reply-To: <e5863e71-2531-b0de-c432-4bc2967d56c8@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Thu, Sep 17, 2020 at 07:04:51PM -0700, Guenter Roeck wrote:
> On 9/17/20 4:00 AM, Mark Brown wrote:
> > On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote:

> >> +	data->vs = devm_regulator_get_optional(dev, "vs");
> >> +	if (IS_ERR(data->vs)) {

> > Unless the device can work without power you should not be using
> > regulator_get_optional().

> The driver works today without regulator, and needs to continue
> doing so.

And it will continue to do so if it uses the normal regulator API, it
will as ever ensure that if no regulator is provided by the firmware a
dummy is provided.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-09-18 10:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 10:18 [PATCH 0/3] hwmon: (lm75) Add regulator support Alban Bedel
2020-09-17 10:18 ` [PATCH 1/3] dt-bindings: hwmon: Convert lm75 bindings to yaml Alban Bedel
2020-09-18 17:28   ` Rob Herring
2020-09-17 10:18 ` [PATCH 2/3] dt-bindings: hwmon: Add the +vs supply to the lm75 bindings Alban Bedel
2020-09-23 20:16   ` Rob Herring
2020-09-17 10:18 ` [PATCH 3/3] hwmon: (lm75) Add regulator support Alban Bedel
2020-09-17 11:00   ` Mark Brown
2020-09-18  2:04     ` Guenter Roeck
2020-09-18 10:03       ` Mark Brown [this message]
2020-09-18  5:33   ` Guenter Roeck
2020-09-18 10:04     ` Mark Brown
2020-09-28 15:13     ` Bedel, Alban
2020-09-28 16:29       ` Guenter Roeck
2020-09-28 16:31         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918100330.GA5703@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alban.bedel@aerq.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).