From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rdma@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: remaining flexible-array conversions
Date: Thu, 8 Oct 2020 12:54:26 -0300 [thread overview]
Message-ID: <20201008155426.GE5177@ziepe.ca> (raw)
In-Reply-To: <36r41qn8-87o3-2pr1-856p-040167pq097@vanv.qr>
On Thu, Oct 08, 2020 at 05:24:03PM +0200, Jan Engelhardt wrote:
> In the case of the RDMA headers, even if we assume best conditions --
> a block of malloc(sizeof(struct ib_uverbs_create_cq_resp) +
> sizeof(u64)*N) and not some struct -- it smells a lot like undefined
> behavior, because ib_uverbs_create_cq_resp::driver_data accesses data
> as u64
driver_data[] is never accessed, it is only used as a pointer. Aliasing
should be OK because all accesses to those bytes consistently use u32.
Fixing the compiler warning requires significant edits of kernel and
user code, not entirely sure it is worthwhile.
If someone wants to do it let me know and I'll give some guidance.
Jason
next prev parent reply other threads:[~2020-10-08 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 18:26 remaining flexible-array conversions Gustavo A. R. Silva
2020-04-23 19:15 ` Linus Torvalds
2020-04-24 14:53 ` Gustavo A. R. Silva
2020-04-24 3:47 ` Nathan Chancellor
2020-04-24 12:15 ` Jason Gunthorpe
2020-04-24 15:24 ` Kees Cook
2020-04-24 15:36 ` Gustavo A. R. Silva
2020-10-08 15:24 ` Jan Engelhardt
2020-10-08 15:54 ` Jason Gunthorpe [this message]
2020-04-24 15:17 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008155426.GE5177@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=jengelh@inai.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).