From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: remaining flexible-array conversions
Date: Thu, 23 Apr 2020 12:15:49 -0700 [thread overview]
Message-ID: <CAHk-=wg+TdPXZ4bDgEwg9x+0m0cmNhwAB3XDQNjwwMjUTG3GJA@mail.gmail.com> (raw)
In-Reply-To: <6342c465-e34b-3e18-cc31-1d989926aebd@embeddedor.com>
On Wed, Apr 22, 2020 at 11:23 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Just wanted to ask you if you would agree on pulling the remaining
> flexible-array conversions all at once, after they bake for a couple
> of weeks in linux-next[1]
>
> This is not a disruptive change and there are no code generation
> differences.
The "no code generation differnces" is a good thing, but how was that
tested? I assume just one configuration or architecture?
Also, it bothers me a bit that some of the diff is unrelated
whitespace cleanup. I'd actually be happier with a pure scripted patch
(maybe coccinelle, maybe something else), than something that looks
like it's at least partly manual. In particular, if I can re-create
the diff with a script, I'd not have to worry about verifying it other
ways..
Linus
next prev parent reply other threads:[~2020-04-23 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 18:26 remaining flexible-array conversions Gustavo A. R. Silva
2020-04-23 19:15 ` Linus Torvalds [this message]
2020-04-24 14:53 ` Gustavo A. R. Silva
2020-04-24 3:47 ` Nathan Chancellor
2020-04-24 12:15 ` Jason Gunthorpe
2020-04-24 15:24 ` Kees Cook
2020-04-24 15:36 ` Gustavo A. R. Silva
2020-10-08 15:24 ` Jan Engelhardt
2020-10-08 15:54 ` Jason Gunthorpe
2020-04-24 15:17 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg+TdPXZ4bDgEwg9x+0m0cmNhwAB3XDQNjwwMjUTG3GJA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).