linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Brace <don.brace@microchip.com>
To: <hch@infradead.org>, <martin.peterson@oracle.com>,
	<jejb@linux.vnet.ibm.com>, <linux-scsi@vger.kernel.org>
Cc: <Kevin.Barnett@microchip.com>, <scott.teel@microchip.com>,
	<Justin.Lindley@microchip.com>, <scott.benesh@microchip.com>,
	<gerry.morong@microchip.com>, <mahesh.rajashekhara@microchip.com>,
	<mike.mcgowen@microchip.com>, <murthy.bhat@microchip.com>,
	<balsundar.p@microchip.com>, <joseph.szczypek@hpe.com>,
	<jeff@canonical.com>, <POSWALD@suse.com>,
	<john.p.donnelly@oracle.com>, <mwilck@suse.com>,
	<pmenzel@molgen.mpg.de>, <linux-kernel@vger.kernel.org>
Subject: [smartpqi updates  PATCH 4/9] smartpqi: add SCSI cmd info for resets
Date: Tue, 6 Jul 2021 13:16:13 -0500	[thread overview]
Message-ID: <20210706181618.27960-5-don.brace@microchip.com> (raw)
In-Reply-To: <20210706181618.27960-1-don.brace@microchip.com>

From: Murthy Bhat <Murthy.Bhat@microchip.com>

Report on SCSI command that has triggered the reset.
 - Also add check for 0 length SCSI commands.

Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Signed-off-by: Murthy Bhat <Murthy.Bhat@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi_init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 5ce1c41a758d..c2ddb66b5c2d 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -6033,8 +6033,10 @@ static int pqi_eh_device_reset_handler(struct scsi_cmnd *scmd)
 	mutex_lock(&ctrl_info->lun_reset_mutex);
 
 	dev_err(&ctrl_info->pci_dev->dev,
-		"resetting scsi %d:%d:%d:%d\n",
-		shost->host_no, device->bus, device->target, device->lun);
+		"resetting scsi %d:%d:%d:%d due to cmd 0x%02x\n",
+		shost->host_no,
+		device->bus, device->target, device->lun,
+		scmd->cmd_len > 0 ? scmd->cmnd[0] : 0xff);
 
 	pqi_check_ctrl_health(ctrl_info);
 	if (pqi_ctrl_offline(ctrl_info))
-- 
2.28.0.rc1.9.ge7ae437ac1


  parent reply	other threads:[~2021-07-06 18:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 18:16 [smartpqi updates PATCH 0/9] smartpqi updates Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 1/9] smartpqi: add pci id for H3C controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller features msgs Don Brace
2021-07-07  7:28   ` Paul Menzel
2021-07-08 19:04     ` Don.Brace
2021-07-09  7:24       ` Paul Menzel
2021-07-09 15:06         ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 3/9] smartpqi: update copyright notices Don Brace
2021-07-07  7:35   ` Paul Menzel
2021-07-08 19:10     ` Don.Brace
2021-07-06 18:16 ` Don Brace [this message]
2021-07-07  7:37   ` [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for resets Paul Menzel
2021-07-08 20:20     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 5/9] smartpqi: add PCI id for H3C P4408 controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 6/9] smartpqi: add PCI-ID for new Norsi controller Don Brace
2021-07-07  7:38   ` Paul Menzel
2021-07-08 21:35     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 7/9] smartpqi: add PCI IDs for new ZTE controllers Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member Don Brace
2021-07-07  7:48   ` Paul Menzel
2021-07-08 21:17     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 9/9] smartpqi: update version to 2.1.10-020 Don Brace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706181618.27960-5-don.brace@microchip.com \
    --to=don.brace@microchip.com \
    --cc=Justin.Lindley@microchip.com \
    --cc=Kevin.Barnett@microchip.com \
    --cc=POSWALD@suse.com \
    --cc=balsundar.p@microchip.com \
    --cc=gerry.morong@microchip.com \
    --cc=hch@infradead.org \
    --cc=jeff@canonical.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.p.donnelly@oracle.com \
    --cc=joseph.szczypek@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mahesh.rajashekhara@microchip.com \
    --cc=martin.peterson@oracle.com \
    --cc=mike.mcgowen@microchip.com \
    --cc=murthy.bhat@microchip.com \
    --cc=mwilck@suse.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=scott.benesh@microchip.com \
    --cc=scott.teel@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).