linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Don Brace <don.brace@microchip.com>,
	Mike McGowen <mike.mcgowen@microchip.com>
Cc: Kevin.Barnett@microchip.com, scott.teel@microchip.com,
	Justin.Lindley@microchip.com, scott.benesh@microchip.com,
	gerry.morong@microchip.com, mahesh.rajashekhara@microchip.com,
	murthy.bhat@microchip.com, balsundar.p@microchip.com,
	joseph.szczypek@hpe.com, jeff@canonical.com, POSWALD@suse.com,
	john.p.donnelly@oracle.com, mwilck@suse.com,
	linux-kernel@vger.kernel.org, hch@infradead.org,
	martin.peterson@oracle.com, jejb@linux.vnet.ibm.com,
	linux-scsi@vger.kernel.org
Subject: Re: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member
Date: Wed, 7 Jul 2021 09:48:07 +0200	[thread overview]
Message-ID: <fa3b5d5a-fdd3-48c7-b8d5-1a732b09bf68@molgen.mpg.de> (raw)
In-Reply-To: <20210706181618.27960-9-don.brace@microchip.com>

Dear Don, dear Mike,


Am 06.07.21 um 20:16 schrieb Don Brace:
> From: Mike McGowen <mike.mcgowen@microchip.com>
> 
> Correct driver's ISR accessing a data structure member
> that has not been fully initialized during driver init.

Does that crash the Linux kernel?

>    - The pqi queue groups can be null when an interrupt fires.

If it fixes a crash(?), please add a Fixes: tag so it can be backported 
to the stable series.

> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Mike McGowen <mike.mcgowen@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 6f2263abaa8c..eeaf0568b5e3 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -7757,11 +7757,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info)
>   
>   	pqi_init_operational_queues(ctrl_info);
>   
> -	rc = pqi_request_irqs(ctrl_info);
> +	rc = pqi_create_queues(ctrl_info);

 From a quick look, these two functions are quite different. It’d be 
great if you elaborated a bit in the commit message, what else the new 
function does.

Also, with this change, `pqi_request_irqs()` does not seem to have any 
users anymore. Without your patch:

     $ git grep pqi_request_irqs
     drivers/scsi/smartpqi/smartpqi_init.c:static int 
pqi_request_irqs(struct pqi_ctrl_info *ctrl_info)
     drivers/scsi/smartpqi/smartpqi_init.c:  rc = 
pqi_request_irqs(ctrl_info);

>   	if (rc)
>   		return rc;
>   
> -	rc = pqi_create_queues(ctrl_info);
> +	rc = pqi_request_irqs(ctrl_info);
>   	if (rc)
>   		return rc;
> 


Kind regards,

Paul

  reply	other threads:[~2021-07-07  7:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 18:16 [smartpqi updates PATCH 0/9] smartpqi updates Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 1/9] smartpqi: add pci id for H3C controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller features msgs Don Brace
2021-07-07  7:28   ` Paul Menzel
2021-07-08 19:04     ` Don.Brace
2021-07-09  7:24       ` Paul Menzel
2021-07-09 15:06         ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 3/9] smartpqi: update copyright notices Don Brace
2021-07-07  7:35   ` Paul Menzel
2021-07-08 19:10     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for resets Don Brace
2021-07-07  7:37   ` Paul Menzel
2021-07-08 20:20     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 5/9] smartpqi: add PCI id for H3C P4408 controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 6/9] smartpqi: add PCI-ID for new Norsi controller Don Brace
2021-07-07  7:38   ` Paul Menzel
2021-07-08 21:35     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 7/9] smartpqi: add PCI IDs for new ZTE controllers Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member Don Brace
2021-07-07  7:48   ` Paul Menzel [this message]
2021-07-08 21:17     ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 9/9] smartpqi: update version to 2.1.10-020 Don Brace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa3b5d5a-fdd3-48c7-b8d5-1a732b09bf68@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=Justin.Lindley@microchip.com \
    --cc=Kevin.Barnett@microchip.com \
    --cc=POSWALD@suse.com \
    --cc=balsundar.p@microchip.com \
    --cc=don.brace@microchip.com \
    --cc=gerry.morong@microchip.com \
    --cc=hch@infradead.org \
    --cc=jeff@canonical.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.p.donnelly@oracle.com \
    --cc=joseph.szczypek@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mahesh.rajashekhara@microchip.com \
    --cc=martin.peterson@oracle.com \
    --cc=mike.mcgowen@microchip.com \
    --cc=murthy.bhat@microchip.com \
    --cc=mwilck@suse.com \
    --cc=scott.benesh@microchip.com \
    --cc=scott.teel@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).