From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Don.Brace@microchip.com, Kevin.Barnett@microchip.com
Cc: Scott.Teel@microchip.com, Justin.Lindley@microchip.com,
Scott.Benesh@microchip.com, Gerry.Morong@microchip.com,
Mahesh.Rajashekhara@microchip.com, Mike.McGowen@microchip.com,
Murthy.Bhat@microchip.com, Balsundar.P@microchip.com,
joseph.szczypek@hpe.com, jeff@canonical.com, POSWALD@suse.com,
john.p.donnelly@oracle.com, mwilck@suse.com,
linux-kernel@vger.kernel.org, hch@infradead.org,
martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org
Subject: Re: [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller features msgs
Date: Fri, 9 Jul 2021 09:24:21 +0200 [thread overview]
Message-ID: <4b68177b-4c61-74fd-eee7-83b938200278@molgen.mpg.de> (raw)
In-Reply-To: <SN6PR11MB284877FDAB929F223AEC14B5E1199@SN6PR11MB2848.namprd11.prod.outlook.com>
[I corrected Martin’s email from peterson to peters*e*n. Don, you should
have also receive a bounce message from the MTA. I guess Martin has
these as a list subscriber nevertheless, but I suggest to resend the
series as soon as possible.]
Dear Don,
Thank you for your reply.
Am 08.07.21 um 21:04 schrieb Don.Brace@microchip.com:
> -----Original Message-----
> From: Paul Menzel [mailto:pmenzel@molgen.mpg.de]
> Sent: Wednesday, July 7, 2021 2:29 AM
> Subject: Re: [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller features msgs
> Am 06.07.21 um 20:16 schrieb Don Brace:
>> From: Kevin Barnett <kevin.barnett@microchip.com>
>>
>> Remove "Feature XYZ not supported by controller" messages.
>>
>> During driver initialization, the driver examines the PQI Table Feature bits.
>> These bits are used by the controller to advertise features supported
>> by the controller. For any features not supported by the controller,
>> the driver would display a message in the form:
>> "Feature XYZ not supported by controller"
>> Some of these "negative" messages were causing customer confusion.
>
> As it’s info log level and not warning or notice, these message are
> useful in my opinion. You could downgrade them to debug, but I do not
> see why. If customers do not want to see these info messages, they
> should filter them out.
>
> For completeness, is there an alternative to list the unsupported
> features from the firmware for example from sysfs?
> Don> Thanks for your Review. At this time we would prefer to not
> provide messages about unsupported features.
Only because a customer complained? That is not a good enough reason in
my opinion. Log messages, often grepped for, are an interface which
should only be changed with caution.
If these absent feature message were present for a long time, and you
suddenly remove them, people looking a newer Linux kernel messages,
users conclude the feature is supported now. That is quite a downside in
my opinion.
> We may add them back at some point but we have taken them out of our
> out-of-box driver also so we hope to keep the driver code in sync.
That’s why you should develop for Linux master branch and upstream
*first* to get external reviews. That argument should not count for
Linux upstream reviews in my opinion.
Kind regards,
Paul
>> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
>> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
>> Reviewed-by: Scott Teel <scott.teel@microchip.com>
>> Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com>
>> Signed-off-by: Don Brace <don.brace@microchip.com>
>> ---
>> drivers/scsi/smartpqi/smartpqi_init.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
>> b/drivers/scsi/smartpqi/smartpqi_init.c
>> index d977c7b30d5c..7958316841a4 100644
>> --- a/drivers/scsi/smartpqi/smartpqi_init.c
>> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
>> @@ -7255,11 +7255,8 @@ struct pqi_firmware_feature {
>> static void pqi_firmware_feature_status(struct pqi_ctrl_info *ctrl_info,
>> struct pqi_firmware_feature *firmware_feature)
>> {
>> - if (!firmware_feature->supported) {
>> - dev_info(&ctrl_info->pci_dev->dev, "%s not supported by controller\n",
>> - firmware_feature->feature_name);
>> + if (!firmware_feature->supported)
>> return;
>> - }
>>
>> if (firmware_feature->enabled) {
>> dev_info(&ctrl_info->pci_dev->dev,
>>
next prev parent reply other threads:[~2021-07-09 7:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 18:16 [smartpqi updates PATCH 0/9] smartpqi updates Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 1/9] smartpqi: add pci id for H3C controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller features msgs Don Brace
2021-07-07 7:28 ` Paul Menzel
2021-07-08 19:04 ` Don.Brace
2021-07-09 7:24 ` Paul Menzel [this message]
2021-07-09 15:06 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 3/9] smartpqi: update copyright notices Don Brace
2021-07-07 7:35 ` Paul Menzel
2021-07-08 19:10 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for resets Don Brace
2021-07-07 7:37 ` Paul Menzel
2021-07-08 20:20 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 5/9] smartpqi: add PCI id for H3C P4408 controller Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 6/9] smartpqi: add PCI-ID for new Norsi controller Don Brace
2021-07-07 7:38 ` Paul Menzel
2021-07-08 21:35 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 7/9] smartpqi: add PCI IDs for new ZTE controllers Don Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member Don Brace
2021-07-07 7:48 ` Paul Menzel
2021-07-08 21:17 ` Don.Brace
2021-07-06 18:16 ` [smartpqi updates PATCH 9/9] smartpqi: update version to 2.1.10-020 Don Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b68177b-4c61-74fd-eee7-83b938200278@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=Balsundar.P@microchip.com \
--cc=Don.Brace@microchip.com \
--cc=Gerry.Morong@microchip.com \
--cc=Justin.Lindley@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=Mahesh.Rajashekhara@microchip.com \
--cc=Mike.McGowen@microchip.com \
--cc=Murthy.Bhat@microchip.com \
--cc=POSWALD@suse.com \
--cc=Scott.Benesh@microchip.com \
--cc=Scott.Teel@microchip.com \
--cc=hch@infradead.org \
--cc=jeff@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.p.donnelly@oracle.com \
--cc=joseph.szczypek@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).