From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
Alvin Sipraga <ALSI@bang-olufsen.dk>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT
Date: Thu, 26 Aug 2021 00:45:24 -0700 [thread overview]
Message-ID: <20210826074526.825517-2-saravanak@google.com> (raw)
In-Reply-To: <20210826074526.825517-1-saravanak@google.com>
If a parent device is also a supplier to a child device, fw_devlink=on
(correctly) delays the probe() of the child device until the probe() of
the parent finishes successfully.
However, some drivers of such parent devices (where parent is also a
supplier) incorrectly expect the child device to finish probing
successfully as soon as they are added using device_add() and before the
probe() of the parent device has completed successfully. While this
might have worked before, this is not guaranteed by driver core.
fw_devlink=on catches/breaks such drivers. One example of such a case is
discussed in the link mentioned below.
Add a flag to make fw_devlink=on not enforce these supplier-consumer
relationships, so these drivers can continue working. The flag is
intentionally called BROKEN_PARENT so it's clear that this flag
shouldn't be used in the normal case and that there's a problem with the
driver.
Link: https://lore.kernel.org/netdev/CAGETcx_uj0V4DChME-gy5HGKTYnxLBX=TH2rag29f_p=UcG+Tg@mail.gmail.com/
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/base/core.c | 22 ++++++++++++++++++++++
include/linux/fwnode.h | 3 +++
2 files changed, 25 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index f6360490a4a3..2cc34f8ff051 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1719,6 +1719,28 @@ static int fw_devlink_create_devlink(struct device *con,
struct device *sup_dev;
int ret = 0;
+ /*
+ * In some cases, a device P might also be a supplier to its child node
+ * C. However, this would defer the probe of C until the probe of P
+ * completes successfully. This is perfectly fine in the device driver
+ * model. device_add() doesn't guarantee probe completion of the device
+ * by the time it returns.
+ *
+ * However, there are a few drivers that assume C will finish probing
+ * as soon as it's added and before P finishes probing. While this is a
+ * broken assumption that needs the driver to be fixed, we don't want
+ * to block fw_devlink improvements because of these drivers.
+ *
+ * So, we provide a flag to let fw_devlink know not to delay the probe
+ * of C until the probe of P completes successfully.
+ *
+ * When such a flag is set, we can't create device links with P as the
+ * supplier of C as that would delay the probe of C.
+ */
+ if (sup_handle->flags & FWNODE_FLAG_BROKEN_PARENT &&
+ fwnode_is_ancestor_of(sup_handle, con->fwnode))
+ return -EINVAL;
+
sup_dev = get_dev_from_fwnode(sup_handle);
if (sup_dev) {
/*
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 59828516ebaf..9382065e6ff8 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -22,10 +22,13 @@ struct device;
* LINKS_ADDED: The fwnode has already be parsed to add fwnode links.
* NOT_DEVICE: The fwnode will never be populated as a struct device.
* INITIALIZED: The hardware corresponding to fwnode has been initialized.
+ * BROKEN_PARENT: The driver of this fwnode/device expects the child devices to
+ * probe as soon as they are added.
*/
#define FWNODE_FLAG_LINKS_ADDED BIT(0)
#define FWNODE_FLAG_NOT_DEVICE BIT(1)
#define FWNODE_FLAG_INITIALIZED BIT(2)
+#define FWNODE_FLAG_BROKEN_PARENT BIT(3)
struct fwnode_handle {
struct fwnode_handle *secondary;
--
2.33.0.rc2.250.ged5fa647cd-goog
next prev parent reply other threads:[~2021-08-26 7:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 7:45 [PATCH v1 0/2] Fix rtl8366rb issues with fw_devlink=on Saravana Kannan
2021-08-26 7:45 ` Saravana Kannan [this message]
2021-08-26 13:13 ` [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Andrew Lunn
2021-08-26 19:56 ` Saravana Kannan
2021-08-26 20:53 ` Andrew Lunn
2021-08-26 23:44 ` Saravana Kannan
2021-08-27 1:23 ` Andrew Lunn
2021-08-27 4:02 ` Saravana Kannan
2021-08-27 13:44 ` Andrew Lunn
2021-08-27 18:06 ` Saravana Kannan
2021-08-27 20:11 ` Andrew Lunn
2021-08-27 21:33 ` Saravana Kannan
2021-08-28 17:01 ` Andrew Lunn
2021-08-30 19:03 ` Saravana Kannan
2021-08-31 13:16 ` Andrew Lunn
2021-08-31 19:26 ` Saravana Kannan
2021-08-31 22:05 ` Andrew Lunn
2021-08-31 22:18 ` Saravana Kannan
2021-08-31 23:02 ` Andrew Lunn
2021-08-31 23:18 ` Vladimir Oltean
2021-08-31 23:27 ` Andrew Lunn
2021-09-01 1:28 ` Vladimir Oltean
2021-09-01 1:38 ` Vladimir Oltean
2021-09-01 2:19 ` Saravana Kannan
2021-09-01 9:02 ` Vladimir Oltean
2021-09-01 22:57 ` Saravana Kannan
2021-09-01 2:00 ` Saravana Kannan
2021-09-01 8:46 ` Vladimir Oltean
2021-09-01 22:53 ` Saravana Kannan
2021-09-02 17:41 ` Andrew Lunn
2021-09-02 17:58 ` Saravana Kannan
2021-09-30 5:33 ` Saravana Kannan
2021-09-30 13:15 ` Andrew Lunn
2021-09-30 13:43 ` Vladimir Oltean
2021-09-30 14:00 ` Andrew Lunn
2021-09-30 17:31 ` Saravana Kannan
2021-09-30 19:38 ` Andrew Lunn
2021-09-30 19:48 ` Saravana Kannan
2021-09-30 20:06 ` Florian Fainelli
2021-09-30 20:14 ` Saravana Kannan
2021-09-30 21:16 ` Florian Fainelli
2021-09-30 20:22 ` Andrew Lunn
2021-09-01 1:46 ` Saravana Kannan
2021-08-31 23:18 ` Andrew Lunn
2021-09-08 18:35 ` Saravana Kannan
2021-09-09 1:39 ` Andrew Lunn
2021-09-09 3:21 ` Saravana Kannan
2021-09-09 10:38 ` Vladimir Oltean
2021-09-09 15:00 ` Andrew Lunn
2021-09-09 16:56 ` Florian Fainelli
2021-08-26 7:45 ` [PATCH v1 2/2] net: dsa: rtl8366rb: Quick fix to work with fw_devlink=on Saravana Kannan
2021-08-26 7:55 ` Greg Kroah-Hartman
2021-08-26 11:25 ` Florian Fainelli
2021-08-26 17:29 ` Saravana Kannan
2021-08-26 11:29 ` Alvin Šipraga
2021-08-26 17:26 ` Saravana Kannan
2021-08-26 18:04 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826074526.825517-2-saravanak@google.com \
--to=saravanak@google.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).