From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] net: dsa: rtl8366rb: Quick fix to work with fw_devlink=on
Date: Thu, 26 Aug 2021 18:04:34 +0000 [thread overview]
Message-ID: <90623032-7012-d82b-2046-d9796727e53c@bang-olufsen.dk> (raw)
In-Reply-To: <CAGETcx8yhH8o791=DNP3kUAqY+3xyH-Mem717hADqak==qpUtw@mail.gmail.com>
On 8/26/21 7:26 PM, Saravana Kannan wrote:
> On Thu, Aug 26, 2021 at 4:29 AM Alvin Šipraga <ALSI@bang-olufsen.dk> wrote:
>>
>> Hi Saravana,
>>
>> From looking at the code, the Marvell DSA driver mv88e6xxx may also
>> suffer from the same problem if fw_devlink=on. Maybe somebody (Andrew?)
>> could test so that you know whether include a simlar patch to that
>> driver in your series.
>>
>> Other drivers may be effected too - as Andrew said in the other thread,
>> this is not an uncommon pattern for DSA drivers.
>>
>> On 8/26/21 9:45 AM, Saravana Kannan wrote:
>>> This is just a quick fix to make this driver work with fw_devlink=on.
>>> The proper fix might need a significant amount of rework of the driver
>>> of the framework to use a component device model.
>>>
>>> Signed-off-by: Saravana Kannan <saravanak@google.com>
>>
>> With the caveat that it's a test with my RFC rtl8365mb subdriver...
>>
>> Tested-by: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Thanks for testing. And just to be sure we are all on the same page:
> Without this patch the PHYs get handled by the Generic PHY driver.
> With this patch, the PHYs are handled by their specific driver.
> Correct?
Yes, both statements are correct.
Alvin
>
> -Saravana
>
>>
>> Kind regards,
>> Alvin
>>
>>> ---
>>> drivers/net/dsa/realtek-smi-core.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/net/dsa/realtek-smi-core.c b/drivers/net/dsa/realtek-smi-core.c
>>> index 8e49d4f85d48..f79c174f4954 100644
>>> --- a/drivers/net/dsa/realtek-smi-core.c
>>> +++ b/drivers/net/dsa/realtek-smi-core.c
>>> @@ -394,6 +394,13 @@ static int realtek_smi_probe(struct platform_device *pdev)
>>> var = of_device_get_match_data(dev);
>>> np = dev->of_node;
>>>
>>> + /* This driver assumes the child PHYs would be probed successfully
>>> + * before this functions returns. That's not a valid assumption, but
>>> + * let fw_devlink know so that this driver continues to function with
>>> + * fw_devlink=on.
>>> + */
>>> + np->fwnode.flags |= FWNODE_FLAG_BROKEN_PARENT;
>>> +
>>> smi = devm_kzalloc(dev, sizeof(*smi) + var->chip_data_sz, GFP_KERNEL);
>>> if (!smi)
>>> return -ENOMEM;
>>>
prev parent reply other threads:[~2021-08-26 18:04 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 7:45 [PATCH v1 0/2] Fix rtl8366rb issues with fw_devlink=on Saravana Kannan
2021-08-26 7:45 ` [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Saravana Kannan
2021-08-26 13:13 ` Andrew Lunn
2021-08-26 19:56 ` Saravana Kannan
2021-08-26 20:53 ` Andrew Lunn
2021-08-26 23:44 ` Saravana Kannan
2021-08-27 1:23 ` Andrew Lunn
2021-08-27 4:02 ` Saravana Kannan
2021-08-27 13:44 ` Andrew Lunn
2021-08-27 18:06 ` Saravana Kannan
2021-08-27 20:11 ` Andrew Lunn
2021-08-27 21:33 ` Saravana Kannan
2021-08-28 17:01 ` Andrew Lunn
2021-08-30 19:03 ` Saravana Kannan
2021-08-31 13:16 ` Andrew Lunn
2021-08-31 19:26 ` Saravana Kannan
2021-08-31 22:05 ` Andrew Lunn
2021-08-31 22:18 ` Saravana Kannan
2021-08-31 23:02 ` Andrew Lunn
2021-08-31 23:18 ` Vladimir Oltean
2021-08-31 23:27 ` Andrew Lunn
2021-09-01 1:28 ` Vladimir Oltean
2021-09-01 1:38 ` Vladimir Oltean
2021-09-01 2:19 ` Saravana Kannan
2021-09-01 9:02 ` Vladimir Oltean
2021-09-01 22:57 ` Saravana Kannan
2021-09-01 2:00 ` Saravana Kannan
2021-09-01 8:46 ` Vladimir Oltean
2021-09-01 22:53 ` Saravana Kannan
2021-09-02 17:41 ` Andrew Lunn
2021-09-02 17:58 ` Saravana Kannan
2021-09-30 5:33 ` Saravana Kannan
2021-09-30 13:15 ` Andrew Lunn
2021-09-30 13:43 ` Vladimir Oltean
2021-09-30 14:00 ` Andrew Lunn
2021-09-30 17:31 ` Saravana Kannan
2021-09-30 19:38 ` Andrew Lunn
2021-09-30 19:48 ` Saravana Kannan
2021-09-30 20:06 ` Florian Fainelli
2021-09-30 20:14 ` Saravana Kannan
2021-09-30 21:16 ` Florian Fainelli
2021-09-30 20:22 ` Andrew Lunn
2021-09-01 1:46 ` Saravana Kannan
2021-08-31 23:18 ` Andrew Lunn
2021-09-08 18:35 ` Saravana Kannan
2021-09-09 1:39 ` Andrew Lunn
2021-09-09 3:21 ` Saravana Kannan
2021-09-09 10:38 ` Vladimir Oltean
2021-09-09 15:00 ` Andrew Lunn
2021-09-09 16:56 ` Florian Fainelli
2021-08-26 7:45 ` [PATCH v1 2/2] net: dsa: rtl8366rb: Quick fix to work with fw_devlink=on Saravana Kannan
2021-08-26 7:55 ` Greg Kroah-Hartman
2021-08-26 11:25 ` Florian Fainelli
2021-08-26 17:29 ` Saravana Kannan
2021-08-26 11:29 ` Alvin Šipraga
2021-08-26 17:26 ` Saravana Kannan
2021-08-26 18:04 ` Alvin Šipraga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90623032-7012-d82b-2046-d9796727e53c@bang-olufsen.dk \
--to=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).