From: Saravana Kannan <saravanak@google.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>,
Alvin Sipraga <ALSI@bang-olufsen.dk>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT
Date: Tue, 31 Aug 2021 15:18:35 -0700 [thread overview]
Message-ID: <CAGETcx90dOkw+Yp5ZRNqQq2Ny_ToOKvGJNpvyRohaRQi=SQxhw@mail.gmail.com> (raw)
In-Reply-To: <YS6nxLp5TYCK+mJP@lunn.ch>
On Tue, Aug 31, 2021 at 3:06 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Tue, Aug 31, 2021 at 12:26:30PM -0700, Saravana Kannan wrote:
> > On Tue, Aug 31, 2021 at 6:16 AM Andrew Lunn <andrew@lunn.ch> wrote:
> > >
> > > > > I must admit, my main problem at the moment is -rc1 in two weeks
> > > > > time. It seems like a number of board with Ethernet switches will be
> > > > > broken, that worked before. phy-handle is not limited to switch
> > > > > drivers, it is also used for Ethernet drivers. So it could be, a
> > > > > number of Ethernet drivers are also going to be broken in -rc1?
> > > >
> > > > Again, in those cases, based on your FEC example, fw_devlink=on
> > > > actually improves things.
> > >
> > > Debatable. I did some testing. As expected some boards with Ethernet
> > > switches are now broken.
> >
> > To clarify myself, I'm saying the patch to parse "ethernet" [8] will
> > make things better with fw_devlink=on for FEC. Not sure if you tested
> > that patch or not.
>
> Yes and no. I was tested with the FEC, but because of fw_devlink=on,
> the switches don't probe correctly. So it is not possible to see if it
> helped or not, since its plain broken.
>
> > Not sure what was the tip of the tree with which you bisected.
>
> I manually tested linux-next, v5.14, v5.13 and v5.12 and then
> bisected:
>
> $ git bisect log
> git bisect start
> # good: [9f4ad9e425a1d3b6a34617b8ea226d56a119a717] Linux 5.12
> git bisect good 9f4ad9e425a1d3b6a34617b8ea226d56a119a717
> # bad: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13
>
> So well away from linux-next which contains the phy-handle parser.
>
> I will try to give the two patches a try today or tomorrow.
If the switches are broken without the phy-handle or ethernet change,
I'm not sure if the "BROKEN_PARENT" patch would help.
>
> > Thanks for testing it out. And worst case, we'll revert phy-handle
> > support.
>
> Which is not enough to fix these Ethernet switches.
Ok, if you can give more specifics on this, I'll look into it. I'd need:
1) The DTS file that you see the issue on.
2) The devices that don't probe when you have the issue (you can find
these in /sys/kernel/debug/devices_deferred)
3) And if possible boot logs with dev_dbg changed to dev_info in
device_link_add() and device_links_check_suppliers()
Thanks,
Saravana
next prev parent reply other threads:[~2021-08-31 22:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 7:45 [PATCH v1 0/2] Fix rtl8366rb issues with fw_devlink=on Saravana Kannan
2021-08-26 7:45 ` [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Saravana Kannan
2021-08-26 13:13 ` Andrew Lunn
2021-08-26 19:56 ` Saravana Kannan
2021-08-26 20:53 ` Andrew Lunn
2021-08-26 23:44 ` Saravana Kannan
2021-08-27 1:23 ` Andrew Lunn
2021-08-27 4:02 ` Saravana Kannan
2021-08-27 13:44 ` Andrew Lunn
2021-08-27 18:06 ` Saravana Kannan
2021-08-27 20:11 ` Andrew Lunn
2021-08-27 21:33 ` Saravana Kannan
2021-08-28 17:01 ` Andrew Lunn
2021-08-30 19:03 ` Saravana Kannan
2021-08-31 13:16 ` Andrew Lunn
2021-08-31 19:26 ` Saravana Kannan
2021-08-31 22:05 ` Andrew Lunn
2021-08-31 22:18 ` Saravana Kannan [this message]
2021-08-31 23:02 ` Andrew Lunn
2021-08-31 23:18 ` Vladimir Oltean
2021-08-31 23:27 ` Andrew Lunn
2021-09-01 1:28 ` Vladimir Oltean
2021-09-01 1:38 ` Vladimir Oltean
2021-09-01 2:19 ` Saravana Kannan
2021-09-01 9:02 ` Vladimir Oltean
2021-09-01 22:57 ` Saravana Kannan
2021-09-01 2:00 ` Saravana Kannan
2021-09-01 8:46 ` Vladimir Oltean
2021-09-01 22:53 ` Saravana Kannan
2021-09-02 17:41 ` Andrew Lunn
2021-09-02 17:58 ` Saravana Kannan
2021-09-30 5:33 ` Saravana Kannan
2021-09-30 13:15 ` Andrew Lunn
2021-09-30 13:43 ` Vladimir Oltean
2021-09-30 14:00 ` Andrew Lunn
2021-09-30 17:31 ` Saravana Kannan
2021-09-30 19:38 ` Andrew Lunn
2021-09-30 19:48 ` Saravana Kannan
2021-09-30 20:06 ` Florian Fainelli
2021-09-30 20:14 ` Saravana Kannan
2021-09-30 21:16 ` Florian Fainelli
2021-09-30 20:22 ` Andrew Lunn
2021-09-01 1:46 ` Saravana Kannan
2021-08-31 23:18 ` Andrew Lunn
2021-09-08 18:35 ` Saravana Kannan
2021-09-09 1:39 ` Andrew Lunn
2021-09-09 3:21 ` Saravana Kannan
2021-09-09 10:38 ` Vladimir Oltean
2021-09-09 15:00 ` Andrew Lunn
2021-09-09 16:56 ` Florian Fainelli
2021-08-26 7:45 ` [PATCH v1 2/2] net: dsa: rtl8366rb: Quick fix to work with fw_devlink=on Saravana Kannan
2021-08-26 7:55 ` Greg Kroah-Hartman
2021-08-26 11:25 ` Florian Fainelli
2021-08-26 17:29 ` Saravana Kannan
2021-08-26 11:29 ` Alvin Šipraga
2021-08-26 17:26 ` Saravana Kannan
2021-08-26 18:04 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGETcx90dOkw+Yp5ZRNqQq2Ny_ToOKvGJNpvyRohaRQi=SQxhw@mail.gmail.com' \
--to=saravanak@google.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).