* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-05-22 11:56 [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and() Miaohe Lin
@ 2023-05-22 10:47 ` Mukesh Ojha
2023-05-22 16:58 ` Dietmar Eggemann
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Mukesh Ojha @ 2023-05-22 10:47 UTC (permalink / raw)
To: Miaohe Lin, mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel
On 5/22/2023 5:26 PM, Miaohe Lin wrote:
> cpumask_weight_and() can be used to count of bits both in rd->span and
> cpu_active_mask. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> kernel/sched/deadline.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 166c3e6eae61..fe983ed7bb12 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
> static inline int dl_bw_cpus(int i)
> {
> struct root_domain *rd = cpu_rq(i)->rd;
> - int cpus;
>
> RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> "sched RCU must be held");
>
> - if (cpumask_subset(rd->span, cpu_active_mask))
> - return cpumask_weight(rd->span);
> -
> - cpus = 0;
> -
> - for_each_cpu_and(i, rd->span, cpu_active_mask)
> - cpus++;
> -
> - return cpus;
> + return cpumask_weight_and(rd->span, cpu_active_mask);
> }
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
-- Mukesh
>
> static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-05-22 11:56 [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and() Miaohe Lin
2023-05-22 10:47 ` Mukesh Ojha
@ 2023-05-22 16:58 ` Dietmar Eggemann
2023-05-24 10:59 ` Valentin Schneider
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Dietmar Eggemann @ 2023-05-22 16:58 UTC (permalink / raw)
To: Miaohe Lin, mingo, peterz, juri.lelli, vincent.guittot
Cc: rostedt, bsegall, mgorman, bristot, vschneid, linux-kernel
On 22/05/2023 13:56, Miaohe Lin wrote:
> cpumask_weight_and() can be used to count of bits both in rd->span and
> cpu_active_mask. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> kernel/sched/deadline.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 166c3e6eae61..fe983ed7bb12 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
> static inline int dl_bw_cpus(int i)
> {
> struct root_domain *rd = cpu_rq(i)->rd;
> - int cpus;
>
> RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> "sched RCU must be held");
>
> - if (cpumask_subset(rd->span, cpu_active_mask))
> - return cpumask_weight(rd->span);
> -
> - cpus = 0;
> -
> - for_each_cpu_and(i, rd->span, cpu_active_mask)
> - cpus++;
> -
> - return cpus;
> + return cpumask_weight_and(rd->span, cpu_active_mask);
> }
>
> static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-05-22 11:56 [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and() Miaohe Lin
2023-05-22 10:47 ` Mukesh Ojha
2023-05-22 16:58 ` Dietmar Eggemann
@ 2023-05-24 10:59 ` Valentin Schneider
2023-05-25 9:56 ` Daniel Bristot de Oliveira
2023-06-13 12:19 ` Miaohe Lin
4 siblings, 0 replies; 8+ messages in thread
From: Valentin Schneider @ 2023-05-24 10:59 UTC (permalink / raw)
To: Miaohe Lin, mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot,
linux-kernel, linmiaohe
On 22/05/23 19:56, Miaohe Lin wrote:
> cpumask_weight_and() can be used to count of bits both in rd->span and
> cpu_active_mask. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-05-22 11:56 [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and() Miaohe Lin
` (2 preceding siblings ...)
2023-05-24 10:59 ` Valentin Schneider
@ 2023-05-25 9:56 ` Daniel Bristot de Oliveira
2023-06-13 12:19 ` Miaohe Lin
4 siblings, 0 replies; 8+ messages in thread
From: Daniel Bristot de Oliveira @ 2023-05-25 9:56 UTC (permalink / raw)
To: Miaohe Lin, mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, vschneid, linux-kernel
On 5/22/23 13:56, Miaohe Lin wrote:
> cpumask_weight_and() can be used to count of bits both in rd->span and
> cpu_active_mask. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks,
-- Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-05-22 11:56 [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and() Miaohe Lin
` (3 preceding siblings ...)
2023-05-25 9:56 ` Daniel Bristot de Oliveira
@ 2023-06-13 12:19 ` Miaohe Lin
2023-06-13 13:16 ` Phil Auld
4 siblings, 1 reply; 8+ messages in thread
From: Miaohe Lin @ 2023-06-13 12:19 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
linux-kernel
On 2023/5/22 19:56, Miaohe Lin wrote:
> cpumask_weight_and() can be used to count of bits both in rd->span and
> cpu_active_mask. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
friendly ping... :)
> ---
> kernel/sched/deadline.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 166c3e6eae61..fe983ed7bb12 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
> static inline int dl_bw_cpus(int i)
> {
> struct root_domain *rd = cpu_rq(i)->rd;
> - int cpus;
>
> RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> "sched RCU must be held");
>
> - if (cpumask_subset(rd->span, cpu_active_mask))
> - return cpumask_weight(rd->span);
> -
> - cpus = 0;
> -
> - for_each_cpu_and(i, rd->span, cpu_active_mask)
> - cpus++;
> -
> - return cpus;
> + return cpumask_weight_and(rd->span, cpu_active_mask);
> }
>
> static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-06-13 12:19 ` Miaohe Lin
@ 2023-06-13 13:16 ` Phil Auld
2023-06-14 1:43 ` Miaohe Lin
0 siblings, 1 reply; 8+ messages in thread
From: Phil Auld @ 2023-06-13 13:16 UTC (permalink / raw)
To: Miaohe Lin
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid, linux-kernel
On Tue, Jun 13, 2023 at 08:19:22PM +0800 Miaohe Lin wrote:
> On 2023/5/22 19:56, Miaohe Lin wrote:
> > cpumask_weight_and() can be used to count of bits both in rd->span and
> > cpu_active_mask. No functional change intended.
> >
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
> friendly ping... :)
This looks reasonable, and better, to me.
Reviewed-by: Phil Auld <pauld@redhat.com>
>
> > ---
> > kernel/sched/deadline.c | 11 +----------
> > 1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index 166c3e6eae61..fe983ed7bb12 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
> > static inline int dl_bw_cpus(int i)
> > {
> > struct root_domain *rd = cpu_rq(i)->rd;
> > - int cpus;
> >
> > RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> > "sched RCU must be held");
> >
> > - if (cpumask_subset(rd->span, cpu_active_mask))
> > - return cpumask_weight(rd->span);
> > -
> > - cpus = 0;
> > -
> > - for_each_cpu_and(i, rd->span, cpu_active_mask)
> > - cpus++;
> > -
> > - return cpus;
> > + return cpumask_weight_and(rd->span, cpu_active_mask);
> > }
> >
> > static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
> >
>
--
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
2023-06-13 13:16 ` Phil Auld
@ 2023-06-14 1:43 ` Miaohe Lin
0 siblings, 0 replies; 8+ messages in thread
From: Miaohe Lin @ 2023-06-14 1:43 UTC (permalink / raw)
To: Phil Auld, bristot, vschneid, dietmar.eggemann, quic_mojha
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid, linux-kernel
On 2023/6/13 21:16, Phil Auld wrote:
> On Tue, Jun 13, 2023 at 08:19:22PM +0800 Miaohe Lin wrote:
>> On 2023/5/22 19:56, Miaohe Lin wrote:
>>> cpumask_weight_and() can be used to count of bits both in rd->span and
>>> cpu_active_mask. No functional change intended.
>>>
>>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>>
>> friendly ping... :)
>
> This looks reasonable, and better, to me.
>
> Reviewed-by: Phil Auld <pauld@redhat.com>
Many thanks for all of your reviews. :)
>
>>
>>> ---
>>> kernel/sched/deadline.c | 11 +----------
>>> 1 file changed, 1 insertion(+), 10 deletions(-)
>>>
>>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>>> index 166c3e6eae61..fe983ed7bb12 100644
>>> --- a/kernel/sched/deadline.c
>>> +++ b/kernel/sched/deadline.c
>>> @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
>>> static inline int dl_bw_cpus(int i)
>>> {
>>> struct root_domain *rd = cpu_rq(i)->rd;
>>> - int cpus;
>>>
>>> RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
>>> "sched RCU must be held");
>>>
>>> - if (cpumask_subset(rd->span, cpu_active_mask))
>>> - return cpumask_weight(rd->span);
>>> -
>>> - cpus = 0;
>>> -
>>> - for_each_cpu_and(i, rd->span, cpu_active_mask)
>>> - cpus++;
>>> -
>>> - return cpus;
>>> + return cpumask_weight_and(rd->span, cpu_active_mask);
>>> }
>>>
>>> static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
>>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread