From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>, Rajat Jain <rajatja@google.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Keith Busch <keith.busch@intel.com>,
Vidya Sagar <vidyas@nvidia.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Sinan Kaya <okaya@codeaurora.org>,
Frederick Lawler <fred@fredlawl.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
mayurkumar.patel@intel.com, rajatxjain@gmail.com,
Richard Hughes <rhughes@redhat.com>,
Carlos Garnacho <cgarnach@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pali Rohar <pali.rohar@gmail.com>, Takashi Iwai <tiwai@suse.de>,
Andy Whitcroft <apw@canonical.com>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH v2] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG
Date: Sat, 28 Jul 2018 17:16:13 -0700 [thread overview]
Message-ID: <5a102163-73bc-c596-8266-186e222e7ceb@kernel.org> (raw)
In-Reply-To: <20180727202619.GD173328@bhelgaas-glaptop.roam.corp.google.com>
On 7/27/2018 1:26 PM, Bjorn Helgaas wrote:
> - A link can lead to a multi-function device, and the spec allows
> those functions to have different ASPM settings (see PCIe r4.0,
> sec 5.4.1). With the sysfs files at the upstream end of the link,
> we have no way to configure those functions individually.
Even though we can set them individually, there is only one PCIe link
for single function as well as multi-function devices.
It would be a user mistake to allow individual PCIe functions with
different ASPM policies. (maybe, we should enforce it if we are not
doing it already).
next prev parent reply other threads:[~2018-07-29 0:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 23:01 [PATCH] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG Rajat Jain
2018-05-09 6:46 ` okaya
2018-05-09 9:43 ` kbuild test robot
2018-05-10 23:34 ` [PATCH] PM / s2idle: Clear the events_check_enabled flag Rajat Jain
2018-05-10 23:36 ` Rajat Jain
2018-05-10 23:39 ` [PATCH v2] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG Rajat Jain
2018-06-05 22:15 ` Rajat Jain
2018-06-09 23:49 ` Sinan Kaya
2018-06-29 23:27 ` Bjorn Helgaas
2018-07-27 20:26 ` Bjorn Helgaas
2018-07-27 21:03 ` Takashi Iwai
2018-07-29 0:16 ` Sinan Kaya [this message]
2018-07-30 14:14 ` Bjorn Helgaas
2018-07-30 16:08 ` Sinan Kaya
2018-07-30 8:32 ` Lukas Wunner
2018-07-30 17:26 ` Bjorn Helgaas
2018-07-30 16:18 ` Rajat Jain
2018-07-31 8:13 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a102163-73bc-c596-8266-186e222e7ceb@kernel.org \
--to=okaya@kernel.org \
--cc=apw@canonical.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhelgaas@google.com \
--cc=cgarnach@redhat.com \
--cc=colin.king@canonical.com \
--cc=fred@fredlawl.com \
--cc=garsilva@embeddedor.com \
--cc=helgaas@kernel.org \
--cc=keescook@chromium.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mayurkumar.patel@intel.com \
--cc=okaya@codeaurora.org \
--cc=pali.rohar@gmail.com \
--cc=pombredanne@nexb.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=rhughes@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).