From: Rajat Jain <rajatja@google.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dtor@google.com>,
Rajat Jain <rajatxjain@gmail.com>
Cc: Rajat Jain <rajatja@google.com>
Subject: Re: [PATCH] PM / s2idle: Clear the events_check_enabled flag
Date: Thu, 10 May 2018 16:36:38 -0700 [thread overview]
Message-ID: <CACK8Z6H_3VZFaUG02i5w_9GQnQRqto87X3YEg051xbtaXd5jqg@mail.gmail.com> (raw)
In-Reply-To: <20180510233426.94514-1-rajatja@google.com>
Sorry, please ignore, sent by mistake.
On Thu, May 10, 2018 at 4:34 PM, Rajat Jain <rajatja@google.com> wrote:
> Problem: This flag does not get cleared currently in the suspend or
> resume path in the following cases:
>
> * In case some driver's suspend routine returns an error.
> * Successful s2idle case
> * etc?
>
> Why is this a problem: What happens is that the next suspend attempt
> could fail even though the user did not enable the flag by writing to
> /sys/power/wakeup_count. This is 1 use case how the issue can be seen
> (but similar use case with driver suspend failure can be thought of):
>
> 1. Read /sys/power/wakeup_count
> 2. echo count > /sys/power/wakeup_count
> 3. echo freeze > /sys/power/wakeup_count
> 4. Let the system suspend, and wakeup the system using some wake source
> that calls pm_wakeup_event() e.g. power button or something.
> 5. Note that the combined wakeup count would be incremented due
> to the pm_wakeup_event() in the resume path.
> 6. After resuming the events_check_enabled flag is still set.
>
> At this point if the user attempts to freeze again (without writing to
> /sys/power/wakeup_count), the suspend would fail even though there has
> been no wake event since the past resume.
>
> What this patch does:
>
> It moves the clearing of the flag to just before a resume is completed,
> so that it is always cleared for the corner cases mentioned above.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> kernel/power/suspend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index ccd2d20e6b06..0685c4499431 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -437,7 +437,6 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
> error = suspend_ops->enter(state);
> trace_suspend_resume(TPS("machine_suspend"),
> state, false);
> - events_check_enabled = false;
> } else if (*wakeup) {
> error = -EBUSY;
> }
> @@ -582,6 +581,7 @@ static int enter_state(suspend_state_t state)
> pm_restore_gfp_mask();
>
> Finish:
> + events_check_enabled = false;
> pm_pr_dbg("Finishing wakeup.\n");
> suspend_finish();
> Unlock:
> --
> 2.15.0.403.gc27cc4dac6-goog
>
next prev parent reply other threads:[~2018-05-10 23:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 23:01 [PATCH] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG Rajat Jain
2018-05-09 6:46 ` okaya
2018-05-09 9:43 ` kbuild test robot
2018-05-10 23:34 ` [PATCH] PM / s2idle: Clear the events_check_enabled flag Rajat Jain
2018-05-10 23:36 ` Rajat Jain [this message]
2018-05-10 23:39 ` [PATCH v2] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG Rajat Jain
2018-06-05 22:15 ` Rajat Jain
2018-06-09 23:49 ` Sinan Kaya
2018-06-29 23:27 ` Bjorn Helgaas
2018-07-27 20:26 ` Bjorn Helgaas
2018-07-27 21:03 ` Takashi Iwai
2018-07-29 0:16 ` Sinan Kaya
2018-07-30 14:14 ` Bjorn Helgaas
2018-07-30 16:08 ` Sinan Kaya
2018-07-30 8:32 ` Lukas Wunner
2018-07-30 17:26 ` Bjorn Helgaas
2018-07-30 16:18 ` Rajat Jain
2018-07-31 8:13 ` Pali Rohár
-- strict thread matches above, loose matches on Subject: below --
2017-10-31 21:44 [PATCH] PM / s2idle: Clear the events_check_enabled flag Rajat Jain
2017-11-06 11:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACK8Z6H_3VZFaUG02i5w_9GQnQRqto87X3YEg051xbtaXd5jqg@mail.gmail.com \
--to=rajatja@google.com \
--cc=dtor@google.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rajatxjain@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).