From: Thara Gopinath <thara.gopinath@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 1/9] drivers: thermal: tsens: Add VER_0 tsens version
Date: Fri, 19 Mar 2021 10:11:21 -0400 [thread overview]
Message-ID: <8850c559-45cb-45cd-9d39-287b8c041c79@linaro.org> (raw)
In-Reply-To: <YFSm5rz3ivnzxoJ4@Ansuel-xps.localdomain>
On 3/19/21 9:28 AM, Ansuel Smith wrote:
> On Fri, Mar 19, 2021 at 09:11:38AM -0400, Thara Gopinath wrote:
>>
>>
>> On 3/18/21 8:52 PM, Ansuel Smith wrote:
>>> VER_0 is used to describe device based on tsens version before v0.1.
>>> These device are devices based on msm8960 for example apq8064 or
>>> ipq806x.
>>
>> Hi Ansuel,
>>
>> There are still checkpatch check warnings in this patch. Please run
>> checkpatch.pl --strict and fix them. Once that is done, you can add
>>
>> Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
>>
>> Warm Regards
>> Thara
>>
>
> Hi,
> thanks a lot for the review. The only warning I have is a line ending
> with ( that i think I can't fix or I will go over the max char for line.
> Do you have something more?
I see two warning for line ending with (. The max char limit is 100.
--
Warm Regards
Thara
next prev parent reply other threads:[~2021-03-19 14:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 0:52 [PATCH v11 0/9] Add support for ipq8064 tsens Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 1/9] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2021-03-19 13:11 ` Thara Gopinath
2021-03-19 13:28 ` Ansuel Smith
2021-03-19 14:11 ` Thara Gopinath [this message]
2021-03-19 0:52 ` [PATCH v11 2/9] drivers: thermal: tsens: Don't hardcode sensor slope Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 3/9] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 4/9] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 5/9] drivers: thermal: tsens: Fix bug in sensor enable " Ansuel Smith
2021-03-19 13:11 ` Thara Gopinath
2021-03-22 10:47 ` Marc Gonzalez
2021-03-19 0:52 ` [PATCH v11 6/9] drivers: thermal: tsens: Replace custom 8960 apis with generic apis Ansuel Smith
2021-03-19 13:12 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 7/9] drivers: thermal: tsens: Drop unused define for msm8960 Ansuel Smith
2021-03-19 13:12 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 8/9] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 9/9] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8850c559-45cb-45cd-9d39-287b8c041c79@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).