From: Joel Stanley <joel@jms.id.au>
To: Potin Lai <potin.lai@quantatw.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
Patrick Williams <patrick@stwcx.xyz>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/10] update Facebook Bletchley BMC
Date: Tue, 15 Feb 2022 05:51:29 +0000 [thread overview]
Message-ID: <CACPK8Xcs7y2d9AGfizv9+Lr_Ri3gaq2gmwXMFt=04z7s9XmAMg@mail.gmail.com> (raw)
In-Reply-To: <20220214042538.12132-1-potin.lai@quantatw.com>
On Mon, 14 Feb 2022 at 04:26, Potin Lai <potin.lai@quantatw.com> wrote:
>
> This patch series update Facebook Bletchley BMC devicetree base on EVT HW
> schematioc design, and rebase SLED numbering to 1-based for OpenBMC
> multi-host.
>
> - GPIO:
> - adding more gpio line names
> - include interrupt line in io expander for gpio interrupt monitoring
>
> - SPI flash:
> - adding dual flash BSM module support
> - switch to spi2-gpio on spi2 due to unstable signal issue
>
> - Hwmon Sensors:
> - adding INA230 sensors for monitoring
> - fix ADM1278 shunt-resistor
>
> - MDIO Bus: enable mido3 bus
>
> - RTC: switch to external battery-backed rtc
>
> - OpenBMC: 1-based SLED numbering
>
>
> LINK: [v1] https://lore.kernel.org/all/20220211014347.24841-1-potin.lai@quantatw.com/
>
>
> Changes v1 --> v2:
> - update the details of new added gpio line names in commit message
> - add battery-backed rtc information in comment and commit message
Looks good. I made some comments on the spi2 patch, please fix those
up and I will merge.
Note that the convention for patch names is:
ARM: dts: aspeed: bletchley: Description with sentence case
If you could update your patches to follow that it would be appreciated.
There's no need to re-send your series for the openbmc tree; I can
merge those once we've reviewed the ones for mainline.
Cheers,
Joel
>
> Potin Lai (10):
> arch: arm: dts: bletchley: switch sled numbering to 1-based
> arch: arm: dts: bletchley: separate leds into multiple groups
> arch: arm: dts: bletchley: update gpio-line-names
> arch: arm: dts: bletchley: update fmc configurations
> arch: arm: dts: bletchley: switch to spi-gpio for spi2
> arch: arm: dts: bletchley: add interrupt support for sled io expander
> arch: arm: dts: bletchley: add shunt-resistor for ADM1278
> arch: arm: dts: bletchley: add INA230 sensor on each sled
> arch: arm: dts: bletchley: enable mdio3 bus
> arch: arm: dts: bletchley: cleanup redundant nodes
>
> .../dts/aspeed-bmc-facebook-bletchley.dts | 303 +++++++++++-------
> 1 file changed, 194 insertions(+), 109 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2022-02-15 5:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 4:25 [PATCH v2 00/10] update Facebook Bletchley BMC Potin Lai
2022-02-14 4:25 ` [PATCH v2 01/10] arch: arm: dts: bletchley: switch sled numbering to 1-based Potin Lai
2022-02-14 4:25 ` [PATCH v2 02/10] arch: arm: dts: bletchley: separate leds into multiple groups Potin Lai
2022-02-14 4:25 ` [PATCH v2 03/10] arch: arm: dts: bletchley: update gpio-line-names Potin Lai
2022-02-14 4:25 ` [PATCH v2 04/10] arch: arm: dts: bletchley: update fmc configurations Potin Lai
2022-02-14 4:25 ` [PATCH v2 05/10] arch: arm: dts: bletchley: switch to spi-gpio for spi2 Potin Lai
2022-02-15 5:48 ` Joel Stanley
2022-02-14 4:25 ` [PATCH v2 06/10] arch: arm: dts: bletchley: add interrupt support for sled io expander Potin Lai
2022-02-14 4:25 ` [PATCH v2 07/10] arch: arm: dts: bletchley: add shunt-resistor for ADM1278 Potin Lai
2022-02-14 4:25 ` [PATCH v2 08/10] arch: arm: dts: bletchley: add INA230 sensor on each sled Potin Lai
2022-02-14 4:25 ` [PATCH v2 09/10] arch: arm: dts: bletchley: enable mdio3 bus Potin Lai
2022-02-14 4:25 ` [PATCH v2 10/10] arch: arm: dts: bletchley: cleanup redundant nodes Potin Lai
2022-02-14 18:27 ` [PATCH v2 00/10] update Facebook Bletchley BMC Patrick Williams
2022-02-15 5:51 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xcs7y2d9AGfizv9+Lr_Ri3gaq2gmwXMFt=04z7s9XmAMg@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).