From: Rakib Mullick <rakib.mullick@gmail.com>
To: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
kosaki.motohiro@gmail.com, mingo@elte.hu
Subject: Re: [tip:sched/urgent] sched: Fix rq->nr_uninterruptible update race
Date: Fri, 27 Jan 2012 11:20:56 +0600 [thread overview]
Message-ID: <CADZ9YHi1=aP8j8vCFJvyMANyMWwB_mjT67KwSZZh902oyWy7pA@mail.gmail.com> (raw)
In-Reply-To: <tip-4ca9b72b71f10147bd21969c1805f5b2c4ca7b7b@git.kernel.org>
On Fri, Jan 27, 2012 at 2:25 AM, tip-bot for Peter Zijlstra
<a.p.zijlstra@chello.nl> wrote:
> Commit-ID: 4ca9b72b71f10147bd21969c1805f5b2c4ca7b7b
> Gitweb: http://git.kernel.org/tip/4ca9b72b71f10147bd21969c1805f5b2c4ca7b7b
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> AuthorDate: Wed, 25 Jan 2012 11:50:51 +0100
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Thu, 26 Jan 2012 19:38:09 +0100
>
> sched: Fix rq->nr_uninterruptible update race
>
> KOSAKI Motohiro noticed the following race:
>
> > CPU0 CPU1
> > --------------------------------------------------------
> > deactivate_task()
> > task->state = TASK_UNINTERRUPTIBLE;
> > activate_task()
> > rq->nr_uninterruptible--;
> >
> > schedule()
> > deactivate_task()
> > rq->nr_uninterruptible++;
> >
>
> Kosaki-San's scenario is possible when CPU0 runs
> __sched_setscheduler() against CPU1's current @task.
>
> __sched_setscheduler() does a dequeue/enqueue in order to move
> the task to its new queue (position) to reflect the newly provided
> scheduling parameters. However it should be completely invariant to
> nr_uninterruptible accounting, sched_setscheduler() doesn't affect
> readyness to run, merely policy on when to run.
>
> So convert the inappropriate activate/deactivate_task usage to
> enqueue/dequeue_task, which avoids the nr_uninterruptible accounting.
>
Why would we want to avoid nr_uninterruptible accounting?
nr_uninterruptible has impact on load calculation, we might not get
the proper load weight if we don't account it. isn't it?
Thanks,
Rakib
next prev parent reply other threads:[~2012-01-27 5:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 0:42 [BUG] TASK_DEAD task is able to be woken up in special condition Yasunori Goto
2011-12-22 2:14 ` KOSAKI Motohiro
2011-12-22 8:22 ` Yasunori Goto
2011-12-22 20:02 ` KOSAKI Motohiro
2011-12-23 9:49 ` Peter Zijlstra
2011-12-23 15:41 ` Oleg Nesterov
2011-12-26 8:23 ` Yasunori Goto
2011-12-26 17:11 ` Oleg Nesterov
2011-12-27 6:48 ` Yasunori Goto
2012-01-06 10:22 ` Yasunori Goto
2012-01-06 11:01 ` Peter Zijlstra
2012-01-06 12:01 ` Yasunori Goto
2012-01-06 12:43 ` Peter Zijlstra
2012-01-06 14:12 ` Oleg Nesterov
2012-01-06 14:19 ` Oleg Nesterov
2012-01-07 1:31 ` Yasunori Goto
2012-01-16 11:51 ` Yasunori Goto
2012-01-16 13:38 ` Peter Zijlstra
2012-01-17 8:40 ` Yasunori Goto
2012-01-17 9:06 ` Ingo Molnar
2012-01-17 15:12 ` Oleg Nesterov
2012-01-18 9:42 ` Ingo Molnar
2012-01-18 14:20 ` Oleg Nesterov
2012-01-24 10:19 ` Peter Zijlstra
2012-01-24 10:55 ` Peter Zijlstra
2012-01-24 17:25 ` KOSAKI Motohiro
2012-01-25 15:45 ` Oleg Nesterov
2012-01-25 16:51 ` Peter Zijlstra
2012-01-25 17:43 ` Oleg Nesterov
2012-01-26 15:32 ` Peter Zijlstra
2012-01-26 16:26 ` Oleg Nesterov
2012-01-27 8:59 ` Peter Zijlstra
2012-01-24 10:11 ` Peter Zijlstra
2012-01-26 9:39 ` Ingo Molnar
2012-01-28 12:03 ` [tip:sched/core] sched: Fix ancient race in do_exit() tip-bot for Yasunori Goto
2012-01-28 21:12 ` Linus Torvalds
2012-01-29 16:07 ` Oleg Nesterov
2012-01-29 17:44 ` Linus Torvalds
2012-01-29 18:28 ` Linus Torvalds
2012-01-29 18:59 ` Oleg Nesterov
2012-01-30 16:27 ` Linus Torvalds
2012-01-06 13:48 ` [BUG] TASK_DEAD task is able to be woken up in special condition Oleg Nesterov
2011-12-28 21:07 ` KOSAKI Motohiro
2012-01-24 10:23 ` Peter Zijlstra
2012-01-24 18:01 ` KOSAKI Motohiro
2012-01-25 6:15 ` Mike Galbraith
2012-01-26 21:24 ` KOSAKI Motohiro
2012-01-25 10:10 ` Peter Zijlstra
2012-01-26 20:25 ` [tip:sched/urgent] sched: Fix rq->nr_uninterruptible update race tip-bot for Peter Zijlstra
2012-01-27 5:20 ` Rakib Mullick [this message]
2012-01-27 8:19 ` Peter Zijlstra
2012-01-27 14:11 ` Rakib Mullick
2012-01-26 21:21 ` [BUG] TASK_DEAD task is able to be woken up in special condition KOSAKI Motohiro
2012-01-27 8:21 ` Peter Zijlstra
2011-12-26 6:52 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADZ9YHi1=aP8j8vCFJvyMANyMWwB_mjT67KwSZZh902oyWy7pA@mail.gmail.com' \
--to=rakib.mullick@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).