From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [RESEND PATCH v6 06/11] mfd: max77650: new core mfd driver
Date: Tue, 26 Mar 2019 14:49:24 +0100 [thread overview]
Message-ID: <CAMRc=Me1BbZKPQyAt4RR1eRk9pX3oHFudpm1CnHx3-AuD-G5ug@mail.gmail.com> (raw)
In-Reply-To: <20190322091223.GI27015@amd>
pt., 22 mar 2019 o 10:12 Pavel Machek <pavel@ucw.cz> napisał(a):
>
> On Mon 2019-03-18 18:42:23, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Add the core mfd driver for max77650 PMIC. We define five sub-devices
> > for which the drivers will be added in subsequent patches.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> > drivers/mfd/Kconfig | 14 +++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/max77650.c | 234 +++++++++++++++++++++++++++++++++++
> > include/linux/mfd/max77650.h | 59 +++++++++
> > 4 files changed, 308 insertions(+)
> > create mode 100644 drivers/mfd/max77650.c
> > create mode 100644 include/linux/mfd/max77650.h
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 0ce2d8dfc5f1..ade04e124aa0 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -733,6 +733,20 @@ config MFD_MAX77620
> > provides common support for accessing the device; additional drivers
> > must be enabled in order to use the functionality of the device.
> >
> > +config MFD_MAX77650
> > + tristate "Maxim MAX77650/77651 PMIC Support"
> > + depends on I2C
> > + depends on OF || COMPILE_TEST
>
> This says it will compile ok in !OF case. Will it?
>
It will compile because the stubs for OF functions will be provided -
it just won't work, because they won't be implemented.
Bart
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2019-03-26 13:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:42 [RESEND PATCH v6 00/11] mfd: add support for max77650 PMIC Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 01/11] dt-bindings: mfd: add DT bindings for max77650 Bartosz Golaszewski
2019-04-02 7:25 ` Lee Jones
2019-03-18 17:42 ` [RESEND PATCH v6 02/11] dt-bindings: power: supply: " Bartosz Golaszewski
2019-03-25 20:46 ` Rob Herring
2019-03-18 17:42 ` [RESEND PATCH v6 03/11] dt-bindings: leds: " Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 04/11] dt-bindings: input: " Bartosz Golaszewski
2019-03-22 9:09 ` Pavel Machek
2019-03-22 9:55 ` Bartosz Golaszewski
2019-03-22 9:59 ` Pavel Machek
2019-03-18 17:42 ` [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices() Bartosz Golaszewski
2019-03-22 9:10 ` Pavel Machek
2019-04-02 7:41 ` Lee Jones
2019-04-02 8:08 ` Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 06/11] mfd: max77650: new core mfd driver Bartosz Golaszewski
2019-03-22 9:12 ` Pavel Machek
2019-03-26 13:49 ` Bartosz Golaszewski [this message]
2019-03-18 17:42 ` [RESEND PATCH v6 07/11] power: supply: max77650: add support for battery charger Bartosz Golaszewski
2019-04-04 3:45 ` Linus Walleij
2019-03-18 17:42 ` [RESEND PATCH v6 08/11] gpio: max77650: add GPIO support Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 09/11] leds: max77650: add LEDs support Bartosz Golaszewski
2019-03-22 9:21 ` Pavel Machek
2019-03-22 9:53 ` Bartosz Golaszewski
2019-03-22 19:40 ` Jacek Anaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 10/11] input: max77650: add onkey support Bartosz Golaszewski
2019-03-22 9:18 ` Pavel Machek
2019-03-18 17:42 ` [RESEND PATCH v6 11/11] MAINTAINERS: add an entry for max77650 mfd driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Me1BbZKPQyAt4RR1eRk9pX3oHFudpm1CnHx3-AuD-G5ug@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).