Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

[Bartosz Golaszewski <brgl@bgdev.pl>]

pt., 22 mar 2019 o 10:21 Pavel Machek <pavel@ucw.cz> napisał(a):
>
> On Mon 2019-03-18 18:42:26, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > This adds basic support for LEDs for the max77650 PMIC. The device has
> > three current sinks for driving LEDs.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> > +             label = of_get_property(child, "label", NULL);
> > +             if (!label) {
> > +                     led->cdev.name = "max77650::";
> > +             } else {
> > +                     led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
> > +                                                     "max77650:%s", label);
> > +                     if (!led->cdev.name)
> > +                             return -ENOMEM;
> > +             }
>
> I'd rather not have the "max77650:" prefix in the LED name (as it is
> useless).
>

I was instructed to do so by the LED subsystem maintainer.

Bart

> Best regards,
>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html