From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices()
Date: Tue, 2 Apr 2019 10:08:59 +0200 [thread overview]
Message-ID: <CAMRc=Mekomya5A_tj3RKSeno1EaBoGNAFJajPfyB1cHP7c+L6w@mail.gmail.com> (raw)
In-Reply-To: <20190402074103.GG4187@dell>
wt., 2 kwi 2019 o 09:41 Lee Jones <lee.jones@linaro.org> napisał(a):
>
> On Mon, 18 Mar 2019, Bartosz Golaszewski wrote:
>
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Add a kernel doc for mfd_add_devices().
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> > drivers/mfd/mfd-core.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> > index 94e3f32ce935..0898a8db1747 100644
> > --- a/drivers/mfd/mfd-core.c
> > +++ b/drivers/mfd/mfd-core.c
> > @@ -269,6 +269,20 @@ static int mfd_add_device(struct device *parent, int id,
> > return ret;
> > }
> >
> > +/**
> > + * mfd_add_devices - register a set of child devices
>
> "register child devices"
>
> > + *
> > + * @parent: Parent device for all sub-nodes.
> > + * @id: Platform device id. If >= 0, each sub-device will have its cell_id
> > + * added to this number and use it as the platform device id.
> > + * @cells: Array of mfd cells describing sub-devices.
> > + * @n_devs: Number of sub-devices to register.
> > + * @mem_base: Parent register range resource for sub-devices.
> > + * @irq_base: Base of the range of virtual interrupt numbers allocated for
> > + * this MFD device. Unused if @domain is specified.
> > + * @domain: Interrupt domain used to create mappings for HW interrupt numbers
> > + * specificed in sub-devices' IRQ resources.
>
> Spelling.
>
> > + */
> > int mfd_add_devices(struct device *parent, int id,
> > const struct mfd_cell *cells, int n_devs,
> > struct resource *mem_base,
>
> How about this:
>
> /**
> * mfd_add_devices - register child devices
> *
> * @parent: Pointer to parent device.
> * @id: Can be PLATFORM_DEVID_AUTO to let the Platform API take care
> * of device numbering, or will be added to a device's cell_id.
> * @cells: Array of (struct mfd_cell)s describing child devices.
> * @n_devs: Number of child devices to register.
> * @mem_base: Parent register range resource for child devices.
> * @irq_base: Base of the range of virtual interrupt numbers allocated for
> * this MFD device. Unused if @domain is specified.
> * @domain: Interrupt domain to create mappings for hardware interrupts.
> */
>
Sure, looks good to me.
FYI the latest version of this series is v7, but the mfd driver didn't
change since v6.
Bart
next prev parent reply other threads:[~2019-04-02 8:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:42 [RESEND PATCH v6 00/11] mfd: add support for max77650 PMIC Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 01/11] dt-bindings: mfd: add DT bindings for max77650 Bartosz Golaszewski
2019-04-02 7:25 ` Lee Jones
2019-03-18 17:42 ` [RESEND PATCH v6 02/11] dt-bindings: power: supply: " Bartosz Golaszewski
2019-03-25 20:46 ` Rob Herring
2019-03-18 17:42 ` [RESEND PATCH v6 03/11] dt-bindings: leds: " Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 04/11] dt-bindings: input: " Bartosz Golaszewski
2019-03-22 9:09 ` Pavel Machek
2019-03-22 9:55 ` Bartosz Golaszewski
2019-03-22 9:59 ` Pavel Machek
2019-03-18 17:42 ` [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices() Bartosz Golaszewski
2019-03-22 9:10 ` Pavel Machek
2019-04-02 7:41 ` Lee Jones
2019-04-02 8:08 ` Bartosz Golaszewski [this message]
2019-03-18 17:42 ` [RESEND PATCH v6 06/11] mfd: max77650: new core mfd driver Bartosz Golaszewski
2019-03-22 9:12 ` Pavel Machek
2019-03-26 13:49 ` Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 07/11] power: supply: max77650: add support for battery charger Bartosz Golaszewski
2019-04-04 3:45 ` Linus Walleij
2019-03-18 17:42 ` [RESEND PATCH v6 08/11] gpio: max77650: add GPIO support Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 09/11] leds: max77650: add LEDs support Bartosz Golaszewski
2019-03-22 9:21 ` Pavel Machek
2019-03-22 9:53 ` Bartosz Golaszewski
2019-03-22 19:40 ` Jacek Anaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 10/11] input: max77650: add onkey support Bartosz Golaszewski
2019-03-22 9:18 ` Pavel Machek
2019-03-18 17:42 ` [RESEND PATCH v6 11/11] MAINTAINERS: add an entry for max77650 mfd driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mekomya5A_tj3RKSeno1EaBoGNAFJajPfyB1cHP7c+L6w@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).