From: Gabriele Paoloni <gabriele.paoloni@huawei.com>
To: Sinan Kaya <okaya@codeaurora.org>,
"liudongdong (C)" <liudongdong3@huawei.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
"Lorenzo.Pieralisi@arm.com" <Lorenzo.Pieralisi@arm.com>,
"jchandra@broadcom.com" <jchandra@broadcom.com>,
"tn@semihalf.com" <tn@semihalf.com>
Cc: "robert.richter@caviumnetworks.com"
<robert.richter@caviumnetworks.com>,
"mw@semihalf.com" <mw@semihalf.com>,
"Liviu.Dudau@arm.com" <Liviu.Dudau@arm.com>,
"ddaney@caviumnetworks.com" <ddaney@caviumnetworks.com>,
Wangyijing <wangyijing@huawei.com>,
"Suravee.Suthikulpanit@amd.com" <Suravee.Suthikulpanit@amd.com>,
"msalter@redhat.com" <msalter@redhat.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"jcm@redhat.com" <jcm@redhat.com>,
"andrea.gallo@linaro.org" <andrea.gallo@linaro.org>,
"dhdang@apm.com" <dhdang@apm.com>,
"jeremy.linton@arm.com" <jeremy.linton@arm.com>,
"cov@codeaurora.org" <cov@codeaurora.org>,
"Chenxin (Charles)" <charles.chenxin@huawei.com>,
Linuxarm <linuxarm@huawei.com>
Subject: RE: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks
Date: Mon, 13 Jun 2016 14:29:01 +0000 [thread overview]
Message-ID: <EE11001F9E5DDD47B7634E2F8A612F2E1F782E15@lhreml507-mbx> (raw)
In-Reply-To: <575EBD13.8080808@codeaurora.org>
Hi Sinan
> -----Original Message-----
> From: Sinan Kaya [mailto:okaya@codeaurora.org]
> Sent: 13 June 2016 15:03
> To: Gabriele Paoloni; liudongdong (C); helgaas@kernel.org;
> arnd@arndb.de; will.deacon@arm.com; catalin.marinas@arm.com;
> rafael@kernel.org; hanjun.guo@linaro.org; Lorenzo.Pieralisi@arm.com;
> jchandra@broadcom.com; tn@semihalf.com
> Cc: robert.richter@caviumnetworks.com; mw@semihalf.com;
> Liviu.Dudau@arm.com; ddaney@caviumnetworks.com; Wangyijing;
> Suravee.Suthikulpanit@amd.com; msalter@redhat.com; linux-
> pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro-
> acpi@lists.linaro.org; jcm@redhat.com; andrea.gallo@linaro.org;
> dhdang@apm.com; jeremy.linton@arm.com; cov@codeaurora.org; Chenxin
> (Charles); Linuxarm
> Subject: Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space
> accessors against platfrom specific ECAM quirks
>
> On 6/13/2016 9:54 AM, Gabriele Paoloni wrote:
> > As you can see here Liudongdong has replaced oem_revision with
> > oem_table_id.
> >
> > Now it seems that there are some platforms that have already shipped
> > using a matching based on the oem_revision (right Jon?)
> >
> > However I guess that if in FW they have defined oem_table_id properly
> > they should be able to use this mechanism without needing to a FW
> update.
> >
> > Can these vendors confirm this?
> >
> > Tomasz do you think this can work for Cavium Thunder?
> >
> > Thanks
> >
> > Gab
>
> Why not have all three of them?
>
> The initial approach was OEM id and revision id.
>
> Jeff Hugo indicated that addition (not removing any other fields) of
> table id
> would make more sense.
Mmm from last email of Jeff Hugo on "[RFC PATCH 1/3] pci, acpi: Match
PCI config space accessors against platfrom specific ECAM quirks."
I quote:
"Using the OEM revision
field does not seem to be appropriate since these are different
platforms and the revision field appears to be for the purpose of
tracking differences within a single platform. Therefore, Cov is
proposing using the OEM table id as a mechanism to distinguish
platform A (needs quirk applied) vs platform B (no quirks) from the
same OEM."
So it looks to me that he pointed out that using the OEM revision field
is wrong...and this is why I have asked if replacing it with the table
id can work for other vendors....
Thanks
Gab
>
> --
> Sinan Kaya
> Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center,
> Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
> Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-06-13 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 13:02 [RFC PATCH V2 0/2] ECAM quirks handling for ARM64 platforms Dongdong Liu
2016-06-13 13:02 ` [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Dongdong Liu
2016-06-13 13:54 ` Gabriele Paoloni
2016-06-13 14:02 ` Sinan Kaya
2016-06-13 14:29 ` Gabriele Paoloni [this message]
2016-06-13 15:12 ` okaya
2016-06-13 15:59 ` Jeffrey Hugo
2016-06-13 21:07 ` Duc Dang
2016-06-16 6:31 ` [Linaro-acpi] " Jon Masters
2016-06-16 7:45 ` Duc Dang
2016-06-16 7:54 ` Jon Masters
2016-06-13 15:47 ` Christopher Covington
2016-06-13 20:57 ` Duc Dang
2016-06-14 5:51 ` Dongdong Liu
2016-06-14 9:00 ` Duc Dang
2016-06-14 9:45 ` Dongdong Liu
2016-06-14 11:52 ` Tomasz Nowicki
2016-06-14 17:43 ` Duc Dang
2016-06-13 13:02 ` [RFC PATCH V2 2/2] ARM64/PCI: Start using quirks handling for ACPI based PCI host controller Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE11001F9E5DDD47B7634E2F8A612F2E1F782E15@lhreml507-mbx \
--to=gabriele.paoloni@huawei.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=andrea.gallo@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=charles.chenxin@huawei.com \
--cc=cov@codeaurora.org \
--cc=ddaney@caviumnetworks.com \
--cc=dhdang@apm.com \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jchandra@broadcom.com \
--cc=jcm@redhat.com \
--cc=jeremy.linton@arm.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=msalter@redhat.com \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=robert.richter@caviumnetworks.com \
--cc=tn@semihalf.com \
--cc=wangyijing@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).