From: Matthias Kaehlcke <mka@chromium.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sboyd@codeaurora.org, dianders@chromium.org,
kgodara@codeaurora.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom: Document qcom,sc7280-crd board
Date: Tue, 23 Nov 2021 06:53:25 -0800 [thread overview]
Message-ID: <YZ0AZQDB6VPUAt8s@google.com> (raw)
In-Reply-To: <1637650813-16654-2-git-send-email-rnayak@codeaurora.org>
On Tue, Nov 23, 2021 at 12:30:10PM +0530, Rajendra Nayak wrote:
> Document the qcom,sc7280-crd board based off sc7280 SoC,
> The board is also known as hoglin in the Chrome OS builds,
> and given there would be multiple (at least one more) rev
> of this board document the google,hoglin-rev0 compatible as well.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index c8808e0..2abfd28 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -203,6 +203,8 @@ properties:
> - enum:
> - qcom,sc7280-idp
> - qcom,sc7280-idp2
> + - qcom,sc7280-crd
> + - google,hoglin-rev0
I think we also want the generic 'google,hoglin' compatible string, analogous to
for example 'google,lazor' and 'google,lazor-revN'. For lazor there are no
explicit compatible entries for rev3 and above, there were no DT relevant
hardware changes for rev > 3, hence the 'google,lazor' compatible string is
used, without the need to modify the DT for each new HW revision.
Also on my CRD the bootloader thinks it is running on a rev4:
Compat preference: google,hoglin-rev4 google,hoglin
The board still boots thanks to the 'google,hoglin' entry in my device tree,
but it seems you need to add more revN entries, or start with rev4 if you
don't really care about supporting older revisions. In the later case you
coul only have 'google,hoglin' for now, and add 'rev4' when you add support
for the next revision (supposing it has DT relevant hardware changes). The
sc7180-trogdor boards can serve as an example on how to deal with board
revisions.
next prev parent reply other threads:[~2021-11-23 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 7:00 [PATCH 0/4] arm64: dts: qcom: Add support for the sc7280 CRD board Rajendra Nayak
2021-11-23 7:00 ` [PATCH 1/4] dt-bindings: arm: qcom: Document qcom,sc7280-crd board Rajendra Nayak
2021-11-23 14:53 ` Matthias Kaehlcke [this message]
2021-11-24 11:47 ` Rajendra Nayak
2021-11-23 7:00 ` [PATCH 2/4] arm64: dts: qcom: sc7280-crd: Add device tree files for CRD Rajendra Nayak
2021-11-23 16:14 ` Matthias Kaehlcke
2021-11-24 11:48 ` Rajendra Nayak
2021-11-23 7:00 ` [PATCH 3/4] arm64: dts: qcom: sc7280: Define EC and H1 nodes Rajendra Nayak
2021-11-23 17:40 ` Matthias Kaehlcke
2021-11-24 11:48 ` Rajendra Nayak
2021-11-23 7:00 ` [PATCH 4/4] arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support Rajendra Nayak
2021-11-23 17:58 ` Matthias Kaehlcke
2021-11-24 11:49 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ0AZQDB6VPUAt8s@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgodara@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).