From: Rajendra Nayak <rnayak@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sboyd@codeaurora.org, dianders@chromium.org,
kgodara@codeaurora.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc7280-crd: Add device tree files for CRD
Date: Wed, 24 Nov 2021 17:18:12 +0530 [thread overview]
Message-ID: <d333bf45-e9e9-18e8-4c6d-deec7a7385a5@codeaurora.org> (raw)
In-Reply-To: <YZ0TSeXddm+qGJ0/@google.com>
On 11/23/2021 9:44 PM, Matthias Kaehlcke wrote:
> On Tue, Nov 23, 2021 at 12:30:11PM +0530, Rajendra Nayak wrote:
>> CRD (Compute Reference Design) is a sc7280 based board, largely
>> derived from the existing IDP board design with some key deltas
>> 1. has EC and H1 over SPI similar to IDP2
>> 2. touchscreen and trackpad support
>> 3. eDP display
>>
>> We just add the barebones dts file here, subsequent patches will
>> add support for EC/H1 and other components.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 31 +++++++++++++++++++++++++++++++
>> 2 files changed, 32 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-crd.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 6b816eb..b18708c 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
>> new file mode 100644
>> index 0000000..09d02c2
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
>> @@ -0,0 +1,31 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * sc7280 CRD board device tree source
>> + *
>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "sc7280-idp.dtsi"
>> +
>> +/ {
>> + model = "Qualcomm Technologies, Inc. sc7280 CRD platform";
>> + compatible = "qcom,sc7280-crd", "google,hoglin-rev0", "qcom,sc7280";
>
> As per my comment on the binding there should also be a "google,hoglin"
> without a revision suffix, also it seems there are already CRDs with higher
> rev numbers.
right i will remove the -revs for now.
>
>> +
>> + aliases {
>> + serial0 = &uart5;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0:115200n8";
>> + };
>> +};
>> +
>> +&nvme_pwren {
>> + pins = "gpio51";
>> +};
>> +
>> +&nvme_3v3_regulator {
>> + gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>;
>> +};
>
> uber-nit: 'nvme_3v3_regulator' should be before 'nvme_pwren', assuming
> alphabetical/ASCII ordering is used.
thanks will fix
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-11-24 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 7:00 [PATCH 0/4] arm64: dts: qcom: Add support for the sc7280 CRD board Rajendra Nayak
2021-11-23 7:00 ` [PATCH 1/4] dt-bindings: arm: qcom: Document qcom,sc7280-crd board Rajendra Nayak
2021-11-23 14:53 ` Matthias Kaehlcke
2021-11-24 11:47 ` Rajendra Nayak
2021-11-23 7:00 ` [PATCH 2/4] arm64: dts: qcom: sc7280-crd: Add device tree files for CRD Rajendra Nayak
2021-11-23 16:14 ` Matthias Kaehlcke
2021-11-24 11:48 ` Rajendra Nayak [this message]
2021-11-23 7:00 ` [PATCH 3/4] arm64: dts: qcom: sc7280: Define EC and H1 nodes Rajendra Nayak
2021-11-23 17:40 ` Matthias Kaehlcke
2021-11-24 11:48 ` Rajendra Nayak
2021-11-23 7:00 ` [PATCH 4/4] arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support Rajendra Nayak
2021-11-23 17:58 ` Matthias Kaehlcke
2021-11-24 11:49 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d333bf45-e9e9-18e8-4c6d-deec7a7385a5@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgodara@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).