* [PATCH net] netlink: specs: correct types of legacy arrays
@ 2023-05-26 22:06 Jakub Kicinski
2023-05-26 23:15 ` Stanislav Fomichev
2023-05-30 5:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-05-26 22:06 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski, sdf
ethtool has some attrs which dump multiple scalars into
an attribute. The spec currently expects one attr per entry.
Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: sdf@google.com
---
Documentation/netlink/specs/ethtool.yaml | 32 ++++++------------------
1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 129f413ea349..3abc576ff797 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -60,22 +60,6 @@ doc: Partial family for Ethtool Netlink.
type: nest
nested-attributes: bitset-bits
- -
- name: u64-array
- attributes:
- -
- name: u64
- type: nest
- multi-attr: true
- nested-attributes: u64
- -
- name: s32-array
- attributes:
- -
- name: s32
- type: nest
- multi-attr: true
- nested-attributes: s32
-
name: string
attributes:
@@ -705,16 +689,16 @@ doc: Partial family for Ethtool Netlink.
type: u8
-
name: corrected
- type: nest
- nested-attributes: u64-array
+ type: binary
+ sub-type: u64
-
name: uncorr
- type: nest
- nested-attributes: u64-array
+ type: binary
+ sub-type: u64
-
name: corr-bits
- type: nest
- nested-attributes: u64-array
+ type: binary
+ sub-type: u64
-
name: fec
attributes:
@@ -827,8 +811,8 @@ doc: Partial family for Ethtool Netlink.
type: u32
-
name: index
- type: nest
- nested-attributes: s32-array
+ type: binary
+ sub-type: s32
-
name: module
attributes:
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] netlink: specs: correct types of legacy arrays
2023-05-26 22:06 [PATCH net] netlink: specs: correct types of legacy arrays Jakub Kicinski
@ 2023-05-26 23:15 ` Stanislav Fomichev
2023-05-30 5:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stanislav Fomichev @ 2023-05-26 23:15 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni
On Fri, May 26, 2023 at 3:07 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> ethtool has some attrs which dump multiple scalars into
> an attribute. The spec currently expects one attr per entry.
>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
> ---
> CC: sdf@google.com
> ---
> Documentation/netlink/specs/ethtool.yaml | 32 ++++++------------------
> 1 file changed, 8 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 129f413ea349..3abc576ff797 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -60,22 +60,6 @@ doc: Partial family for Ethtool Netlink.
> type: nest
> nested-attributes: bitset-bits
>
> - -
> - name: u64-array
> - attributes:
> - -
> - name: u64
> - type: nest
> - multi-attr: true
> - nested-attributes: u64
> - -
> - name: s32-array
> - attributes:
> - -
> - name: s32
> - type: nest
> - multi-attr: true
> - nested-attributes: s32
> -
> name: string
> attributes:
> @@ -705,16 +689,16 @@ doc: Partial family for Ethtool Netlink.
> type: u8
> -
> name: corrected
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: uncorr
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: corr-bits
> - type: nest
> - nested-attributes: u64-array
> + type: binary
> + sub-type: u64
> -
> name: fec
> attributes:
> @@ -827,8 +811,8 @@ doc: Partial family for Ethtool Netlink.
> type: u32
> -
> name: index
> - type: nest
> - nested-attributes: s32-array
> + type: binary
> + sub-type: s32
> -
> name: module
> attributes:
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] netlink: specs: correct types of legacy arrays
2023-05-26 22:06 [PATCH net] netlink: specs: correct types of legacy arrays Jakub Kicinski
2023-05-26 23:15 ` Stanislav Fomichev
@ 2023-05-30 5:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-30 5:20 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, sdf
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 26 May 2023 15:06:53 -0700 you wrote:
> ethtool has some attrs which dump multiple scalars into
> an attribute. The spec currently expects one attr per entry.
>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: sdf@google.com
>
> [...]
Here is the summary with links:
- [net] netlink: specs: correct types of legacy arrays
https://git.kernel.org/netdev/net/c/0684f29a89e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-30 5:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 22:06 [PATCH net] netlink: specs: correct types of legacy arrays Jakub Kicinski
2023-05-26 23:15 ` Stanislav Fomichev
2023-05-30 5:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).