From: Jakub Kicinski <kuba@kernel.org>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: Christian Lamparter <chunkeey@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"luizluca@gmail.com" <luizluca@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Subject: Re: [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0
Date: Mon, 5 Jun 2023 13:21:33 -0700 [thread overview]
Message-ID: <20230605132133.42eeee14@kernel.org> (raw)
In-Reply-To: <6uu5s53xi6b7s5yzjfrl7fh3pxotoyge2iyt3avwggwrn3i6vc@xywb2jpqxfro>
On Sun, 4 Jun 2023 19:19:45 +0000 Alvin Šipraga wrote:
> > so that's why I said it was "by accident" in the commit message.
> > Since the other macros stayed intact.
>
> Yes, agree. Do you agree with me though that this doesn't warrant backporting to
> stable as there is no functional change with just the patch on its own?
> i.e. this should be part of a broader series adding RTL8363SB-CG support
> targetting net-next.
+1
> (The Fixes: tag is absolutely fine ofc - stable maintainers
> will tell you that this does not necessarily mean it should go in stable, that's
> what cc: stable@vger is for). If so please add [PATCH v2 net-next] so it goes in
> the right place.
I'd remove the Fixes tag as well, and clearly state in the commit msg
that this patch is a noop for all devices currently supported upstream.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-05 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:53 [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0 Christian Lamparter
2023-06-04 11:13 ` Alvin Šipraga
2023-06-04 13:01 ` Christian Lamparter
2023-06-04 19:19 ` Alvin Šipraga
2023-06-05 4:30 ` Luiz Angelo Daros de Luca
2023-06-05 20:21 ` Jakub Kicinski [this message]
2023-06-04 19:59 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605132133.42eeee14@kernel.org \
--to=kuba@kernel.org \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=chunkeey@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).