From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"luizluca@gmail.com" <luizluca@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Subject: Re: [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0
Date: Sun, 4 Jun 2023 19:59:56 +0000 [thread overview]
Message-ID: <p6ijs4ejr6b55xphrjnwxf7tr376qsb2cdyyec6ejcvdhf74ga@rjd5b2mlz636> (raw)
In-Reply-To: <802305c6-10b6-27e6-d154-83ee0abe3aeb@gmail.com>
On Sun, Jun 04, 2023 at 03:01:27PM +0200, Christian Lamparter wrote:
> On 6/4/23 13:13, Alvin Šipraga wrote:
> > On Sat, Jun 03, 2023 at 12:53:48AM +0200, Christian Lamparter wrote:
> > > when bringing up the switch on a Netgear WNDAP660, I observed that
> > > no traffic got passed from the RTL8363 to the ethernet interface...
> >
> > Could you share the chip ID/version you read out from this RTL8363SB? I haven't
> > seen this part number but maybe it's equivalent to some other known switch.
>
> Sure Chip ID is 0x6000 and Chip Version is 0x1000. The label on the physical chip itself:
>
> RTL8363SB
> B8E77P2
> GC17 TAIWAN
>
> I also have a preliminary patch that just adds the switch to the
> rtl8365mb_chip_info table. (The -CG came from Googling after RTL8363SB)
> ---
> --- a/drivers/net/dsa/realtek/rtl8365mb.c
> +++ b/drivers/net/dsa/realtek/rtl8365mb.c
> @@ -519,6 +519,19 @@ struct rtl8365mb_chip_info {
> /* Chip info for each supported switch in the family */
> #define PHY_INTF(_mode) (RTL8365MB_PHY_INTERFACE_MODE_ ## _mode)
> static const struct rtl8365mb_chip_info rtl8365mb_chip_infos[] = {
> + {
> + .name = "RTL8363SB-CG",
Btw, when you send the patch, omit the -CG. The RTL8365MB-VC for example also
has a -CG suffix but this is not relevant as it refers to the package being of
'Green' type (whatever that means), not the silicon revision. :)
prev parent reply other threads:[~2023-06-04 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:53 [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0 Christian Lamparter
2023-06-04 11:13 ` Alvin Šipraga
2023-06-04 13:01 ` Christian Lamparter
2023-06-04 19:19 ` Alvin Šipraga
2023-06-05 4:30 ` Luiz Angelo Daros de Luca
2023-06-05 20:21 ` Jakub Kicinski
2023-06-04 19:59 ` Alvin Šipraga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p6ijs4ejr6b55xphrjnwxf7tr376qsb2cdyyec6ejcvdhf74ga@rjd5b2mlz636 \
--to=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=chunkeey@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).