From: Christian Lamparter <chunkeey@gmail.com>
To: netdev@vger.kernel.org
Cc: alsi@bang-olufsen.dk, luizluca@gmail.com,
linus.walleij@linaro.org, andrew@lunn.ch, olteanv@gmail.com,
f.fainelli@gmail.com
Subject: [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0
Date: Sat, 3 Jun 2023 00:53:48 +0200 [thread overview]
Message-ID: <40df61cc5bebe94e4d7d32f79776be0c12a37d61.1685746295.git.chunkeey@gmail.com> (raw)
when bringing up the switch on a Netgear WNDAP660, I observed that
no traffic got passed from the RTL8363 to the ethernet interface...
Turns out, this was because the dropped case for
RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(0) that
got deleted by accident.
Fixes: d18b59f48b31 ("net: dsa: realtek: rtl8365mb: rename extport to extint")
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(0) is shared between
extif0 and extif1. There's an extra
RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK later on to diffy
up between bits for extif0 and extif1.
---
drivers/net/dsa/realtek/rtl8365mb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index 6c00e6dcb193..57aa39f5b341 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -209,7 +209,8 @@
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT1 */
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 0x13C3 /* EXT2 */
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extint) \
- ((_extint) == 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
+ ((_extint) == 0 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
+ (_extint) == 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
(_extint) == 2 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 : \
0x0)
#define RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extint) \
--
2.40.1
next reply other threads:[~2023-06-02 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:53 Christian Lamparter [this message]
2023-06-04 11:13 ` [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0 Alvin Šipraga
2023-06-04 13:01 ` Christian Lamparter
2023-06-04 19:19 ` Alvin Šipraga
2023-06-05 4:30 ` Luiz Angelo Daros de Luca
2023-06-05 20:21 ` Jakub Kicinski
2023-06-04 19:59 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40df61cc5bebe94e4d7d32f79776be0c12a37d61.1685746295.git.chunkeey@gmail.com \
--to=chunkeey@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).