netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
	edumazet@google.com, jacob.e.keller@intel.com,
	johannes@sipsolutions.net
Subject: Re: [patch net-next 02/10] tools: ynl-gen: introduce support for bitfield32 attribute type
Date: Wed, 11 Oct 2023 09:52:36 -0700	[thread overview]
Message-ID: <20231011095236.5fdca6e2@kernel.org> (raw)
In-Reply-To: <ZSY7kHSLKMgXk9Ao@nanopsycho>

On Wed, 11 Oct 2023 08:07:12 +0200 Jiri Pirko wrote:
> >> Note that since the generated code works with struct nla_bitfiel32,
> >> the generator adds netlink.h to the list of includes for userspace
> >> headers. Regenerate the headers.  
> >
> >If all we need it for is bitfield32 it should be added dynamically.
> >bitfiled32 is an odd concept.  
> 
> What do you mean by "added dynamically"?

Scan the family, see if it has any bitfields and only then add 
the include? It's not that common, no point slowing down compilation
for all families if the header is not otherwise needed.

> >> diff --git a/Documentation/netlink/genetlink-c.yaml b/Documentation/netlink/genetlink-c.yaml
> >> index f9366aaddd21..8192b87b3046 100644
> >> --- a/Documentation/netlink/genetlink-c.yaml
> >> +++ b/Documentation/netlink/genetlink-c.yaml
> >> @@ -144,7 +144,7 @@ properties:
> >>                name:
> >>                  type: string
> >>                type: &attr-type
> >> -                enum: [ unused, pad, flag, binary, u8, u16, u32, u64, s32, s64,
> >> +                enum: [ unused, pad, flag, binary, bitfield32, u8, u16, u32, u64, s32, s64,
> >>                          string, nest, array-nest, nest-type-value ]  
> >
> >Just for genetlink-legacy, please.  
> 
> Why? Should be usable for all, same as other types, no?

array-nest already isn't. I don't see much value in bitfiled32
and listing it means every future codegen for genetlink will
have to support it to be compatible. It's easier to add stuff
than to remove it, so let's not.

  reply	other threads:[~2023-10-11 16:52 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 11:08 [patch net-next 00/10] devlink: finish conversion to generated split_ops Jiri Pirko
2023-10-10 11:08 ` [patch net-next 01/10] genetlink: don't merge dumpit split op for different cmds into single iter Jiri Pirko
2023-10-10 11:24   ` Johannes Berg
2023-10-10 11:39     ` Jiri Pirko
2023-10-10 12:09       ` Johannes Berg
2023-10-10 12:12   ` Johannes Berg
2023-10-10 18:48   ` Jakub Kicinski
2023-10-11  6:08     ` Jiri Pirko
2023-10-11 11:27       ` Jiri Pirko
2023-10-11 16:47         ` Jakub Kicinski
2023-10-11 17:00           ` Jiri Pirko
2023-10-12 20:58           ` Jacob Keller
2023-10-10 11:08 ` [patch net-next 02/10] tools: ynl-gen: introduce support for bitfield32 attribute type Jiri Pirko
2023-10-10 11:11   ` Johannes Berg
2023-10-10 18:58   ` Jakub Kicinski
2023-10-11  6:07     ` Jiri Pirko
2023-10-11 16:52       ` Jakub Kicinski [this message]
2023-10-11 17:04         ` Jiri Pirko
2023-10-11 18:25           ` Jakub Kicinski
2023-10-12  9:28             ` Jiri Pirko
2023-10-12 21:06               ` Jacob Keller
2023-10-13  0:15                 ` Jakub Kicinski
2023-10-13 18:49                   ` Jacob Keller
2023-10-13  0:25               ` Jakub Kicinski
2023-10-10 19:01   ` Jakub Kicinski
2023-10-11  6:06     ` Jiri Pirko
2023-10-10 11:08 ` [patch net-next 03/10] netlink: specs: devlink: remove reload-action from devlink-get cmd reply Jiri Pirko
2023-10-10 11:08 ` [patch net-next 04/10] netlink: specs: devlink: make dont-validate single line Jiri Pirko
2023-10-10 11:08 ` [patch net-next 05/10] netlink: specs: devlink: fix reply command values Jiri Pirko
2023-10-10 18:59   ` Jakub Kicinski
2023-10-11  6:04     ` Jiri Pirko
2023-10-11 16:44       ` Jakub Kicinski
2023-10-11 17:00         ` Jiri Pirko
2023-10-10 11:08 ` [patch net-next 06/10] devlink: make devlink_flash_overwrite enum named one Jiri Pirko
2023-10-10 11:08 ` [patch net-next 07/10] devlink: rename netlink callback to be aligned with the generated ones Jiri Pirko
2023-10-10 11:08 ` [patch net-next 08/10] netlink: specs: devlink: add the remaining command to generate complete split_ops Jiri Pirko
2023-10-10 11:08 ` [patch net-next 09/10] devlink: remove duplicated netlink callback prototypes Jiri Pirko
2023-10-10 11:18 ` [patch net-next 10/10] devlink: remove netlink small_ops Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011095236.5fdca6e2@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).