From: Xie He <xie.he.0141@gmail.com>
To: Martin Schiller <ms@dev.tdt.de>
Cc: Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Krzysztof Halasa <khc@pm.waw.pl>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames
Date: Wed, 3 Mar 2021 12:23:24 -0800 [thread overview]
Message-ID: <CAJht_ENFd74+MeqYDk4AtipKFcQ3n7WHG-rNL62Z=K3FxWct=A@mail.gmail.com> (raw)
In-Reply-To: <8cac820a181070ac2bad983dc49e4e4e@dev.tdt.de>
On Wed, Mar 3, 2021 at 5:26 AM Martin Schiller <ms@dev.tdt.de> wrote:
>
> On 2021-03-03 00:30, Jakub Kicinski wrote:
> >
> > Hard question to answer, existing users seem happy and Xie's driver
> > isn't upstream, so the justification for potentially breaking backward
> > compatibility isn't exactly "strong".
> >
> > Can we cop out and add a knob somewhere to control spawning the extra
> > netdev? Let people who just want a newer kernel carry on without
> > distractions and those who want the extra layer can flip the switch?
>
> Yes, that would be a good compromise.
> I think a compile time selection option is enough here.
> We could introduce a new config option CONFIG_HDLC_X25_LEGACY (or
> something like that) and then implement the new or the old behavior in
> the driver accordingly.
>
> A switch that can be toggled at runtime (e.g. via sethdlc) would also be
> conceivable, but I don't think this is necessary.
Yes, I think adding a new config option would be a good way. Thank you both!!
prev parent reply other threads:[~2021-03-04 0:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 20:18 [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames Xie He
2021-02-18 8:57 ` Leon Romanovsky
2021-02-18 9:07 ` Xie He
2021-02-18 10:37 ` Leon Romanovsky
2021-02-18 17:36 ` Xie He
2021-02-18 19:55 ` Leon Romanovsky
2021-02-18 20:06 ` Xie He
2021-02-18 20:23 ` Xie He
2021-02-19 18:39 ` Jakub Kicinski
2021-02-19 20:28 ` Xie He
2021-02-21 6:39 ` Leon Romanovsky
2021-02-21 19:13 ` Xie He
2021-02-22 7:14 ` Martin Schiller
2021-02-22 8:56 ` Xie He
2021-02-26 14:20 ` Martin Schiller
2021-02-26 23:03 ` Xie He
2021-03-01 6:56 ` Martin Schiller
2021-03-01 8:56 ` Xie He
2021-03-02 7:04 ` Martin Schiller
2021-03-02 23:30 ` Jakub Kicinski
2021-03-03 13:26 ` Martin Schiller
2021-03-03 20:23 ` Xie He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJht_ENFd74+MeqYDk4AtipKFcQ3n7WHG-rNL62Z=K3FxWct=A@mail.gmail.com' \
--to=xie.he.0141@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).