From: Martin Schiller <ms@dev.tdt.de>
To: Xie He <xie.he.0141@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Krzysztof Halasa <khc@pm.waw.pl>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames
Date: Mon, 01 Mar 2021 07:56:25 +0100 [thread overview]
Message-ID: <ff200b159ef358494a922a676cbef8a6@dev.tdt.de> (raw)
In-Reply-To: <CAJht_ENP3Y98jgj1peGa3fGpQ-qPaF=1gtyYwMcawRFW_UCpeA@mail.gmail.com>
On 2021-02-27 00:03, Xie He wrote:
> On Fri, Feb 26, 2021 at 6:21 AM Martin Schiller <ms@dev.tdt.de> wrote:
>>
>> I have now had a look at it. It works as expected.
>> I just wonder if it would not be more appropriate to call
>> the lapb_register() already in x25_hdlc_open(), so that the layer2
>> (lapb) can already "work" before the hdlc<x>_x25 interface is up.
>
> I think it's better not to keep LAPB running unless hdlc<x>_x25 is up.
> If I am the user, I would expect that when I change the X.25 interface
> to the DOWN state, the LAPB protocol would be completely stopped and
> the LAPB layer would not generate any new frames anymore (even if the
> other side wants to connect), and when I change the X.25 interface
> back to the UP state, it would be a fresh new start for the LAPB
> protocol.
>
>> Also, I have a hard time assessing if such a wrap is really
>> enforceable.
>
> Sorry. I don't understand what you mean. What "wrap" are you referring
> to?
I mean the change from only one hdlc<x> interface to both hdlc<x> and
hdlc<x>_x25.
I can't estimate how many users are out there and how their setup looks
like.
>
>> Unfortunately I have no idea how many users there actually are.
next prev parent reply other threads:[~2021-03-01 6:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 20:18 [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames Xie He
2021-02-18 8:57 ` Leon Romanovsky
2021-02-18 9:07 ` Xie He
2021-02-18 10:37 ` Leon Romanovsky
2021-02-18 17:36 ` Xie He
2021-02-18 19:55 ` Leon Romanovsky
2021-02-18 20:06 ` Xie He
2021-02-18 20:23 ` Xie He
2021-02-19 18:39 ` Jakub Kicinski
2021-02-19 20:28 ` Xie He
2021-02-21 6:39 ` Leon Romanovsky
2021-02-21 19:13 ` Xie He
2021-02-22 7:14 ` Martin Schiller
2021-02-22 8:56 ` Xie He
2021-02-26 14:20 ` Martin Schiller
2021-02-26 23:03 ` Xie He
2021-03-01 6:56 ` Martin Schiller [this message]
2021-03-01 8:56 ` Xie He
2021-03-02 7:04 ` Martin Schiller
2021-03-02 23:30 ` Jakub Kicinski
2021-03-03 13:26 ` Martin Schiller
2021-03-03 20:23 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff200b159ef358494a922a676cbef8a6@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).