From: Leon Romanovsky <leon@kernel.org>
To: Xie He <xie.he.0141@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Martin Schiller <ms@dev.tdt.de>, Krzysztof Halasa <khc@pm.waw.pl>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames
Date: Thu, 18 Feb 2021 21:55:10 +0200 [thread overview]
Message-ID: <YC7GHgYfGmL2wVRR@unreal> (raw)
In-Reply-To: <CAJht_EOhu+Wsv91yDS5dEt+YgSmGsBnkz=igeTLibenAgR=Tew@mail.gmail.com>
On Thu, Feb 18, 2021 at 09:36:54AM -0800, Xie He wrote:
> On Thu, Feb 18, 2021 at 2:37 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > It is not me who didn't explain, it is you who didn't want to write clear
> > comment that describes the headroom size without need of "3 - 1".
>
> Why do I need to write unnecessary comments when "3 - 1" and the
> current comment already explains everything?
This is how we write code, we use defines instead of constant numbers,
comments to describe tricky parts and assign already preprocessed result.
There is nothing I can do If you don't like or don't want to use Linux kernel
style.
Thanks
next prev parent reply other threads:[~2021-02-18 19:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 20:18 [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames Xie He
2021-02-18 8:57 ` Leon Romanovsky
2021-02-18 9:07 ` Xie He
2021-02-18 10:37 ` Leon Romanovsky
2021-02-18 17:36 ` Xie He
2021-02-18 19:55 ` Leon Romanovsky [this message]
2021-02-18 20:06 ` Xie He
2021-02-18 20:23 ` Xie He
2021-02-19 18:39 ` Jakub Kicinski
2021-02-19 20:28 ` Xie He
2021-02-21 6:39 ` Leon Romanovsky
2021-02-21 19:13 ` Xie He
2021-02-22 7:14 ` Martin Schiller
2021-02-22 8:56 ` Xie He
2021-02-26 14:20 ` Martin Schiller
2021-02-26 23:03 ` Xie He
2021-03-01 6:56 ` Martin Schiller
2021-03-01 8:56 ` Xie He
2021-03-02 7:04 ` Martin Schiller
2021-03-02 23:30 ` Jakub Kicinski
2021-03-03 13:26 ` Martin Schiller
2021-03-03 20:23 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC7GHgYfGmL2wVRR@unreal \
--to=leon@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).