qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* riscv kvm breakage
@ 2023-07-11 16:43 Richard Henderson
  2023-07-11 16:47 ` Philippe Mathieu-Daudé
  2023-07-11 16:49 ` Palmer Dabbelt
  0 siblings, 2 replies; 4+ messages in thread
From: Richard Henderson @ 2023-07-11 16:43 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-riscv, Alistair Francis, Bin Meng, liweiwei,
	Daniel Henrique Barboza, LIU Zhiwei

Hiya,

This breakage crept in while cross-riscv64-system was otherwise broken in configure:

https://gitlab.com/qemu-project/qemu/-/jobs/4633277557#L4165

../target/riscv/kvm.c:209:38: error: ‘KVM_RISCV_ISA_EXT_ZICBOZ’ undeclared here (not in a 
function); did you mean ‘KVM_RISCV_ISA_EXT_ZICBOM’?
   209 |     KVM_EXT_CFG("zicboz", ext_icboz, KVM_RISCV_ISA_EXT_ZICBOZ),
       |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
   205 |      .kvm_reg_id = _reg_id}
       |                    ^~~~~~~
../target/riscv/kvm.c:211:33: error: ‘KVM_RISCV_ISA_EXT_ZBB’ undeclared here (not in a 
function); did you mean ‘KVM_RISCV_ISA_EXT_MAX’?
   211 |     KVM_EXT_CFG("zbb", ext_zbb, KVM_RISCV_ISA_EXT_ZBB),
       |                                 ^~~~~~~~~~~~~~~~~~~~~
../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
   205 |      .kvm_reg_id = _reg_id}
       |                    ^~~~~~~
../target/riscv/kvm.c:212:37: error: ‘KVM_RISCV_ISA_EXT_SSAIA’ undeclared here (not in a 
function); did you mean ‘KVM_RISCV_ISA_EXT_SSTC’?
   212 |     KVM_EXT_CFG("ssaia", ext_ssaia, KVM_RISCV_ISA_EXT_SSAIA),
       |                                     ^~~~~~~~~~~~~~~~~~~~~~~
../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
   205 |      .kvm_reg_id = _reg_id}
       |                    ^~~~~~~
In file included from /usr/riscv64-linux-gnu/include/rpc/netdb.h:42,
                  from /usr/riscv64-linux-gnu/include/netdb.h:32,
                  from /builds/qemu-project/qemu/include/sysemu/os-posix.h:34,
                  from /builds/qemu-project/qemu/include/qemu/osdep.h:151,
                  from ../target/riscv/kvm.c:19:
../target/riscv/kvm.c:288:44: error: ‘struct kvm_riscv_config’ has no member named 
‘zicboz_block_size’; did you mean ‘zicbom_block_size’?
   288 |     .kvm_reg_id = KVM_REG_RISCV_CONFIG_REG(zicboz_block_size)
       |                                            ^~~~~~~~~~~~~~~~~

Can someone have a look asap?  Thanks,


r~



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: riscv kvm breakage
  2023-07-11 16:43 riscv kvm breakage Richard Henderson
@ 2023-07-11 16:47 ` Philippe Mathieu-Daudé
  2023-07-11 17:02   ` Daniel Henrique Barboza
  2023-07-11 16:49 ` Palmer Dabbelt
  1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-07-11 16:47 UTC (permalink / raw)
  To: Richard Henderson, qemu-devel
  Cc: qemu-riscv, Alistair Francis, Bin Meng, liweiwei,
	Daniel Henrique Barboza, LIU Zhiwei

On 11/7/23 18:43, Richard Henderson wrote:
> Hiya,
> 
> This breakage crept in while cross-riscv64-system was otherwise broken 
> in configure:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/4633277557#L4165
> 
> ../target/riscv/kvm.c:209:38: error: ‘KVM_RISCV_ISA_EXT_ZICBOZ’ 
> undeclared here (not in a function); did you mean 
> ‘KVM_RISCV_ISA_EXT_ZICBOM’?
>    209 |     KVM_EXT_CFG("zicboz", ext_icboz, KVM_RISCV_ISA_EXT_ZICBOZ),
>        |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>    205 |      .kvm_reg_id = _reg_id}
>        |                    ^~~~~~~
> ../target/riscv/kvm.c:211:33: error: ‘KVM_RISCV_ISA_EXT_ZBB’ undeclared 
> here (not in a function); did you mean ‘KVM_RISCV_ISA_EXT_MAX’?
>    211 |     KVM_EXT_CFG("zbb", ext_zbb, KVM_RISCV_ISA_EXT_ZBB),
>        |                                 ^~~~~~~~~~~~~~~~~~~~~
> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>    205 |      .kvm_reg_id = _reg_id}
>        |                    ^~~~~~~
> ../target/riscv/kvm.c:212:37: error: ‘KVM_RISCV_ISA_EXT_SSAIA’ 
> undeclared here (not in a function); did you mean ‘KVM_RISCV_ISA_EXT_SSTC’?
>    212 |     KVM_EXT_CFG("ssaia", ext_ssaia, KVM_RISCV_ISA_EXT_SSAIA),
>        |                                     ^~~~~~~~~~~~~~~~~~~~~~~
> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>    205 |      .kvm_reg_id = _reg_id}
>        |                    ^~~~~~~
> In file included from /usr/riscv64-linux-gnu/include/rpc/netdb.h:42,
>                   from /usr/riscv64-linux-gnu/include/netdb.h:32,
>                   from 
> /builds/qemu-project/qemu/include/sysemu/os-posix.h:34,
>                   from /builds/qemu-project/qemu/include/qemu/osdep.h:151,
>                   from ../target/riscv/kvm.c:19:
> ../target/riscv/kvm.c:288:44: error: ‘struct kvm_riscv_config’ has no 
> member named ‘zicboz_block_size’; did you mean ‘zicbom_block_size’?
>    288 |     .kvm_reg_id = KVM_REG_RISCV_CONFIG_REG(zicboz_block_size)
>        |                                            ^~~~~~~~~~~~~~~~~
> 
> Can someone have a look asap?  Thanks,

See:
https://lore.kernel.org/qemu-devel/20230711163346.69409-1-philmd@linaro.org/

:)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: riscv kvm breakage
  2023-07-11 16:43 riscv kvm breakage Richard Henderson
  2023-07-11 16:47 ` Philippe Mathieu-Daudé
@ 2023-07-11 16:49 ` Palmer Dabbelt
  1 sibling, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2023-07-11 16:49 UTC (permalink / raw)
  To: Richard Henderson, philmd, mjt, dbarboza
  Cc: qemu-devel, qemu-riscv, Alistair Francis, bin.meng, liweiwei, zhiwei_liu

On Tue, 11 Jul 2023 09:43:48 PDT (-0700), Richard Henderson wrote:
> Hiya,
>
> This breakage crept in while cross-riscv64-system was otherwise broken in configure:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/4633277557#L4165
>
> ../target/riscv/kvm.c:209:38: error: ‘KVM_RISCV_ISA_EXT_ZICBOZ’ undeclared here (not in a
> function); did you mean ‘KVM_RISCV_ISA_EXT_ZICBOM’?
>    209 |     KVM_EXT_CFG("zicboz", ext_icboz, KVM_RISCV_ISA_EXT_ZICBOZ),
>        |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>    205 |      .kvm_reg_id = _reg_id}
>        |                    ^~~~~~~
> ../target/riscv/kvm.c:211:33: error: ‘KVM_RISCV_ISA_EXT_ZBB’ undeclared here (not in a
> function); did you mean ‘KVM_RISCV_ISA_EXT_MAX’?
>    211 |     KVM_EXT_CFG("zbb", ext_zbb, KVM_RISCV_ISA_EXT_ZBB),
>        |                                 ^~~~~~~~~~~~~~~~~~~~~
> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>    205 |      .kvm_reg_id = _reg_id}
>        |                    ^~~~~~~
> ../target/riscv/kvm.c:212:37: error: ‘KVM_RISCV_ISA_EXT_SSAIA’ undeclared here (not in a
> function); did you mean ‘KVM_RISCV_ISA_EXT_SSTC’?
>    212 |     KVM_EXT_CFG("ssaia", ext_ssaia, KVM_RISCV_ISA_EXT_SSAIA),
>        |                                     ^~~~~~~~~~~~~~~~~~~~~~~
> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>    205 |      .kvm_reg_id = _reg_id}
>        |                    ^~~~~~~
> In file included from /usr/riscv64-linux-gnu/include/rpc/netdb.h:42,
>                   from /usr/riscv64-linux-gnu/include/netdb.h:32,
>                   from /builds/qemu-project/qemu/include/sysemu/os-posix.h:34,
>                   from /builds/qemu-project/qemu/include/qemu/osdep.h:151,
>                   from ../target/riscv/kvm.c:19:
> ../target/riscv/kvm.c:288:44: error: ‘struct kvm_riscv_config’ has no member named
> ‘zicboz_block_size’; did you mean ‘zicbom_block_size’?
>    288 |     .kvm_reg_id = KVM_REG_RISCV_CONFIG_REG(zicboz_block_size)
>        |                                            ^~~~~~~~~~~~~~~~~
>
> Can someone have a look asap?  Thanks,

+Phillippe and Michael, there's already a discussion on IRC and sounds 
like there's a fix?

>
>
> r~


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: riscv kvm breakage
  2023-07-11 16:47 ` Philippe Mathieu-Daudé
@ 2023-07-11 17:02   ` Daniel Henrique Barboza
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2023-07-11 17:02 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, Richard Henderson, qemu-devel
  Cc: qemu-riscv, Alistair Francis, Bin Meng, liweiwei, LIU Zhiwei



On 7/11/23 13:47, Philippe Mathieu-Daudé wrote:
> On 11/7/23 18:43, Richard Henderson wrote:
>> Hiya,
>>
>> This breakage crept in while cross-riscv64-system was otherwise broken in configure:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/4633277557#L4165
>>
>> ../target/riscv/kvm.c:209:38: error: ‘KVM_RISCV_ISA_EXT_ZICBOZ’ undeclared here (not in a function); did you mean ‘KVM_RISCV_ISA_EXT_ZICBOM’?
>>    209 |     KVM_EXT_CFG("zicboz", ext_icboz, KVM_RISCV_ISA_EXT_ZICBOZ),
>>        |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
>> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>>    205 |      .kvm_reg_id = _reg_id}
>>        |                    ^~~~~~~
>> ../target/riscv/kvm.c:211:33: error: ‘KVM_RISCV_ISA_EXT_ZBB’ undeclared here (not in a function); did you mean ‘KVM_RISCV_ISA_EXT_MAX’?
>>    211 |     KVM_EXT_CFG("zbb", ext_zbb, KVM_RISCV_ISA_EXT_ZBB),
>>        |                                 ^~~~~~~~~~~~~~~~~~~~~
>> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>>    205 |      .kvm_reg_id = _reg_id}
>>        |                    ^~~~~~~
>> ../target/riscv/kvm.c:212:37: error: ‘KVM_RISCV_ISA_EXT_SSAIA’ undeclared here (not in a function); did you mean ‘KVM_RISCV_ISA_EXT_SSTC’?
>>    212 |     KVM_EXT_CFG("ssaia", ext_ssaia, KVM_RISCV_ISA_EXT_SSAIA),
>>        |                                     ^~~~~~~~~~~~~~~~~~~~~~~
>> ../target/riscv/kvm.c:205:20: note: in definition of macro ‘KVM_EXT_CFG’
>>    205 |      .kvm_reg_id = _reg_id}
>>        |                    ^~~~~~~
>> In file included from /usr/riscv64-linux-gnu/include/rpc/netdb.h:42,
>>                   from /usr/riscv64-linux-gnu/include/netdb.h:32,
>>                   from /builds/qemu-project/qemu/include/sysemu/os-posix.h:34,
>>                   from /builds/qemu-project/qemu/include/qemu/osdep.h:151,
>>                   from ../target/riscv/kvm.c:19:
>> ../target/riscv/kvm.c:288:44: error: ‘struct kvm_riscv_config’ has no member named ‘zicboz_block_size’; did you mean ‘zicbom_block_size’?
>>    288 |     .kvm_reg_id = KVM_REG_RISCV_CONFIG_REG(zicboz_block_size)
>>        |                                            ^~~~~~~~~~~~~~~~~
>>
>> Can someone have a look asap?  Thanks,
> 
> See:
> https://lore.kernel.org/qemu-devel/20230711163346.69409-1-philmd@linaro.org/

Thanks Phil!

ps: cross building stuff is hard ....



> 
> :)


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-11 17:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 16:43 riscv kvm breakage Richard Henderson
2023-07-11 16:47 ` Philippe Mathieu-Daudé
2023-07-11 17:02   ` Daniel Henrique Barboza
2023-07-11 16:49 ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).