From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-riscv@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-ppc@nongnu.org,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Helge Deller <deller@gmx.de>, Palmer Dabbelt <palmer@sifive.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
qemu-arm@nongnu.org, Alistair Francis <Alistair.Francis@wdc.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI
Date: Mon, 15 Jul 2019 13:01:54 +0200 [thread overview]
Message-ID: <abe7f883-b08b-ee4a-1831-f473c10838f8@redhat.com> (raw)
In-Reply-To: <20190715095545.28545-3-philmd@redhat.com>
On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote:
> The USB_EHCI entry currently include PCI code. Since the EHCI
> implementation is already split in sysbus/PCI, add a new
> USB_EHCI_PCI. There are no logical changes, but the Kconfig
> dependencies tree is cleaner.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/usb/Kconfig | 9 ++++++---
> hw/usb/Makefile.objs | 5 +++--
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index 564305e283..495c6f2d48 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -19,13 +19,16 @@ config USB_OHCI_PCI
>
> config USB_EHCI
> bool
> - default y if PCI_DEVICES
> - depends on PCI
> select USB
>
> +config USB_EHCI_PCI
> + bool
> + default y if PCI_DEVICES
> + select USB_EHCI
> +
> config USB_EHCI_SYSBUS
> bool
> - select USB
> + select USB_EHCI
>
> config USB_XHCI
> bool
> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
> index 81688f6e70..303ac084a0 100644
> --- a/hw/usb/Makefile.objs
> +++ b/hw/usb/Makefile.objs
> @@ -6,8 +6,9 @@ common-obj-$(CONFIG_USB) += desc.o desc-msos.o
> common-obj-$(CONFIG_USB_UHCI) += hcd-uhci.o
> common-obj-$(CONFIG_USB_OHCI) += hcd-ohci.o
> common-obj-$(CONFIG_USB_OHCI_PCI) += hcd-ohci-pci.o
> -common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o hcd-ehci-pci.o
> -common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci.o hcd-ehci-sysbus.o
> +common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o
> +common-obj-$(CONFIG_USB_EHCI_PCI) += hcd-ehci-pci.o
> +common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci-sysbus.o
> common-obj-$(CONFIG_USB_XHCI) += hcd-xhci.o
> common-obj-$(CONFIG_USB_XHCI_NEC) += hcd-xhci-nec.o
> common-obj-$(CONFIG_USB_MUSB) += hcd-musb.o
>
Looks cleaner this way, indeed.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-07-15 11:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:55 [Qemu-devel] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES Philippe Mathieu-Daudé
2019-07-15 10:15 ` Thomas Huth
2019-07-15 10:19 ` Peter Maydell
2019-07-15 10:48 ` Thomas Huth
2019-07-15 10:56 ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2019-07-15 11:04 ` Philippe Mathieu-Daudé
2019-07-15 11:09 ` Cornelia Huck
2019-07-15 13:19 ` Thomas Huth
2019-07-15 13:38 ` Philippe Mathieu-Daudé
2019-07-15 13:49 ` Thomas Huth
2019-07-15 16:08 ` Markus Armbruster
2019-07-15 16:12 ` Cornelia Huck
2019-07-15 18:22 ` Paolo Bonzini
2019-07-16 13:06 ` Markus Armbruster
2019-07-16 15:04 ` Thomas Huth
2019-07-17 12:59 ` Collin Walling
2019-07-17 13:52 ` Paolo Bonzini
2019-07-17 14:54 ` Collin Walling
2019-07-17 15:04 ` Paolo Bonzini
2019-07-18 15:33 ` Cornelia Huck
2019-07-22 13:40 ` Markus Armbruster
2019-07-15 9:55 ` [Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI Philippe Mathieu-Daudé
2019-07-15 10:54 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2019-07-15 11:03 ` Thomas Huth
2019-07-15 11:10 ` BALATON Zoltan
2019-07-15 11:19 ` Thomas Huth
2019-07-15 11:20 ` Paolo Bonzini
2019-07-15 11:01 ` Thomas Huth [this message]
2019-07-15 9:55 ` [Qemu-devel] [PATCH-for-4.1? 3/3] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI Philippe Mathieu-Daudé
2019-07-15 10:50 ` Thomas Huth
2019-07-15 11:21 ` [Qemu-devel] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe7f883-b08b-ee4a-1831-f473c10838f8@redhat.com \
--to=thuth@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=david@gibson.dropbear.id.au \
--cc=deller@gmx.de \
--cc=ehabkost@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).