From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-riscv@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-ppc@nongnu.org, Helge Deller <deller@gmx.de>,
Palmer Dabbelt <palmer@sifive.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
"open list:S390" <qemu-s390x@nongnu.org>,
qemu-arm@nongnu.org, Alistair Francis <Alistair.Francis@wdc.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES
Date: Mon, 15 Jul 2019 12:15:33 +0200 [thread overview]
Message-ID: <ca528cdc-6118-0b2f-c1b8-30b06875dde8@redhat.com> (raw)
In-Reply-To: <20190715095545.28545-2-philmd@redhat.com>
On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote:
> If a controller device provides a PCI bus, we can plug any PCI
> daughter card on it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> docs/devel/kconfig.rst | 1 -
> hw/alpha/Kconfig | 1 -
> hw/arm/Kconfig | 4 ----
> hw/hppa/Kconfig | 1 -
> hw/i386/Kconfig | 1 -
> hw/pci/Kconfig | 1 +
> hw/ppc/Kconfig | 6 ------
> hw/riscv/Kconfig | 1 -
> hw/sh4/Kconfig | 1 -
> hw/sparc64/Kconfig | 1 -
> 10 files changed, 1 insertion(+), 17 deletions(-)
>
> diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst
> index d6f8eb0977..6c010d38d4 100644
> --- a/docs/devel/kconfig.rst
> +++ b/docs/devel/kconfig.rst
> @@ -56,7 +56,6 @@ stanza like the following::
>
> config ARM_VIRT
> bool
> - imply PCI_DEVICES
> imply VFIO_AMD_XGBE
> imply VFIO_XGMAC
> select A15MPCORE
> diff --git a/hw/alpha/Kconfig b/hw/alpha/Kconfig
> index 15c59ff264..ddac1bf8e5 100644
> --- a/hw/alpha/Kconfig
> +++ b/hw/alpha/Kconfig
> @@ -1,6 +1,5 @@
> config DP264
> bool
> - imply PCI_DEVICES
> imply TEST_DEVICES
> imply E1000_PCI
> select I82374
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index ab65ecd216..51db042a0a 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -1,6 +1,5 @@
> config ARM_VIRT
> bool
> - imply PCI_DEVICES
> imply TEST_DEVICES
> imply VFIO_AMD_XGBE
> imply VFIO_PLATFORM
> @@ -159,7 +158,6 @@ config Z2
>
> config REALVIEW
> bool
> - imply PCI_DEVICES
> imply PCI_TESTDEV
> select SMC91C111
> select LAN9118
> @@ -186,7 +184,6 @@ config REALVIEW
>
> config SBSA_REF
> bool
> - imply PCI_DEVICES
> select AHCI
> select ARM_SMMUV3
> select GPIO_KEY
> @@ -365,7 +362,6 @@ config MPS2
>
> config FSL_IMX7
> bool
> - imply PCI_DEVICES
> imply TEST_DEVICES
> select A15MPCORE
> select PCI
> diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
> index 6e5d74a825..13183ff243 100644
> --- a/hw/hppa/Kconfig
> +++ b/hw/hppa/Kconfig
> @@ -1,6 +1,5 @@
> config DINO
> bool
> - imply PCI_DEVICES
> imply E1000_PCI
> imply VIRTIO_VGA
> select PCI
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index 4ddf2a9c55..4eceab2c7c 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -10,7 +10,6 @@ config PC
> imply ISA_IPMI_BT
> imply ISA_DEBUG
> imply PARALLEL
> - imply PCI_DEVICES
> imply PVPANIC
> imply QXL
> imply SEV
> diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig
> index 77f8b005ff..0f7267db35 100644
> --- a/hw/pci/Kconfig
> +++ b/hw/pci/Kconfig
> @@ -1,5 +1,6 @@
> config PCI
> bool
> + imply PCI_DEVICES
No, please don't change this. This was done on purpose, since almost all
PCI_DEVICES do not work on s390x (so s390x does *not* imply PCI_DEVICES).
Thomas
next prev parent reply other threads:[~2019-07-15 10:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:55 [Qemu-devel] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Philippe Mathieu-Daudé
2019-07-15 9:55 ` [Qemu-devel] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES Philippe Mathieu-Daudé
2019-07-15 10:15 ` Thomas Huth [this message]
2019-07-15 10:19 ` Peter Maydell
2019-07-15 10:48 ` Thomas Huth
2019-07-15 10:56 ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2019-07-15 11:04 ` Philippe Mathieu-Daudé
2019-07-15 11:09 ` Cornelia Huck
2019-07-15 13:19 ` Thomas Huth
2019-07-15 13:38 ` Philippe Mathieu-Daudé
2019-07-15 13:49 ` Thomas Huth
2019-07-15 16:08 ` Markus Armbruster
2019-07-15 16:12 ` Cornelia Huck
2019-07-15 18:22 ` Paolo Bonzini
2019-07-16 13:06 ` Markus Armbruster
2019-07-16 15:04 ` Thomas Huth
2019-07-17 12:59 ` Collin Walling
2019-07-17 13:52 ` Paolo Bonzini
2019-07-17 14:54 ` Collin Walling
2019-07-17 15:04 ` Paolo Bonzini
2019-07-18 15:33 ` Cornelia Huck
2019-07-22 13:40 ` Markus Armbruster
2019-07-15 9:55 ` [Qemu-devel] [PATCH-for-4.2 2/3] hw/usb/Kconfig: Add CONFIG_USB_EHCI_PCI Philippe Mathieu-Daudé
2019-07-15 10:54 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2019-07-15 11:03 ` Thomas Huth
2019-07-15 11:10 ` BALATON Zoltan
2019-07-15 11:19 ` Thomas Huth
2019-07-15 11:20 ` Paolo Bonzini
2019-07-15 11:01 ` [Qemu-devel] " Thomas Huth
2019-07-15 9:55 ` [Qemu-devel] [PATCH-for-4.1? 3/3] hw/usb/Kconfig: USB_XHCI_NEC requires USB_XHCI Philippe Mathieu-Daudé
2019-07-15 10:50 ` Thomas Huth
2019-07-15 11:21 ` [Qemu-devel] [PATCH 0/3] hw/Kconfig: PCI & USB fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca528cdc-6118-0b2f-c1b8-30b06875dde8@redhat.com \
--to=thuth@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=david@gibson.dropbear.id.au \
--cc=deller@gmx.de \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).