Re: [PATCH v2 5/8] rust: workqueue: add helper for defining work_struct fields

From: Alice Ryhl <aliceryhl@google.com>
To: benno.lossin@proton.me
Cc: alex.gaynor@gmail.com, aliceryhl@google.com,
	bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
	jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
	ojeda@kernel.org, patches@lists.linux.dev,
	rust-for-linux@vger.kernel.org, tj@kernel.org,
	wedsonaf@gmail.com
Subject: Re: [PATCH v2 5/8] rust: workqueue: add helper for defining work_struct fields
Date: Tue, 27 Jun 2023 08:42:02 +0000	[thread overview]
Message-ID: <20230627084202.1738047-1-aliceryhl@google.com> (raw)
In-Reply-To: <sEZfLlqyui7bU5IsD7mRZq4wIsJqQ5ZZj4qtp6oq-d8rEu4Gx1rp6MXwxTsZt4zEaO7V-5HtmmULgwpVArU4DW-9UcZsjWYg0a5pojvAlVQ=@proton.me>

Benno Lossin <benno.lossin@proton.me> writes:
> On 01.06.23 15:49, Alice Ryhl wrote:
>> +/// # Safety
>> +///
>> +/// The [`OFFSET`] constant must be the offset of a field in Self of type [`Work<T, ID>`]. The methods on
>> +/// this trait must have exactly the behavior that the definitions given below have.
> 
> I think you should just say "implementers are not allowed to implement
> the functions defined by this trait." I see no reason to allow that, since
> all functions are fully determined by the `OFFSET` constant.

The macro overrides one of the methods, so that wont work.
(It overrides the method to check that the field has the claimed type.)

I'll apply the rest of your suggestions.

Alice