From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: alex.gaynor@gmail.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, gary@garyguo.net,
jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
ojeda@kernel.org, patches@lists.linux.dev,
rust-for-linux@vger.kernel.org, tj@kernel.org,
wedsonaf@gmail.com
Subject: Re: [PATCH v2 5/8] rust: workqueue: add helper for defining work_struct fields
Date: Fri, 2 Jun 2023 09:32:56 -0700 [thread overview]
Message-ID: <ZHoZuIz97JN1VSBf@boqun-archlinux> (raw)
In-Reply-To: <20230602083856.1035444-1-aliceryhl@google.com>
On Fri, Jun 02, 2023 at 08:38:56AM +0000, Alice Ryhl wrote:
> Boqun Feng <boqun.feng@gmail.com> writes:
> > On Thu, Jun 01, 2023 at 01:49:43PM +0000, Alice Ryhl wrote:
> >> diff --git a/rust/helpers.c b/rust/helpers.c
> >> index 81e80261d597..7f0c2fe2fbeb 100644
> >> --- a/rust/helpers.c
> >> +++ b/rust/helpers.c
> >> @@ -26,6 +26,7 @@
> >> #include <linux/spinlock.h>
> >> #include <linux/sched/signal.h>
> >> #include <linux/wait.h>
> >> +#include <linux/workqueue.h>
> >>
> >> __noreturn void rust_helper_BUG(void)
> >> {
> >> @@ -128,6 +129,13 @@ void rust_helper_put_task_struct(struct task_struct *t)
> >> }
> >> EXPORT_SYMBOL_GPL(rust_helper_put_task_struct);
> >>
> >> +void rust_helper___INIT_WORK(struct work_struct *work, work_func_t func,
> >> + bool on_stack)
> >> +{
> >> + __INIT_WORK(work, func, on_stack);
> >
> > Note here all the work items in Rust will share the same lockdep class.
> > That could be problematic: the lockdep classes for work are for
> > detecting deadlocks in the following scenario:
> >
> > step 1: queue a work "foo", whose work function is:
> >
> > mutex_lock(&bar);
> > do_something(...);
> > mutex_unlock(&bar);
> >
> > step 2: in another thread do:
> >
> > mutex_lock(&bar);
> > flush_work(foo); // wait until work "foo" is finished.
> >
> > if this case, if step 2 get the lock "bar" first, it's a deadlock.
> >
> > With the current implementation, all the work items share the same
> > lockdep class, so the following will be treated as deadlock:
> >
> > <in work "work1">
> > mutex_lock(&bar);
> > do_something(...);
> > mutex_unlock(&bar);
> >
> > <in another thread>
> > mutex_lock(&bar);
> > flush_work(work2); // flush work2 intead of work1.
> >
> > which is a false positive. We at least need some changes in C side to
> > make it work:
> >
> > https://lore.kernel.org/rust-for-linux/20220802015052.10452-7-ojeda@kernel.org/
> >
> > however, that still has the disadvantage that all Rust work items have
> > the same name for the lockdep classes.. maybe we should extend that for
> > an extra "name" parameter. And then it's not necessary to be a macro.
>
> Yeah, I did know about this issue, but I didn't know what the best way
> to fix it is. What solution would you like me to use?
>
Having a init_work_with_key() function in C side:
void init_work_with_key(struct work_struct *work, bool onstack,
const char *name, struct lock_class_key *key)
{
__init_work(work, onstack); \
work->data = (atomic_long_t) WORK_DATA_INIT(); \
lockdep_init_map(&work->lockdep_map, name, key, 0); \
INIT_LIST_HEAD(&work->entry); \
work->func = func; \
}
, and provide class key and name from Rust side.
Thoughts?
Regards,
Boqun
> Alice
next prev parent reply other threads:[~2023-06-02 16:34 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 13:49 [PATCH v2 0/8] rust: workqueue: add bindings for the workqueue Alice Ryhl
2023-06-01 13:49 ` [PATCH v2 1/8] rust: workqueue: add low-level workqueue bindings Alice Ryhl
2023-06-01 14:29 ` Martin Rodriguez Reboredo
2023-06-02 14:39 ` Andreas Hindborg (Samsung)
2023-06-06 23:36 ` Boqun Feng
2023-06-07 15:18 ` Alice Ryhl
2023-06-11 15:45 ` Benno Lossin
2023-06-01 13:49 ` [PATCH v2 2/8] rust: add offset_of! macro Alice Ryhl
2023-06-01 17:17 ` Gary Guo
2023-06-02 10:33 ` Andreas Hindborg (Samsung)
2023-06-07 15:15 ` Alice Ryhl
2023-06-11 15:47 ` Benno Lossin
2023-06-01 13:49 ` [PATCH v2 3/8] rust: sync: add `Arc::{from_raw, into_raw}` Alice Ryhl
2023-06-01 17:26 ` Gary Guo
2023-06-02 10:51 ` Andreas Hindborg (Samsung)
2023-06-05 14:31 ` Gary Guo
2023-06-05 14:49 ` Andreas Hindborg (Samsung)
2023-06-05 15:00 ` Boqun Feng
2023-06-05 15:20 ` Boqun Feng
2023-06-05 18:34 ` Andreas Hindborg (Samsung)
2023-06-11 15:48 ` Benno Lossin
2023-06-01 13:49 ` [PATCH v2 4/8] rust: workqueue: define built-in queues Alice Ryhl
2023-06-01 17:30 ` Gary Guo
2023-06-01 17:52 ` Martin Rodriguez Reboredo
2023-06-02 8:32 ` Alice Ryhl
2023-06-02 14:46 ` Andreas Hindborg (Samsung)
2023-06-11 15:49 ` Benno Lossin
2023-06-01 13:49 ` [PATCH v2 5/8] rust: workqueue: add helper for defining work_struct fields Alice Ryhl
2023-06-01 14:50 ` Martin Rodriguez Reboredo
2023-06-01 18:44 ` Boqun Feng
2023-06-02 8:38 ` Alice Ryhl
2023-06-02 16:32 ` Boqun Feng [this message]
2023-06-01 21:09 ` Boqun Feng
2023-06-02 9:37 ` Alice Ryhl
2023-06-02 14:41 ` Andreas Hindborg (Samsung)
2023-06-11 15:59 ` Benno Lossin
2023-06-27 8:42 ` Alice Ryhl
2023-06-01 13:49 ` [PATCH v2 6/8] rust: workqueue: implement `WorkItemPointer` for pointer types Alice Ryhl
2023-06-01 14:51 ` Martin Rodriguez Reboredo
2023-06-02 14:42 ` Andreas Hindborg (Samsung)
2023-06-11 16:01 ` Benno Lossin
2023-06-01 13:49 ` [PATCH v2 7/8] rust: workqueue: add `try_spawn` helper method Alice Ryhl
2023-06-01 14:53 ` Martin Rodriguez Reboredo
2023-06-02 14:43 ` Andreas Hindborg (Samsung)
2023-06-11 16:10 ` Benno Lossin
2023-06-01 13:49 ` [PATCH v2 8/8] rust: workqueue: add examples Alice Ryhl
2023-06-01 14:58 ` Martin Rodriguez Reboredo
2023-06-01 17:32 ` Gary Guo
2023-06-02 9:39 ` Alice Ryhl
2023-06-02 14:44 ` Andreas Hindborg (Samsung)
2023-06-02 14:48 ` Andreas Hindborg (Samsung)
2023-06-11 16:15 ` Benno Lossin
2023-06-27 8:38 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHoZuIz97JN1VSBf@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=gary@garyguo.net \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).