From: Lars Kurth <lars.kurth.xen@gmail.com>
To: "Wieczorkiewicz, Pawel" <wipawel@amazon.de>
Cc: "Tim \(Xen.org\)" <tim@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
"Pohlack, Martin" <mpohlack@amazon.de>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Julien Grall <julien.grall@arm.com>,
'Jan Beulich' <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation
Date: Thu, 15 Aug 2019 16:33:34 +0100 [thread overview]
Message-ID: <18CBBC37-9027-41B7-8375-44FE3E56F79F@gmail.com> (raw)
In-Reply-To: <A373327B-1B2B-4892-97DB-132D1EA7084E@amazon.com>
[-- Attachment #1.1: Type: text/plain, Size: 4994 bytes --]
> On 15 Aug 2019, at 16:19, Wieczorkiewicz, Pawel <wipawel@amazon.de> wrote:
>
> Hi Lars, Julien,
>
> Thanks for the pointers, I will read them up and follow the recommendations with my future contributions.
> Sorry for the mess…
It's not really a mess: it must have been quite a pain to put the mails together manually
And it would become more painful for a second revision
I have been through this myself
> But, let me ask first before reading the wikis, how do you prefer submitting series that contain patches belonging to 2 distinct repos (e.g. xen and livepatch-build-tools)?
That's a good question and a very rare use-case. We split them, as all the tools such as git format-patch only work on one repo
Applying patches also only works on a per repo basis
So, I would send two series. But mention the relationship in the cover letter (and/or patch if it is a single one)
The tools in the docs currently may not work on livepatch-build-tools.git
* First: there is no MAINTAINERS file in livepatch-build-tools.git, which really should be added
* Second: using xen.git:/scripts/add_maintainers.pl may not work when called from within livepatch-build-tools.git
I am going to play with this and update the docs and if needed the tools accordingly
You may have to improvise in the meantime:
* Step 1 & 3 will work: Step 2, option 1 will probably not (which means until I have done this, you may have to follow option 2 and make sure that the right people are CC'ed)
You can also use: https://patchew.org/Xen/ <https://patchew.org/Xen/>, https://patchwork.kernel.org/project/xen-devel/list/ <https://patchwork.kernel.org/project/xen-devel/list/> or https://lore.kernel.org/xen-devel/ <https://lore.kernel.org/xen-devel/> to track some of the changes. I have not had time to add this to the docs yet
Lars
>
> Best Regards,
> Pawel Wieczorkiewicz
>
>
>
>> On 15. Aug 2019, at 16:58, Lars Kurth <lars.kurth.xen@gmail.com <mailto:lars.kurth.xen@gmail.com>> wrote:
>>
>>
>>
>>> On 15 Aug 2019, at 12:38, Julien Grall <julien.grall@arm.com <mailto:julien.grall@arm.com>> wrote:
>>>
>>> Hi,
>>>
>>> I am not going to answer on the patch itself but the process.
>>>
>>> Any series (i.e more than one patch) should contain a cover letter with a rough summary of the goal of the series.
>>>
>>> Furthermore, this 3 patches series has been received as 3 separate threads (i.e in-reply-to is missing). This is making difficult to know that all the patches belongs to the same series. In general, all patches are send as in-reply-to the cover letter. So all the patches sticks together in one thread.
>>>
>>> The cover letter can be generated via git format-patch --cover-letter. Threading is done automatically with git-send-email when all the patches as passed in arguments.
>>>
>>> For more details how to do it, you can read:
>>>
>>> https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series <https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series>
>>>
>>> Cheers,
>>
>> Hi Pawel,
>>
>> thank you for submitting the patch series.
>>
>> We had a couple of new starters recently who followed a similar pattern to you. As a result of this, I recently updated the following docs
>>
>> https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches <https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches> - Definitions and general workflow
>> The bit which saves the most work is https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series <https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series>
>> As for Julien's comment on the threading: see the --thread and --cover-letter option as described in the Sending a Patch Series
>>
>> https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git <https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git> - Basic Git commands fitting into the workflow, including how to deal with reviews
>> https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGit <https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGit> - Basic StGit commands fitting into the workflow, including how to deal with reviews
>> I have not had time to play with git series yet. If anyone in your team uses it let me know
>>
>> In any case: if you follow the instructions the entire submission process and dealing with review comments becomes much easier.
>>
>> As a newcomer, to contributing to Xen, I would greatly appreciate if you could let me know of any issues with the docs, such that we can fix them
>>
>> Regards
>> Lars
>>
>>
>>
>
>
>
>
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
> Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
> Sitz: Berlin
> Ust-ID: DE 289 237 879
>
>
[-- Attachment #1.2: Type: text/html, Size: 16480 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-15 15:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 11:27 [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation Pawel Wieczorkiewicz
2019-08-15 11:38 ` Julien Grall
2019-08-15 14:58 ` Lars Kurth
2019-08-15 15:19 ` Wieczorkiewicz, Pawel
2019-08-15 15:29 ` Julien Grall
2019-08-15 15:32 ` George Dunlap
2019-08-15 15:36 ` Julien Grall
2019-08-15 15:48 ` George Dunlap
2019-08-15 16:00 ` Julien Grall
2019-08-15 16:23 ` George Dunlap
2019-08-15 15:42 ` Wieczorkiewicz, Pawel
2019-08-15 16:29 ` Andrew Cooper
2019-08-15 18:59 ` Lars Kurth
2019-08-21 18:38 ` Konrad Rzeszutek Wilk
2019-08-15 15:33 ` Lars Kurth [this message]
2019-08-15 15:46 ` Lars Kurth
2019-08-15 15:58 ` Julien Grall
2019-08-15 16:17 ` Lars Kurth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18CBBC37-9027-41B7-8375-44FE3E56F79F@gmail.com \
--to=lars.kurth.xen@gmail.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=mpohlack@amazon.de \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wipawel@amazon.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).